diff --git a/docs/audits/evidence/mail-001/README.md b/docs/audits/evidence/mail-001/README.md new file mode 100644 index 0000000..b8b9ff3 --- /dev/null +++ b/docs/audits/evidence/mail-001/README.md @@ -0,0 +1,10 @@ +# MAIL-001 evidence index + +Updated: 2026-08-09 + +- Progress report: `docs/verification/mail-001-job-email-hub.md` +- Commands/results: `docs/audits/verification-log.md` V-126–V-128 +- Hub/legacy-route tests: `job-tracker-ui/src/correspondence-inbox-page.test.tsx` +- Reused review decision tests: `job-tracker-ui/src/gmail-review-page.test.tsx` +- Implementation commit: `6008b4a` +- Mocked provider data only; no real email, provider connection, private content, production service or external request was used. diff --git a/docs/audits/verification-log.md b/docs/audits/verification-log.md index 9915efd..95d2bc2 100644 --- a/docs/audits/verification-log.md +++ b/docs/audits/verification-log.md @@ -157,3 +157,6 @@ Output was reduced to filenames and commit counts. The token artifact appears un | V-123 | `npm.cmd test -- --runInBand src/cv-builder-deep-link.test.tsx`; full `npm.cmd test -- --runInBand`; `npm.cmd run build` | `job-tracker-ui` | Verify custom-section add/edit/reorder/hide/delete confirmation and persistence | PASS — focused 7/7; full 49/49 suites and 182/182 tests; production build | Synthetic variants only; browser not run | N/A | | V-124 | `npm.cmd test -- --runInBand src/cv-builder-deep-link.test.tsx` | `job-tracker-ui` | Verify named expand/collapse/reorder/hide controls, persisted profile-entry overrides and preview failure/retry | PASS — editor 9/9 | Initial preview assertion read the iframe before the retry completed; changed to wait for observable async completion | Test timing corrected | | V-125 | `npm.cmd test -- --runInBand`; `npm.cmd run build`; `git diff --check` | `job-tracker-ui` / repository root | Final CAREER-002 regression, TypeScript/build and patch hygiene | PASS — 49/49 suites, 184/184 tests; production build; no whitespace errors | Fresh FlowCV/browser/production verification not run; line-ending notices only | Environmental/deployment limitation | +| V-126 | Bounded `rg`/`Get-Content` of Phase 9 requirements, correspondence/Gmail routes/pages/shared job component, provider files/tests and architecture/audit reports | Repository root | Revalidate MAIL-001 duplicated navigation, domain ownership, provider and send boundaries | PASS/PARTIAL — inbox and Gmail review were separate routes; job workspace already reuses `Correspondence`; Gmail link/import is mature but provider-neutral hub state and explicit provider draft/send are not implemented | Source inspection only; no provider/account/email access | Confirmed product/domain gaps | +| V-127 | `npm.cmd test -- --runInBand --forceExit src/correspondence-inbox-page.test.tsx src/gmail-review-page.test.tsx` | `job-tracker-ui` | Verify canonical hub views, review reuse, decisions and legacy redirect | PASS — 2 suites, 5/5 tests | Non-force run retained an open handle; force-exit run completed in 50.051s | Existing test-runtime limitation | +| V-128 | `npm.cmd run build`; full `npm.cmd test -- --runInBand --forceExit`; `git diff --check` | `job-tracker-ui` / repository root | MAIL-001 route increment regression, TypeScript/build and patch hygiene | PASS — build; 49/49 suites and 186/186 tests; no whitespace errors | Full Jest took 228.709s and retained existing open-handle notice. One build process remained after compilation; exact task-owned PIDs were stopped and clean rerun passed | Environmental/tooling limitation | diff --git a/docs/verification/application-action-matrix.md b/docs/verification/application-action-matrix.md index 659abfe..dbbe3ca 100644 --- a/docs/verification/application-action-matrix.md +++ b/docs/verification/application-action-matrix.md @@ -48,5 +48,6 @@ This is the rolling action-level evidence index. `PASS (automated/runtime)` is n | Job match terms | bilingual/noisy/short/technology-heavy/filler extraction and honest labels | PASS (seven fixtures + component tests) | NOT RUN | NOT RUN | `qa-001-job-term-quality.md` | | Career Workspace | first/returning/incomplete/loading/import processing/review/failure and recent CV actions | PASS (components; approval gate regression) | NOT RUN | NOT RUN | `career-001-career-workspace.md` | | CV Builder | edit/collapse/add/delete/reorder/hide, save states/latest-data retry, navigation warning and preview failure/retry | PASS (components) | NOT RUN | NOT RUN | `career-002-cv-builder.md` | +| Job email hub | linked/review view switching, Gmail decision component reuse and legacy route redirect | PASS (components; mocked provider data) | NOT RUN | NOT RUN | `mail-001-job-email-hub.md` | Remaining product actions are `NOT STARTED` in the master plan and will be added as their work packages enter verification. The in-app browser is available for local UI checks; configured/real-provider and production access are not documented/configured. diff --git a/docs/verification/mail-001-job-email-hub.md b/docs/verification/mail-001-job-email-hub.md new file mode 100644 index 0000000..831f1a3 --- /dev/null +++ b/docs/verification/mail-001-job-email-hub.md @@ -0,0 +1,45 @@ +# MAIL-001 consolidated job-email hub + +Updated: 2026-08-09 + +Status: `IN PROGRESS`. Canonical hub routing is implemented and locally verified; provider/domain/draft-send work remains. + +## Revalidated current boundaries + +- `/correspondence` listed persisted, job-linked `Correspondence` rows with search/direction/link filters. +- `/correspondence/review` separately rendered Gmail review candidates/suggested jobs and linked back to the inbox. +- The job workspace already embeds the shared `Correspondence` component and therefore reads/writes the same underlying rows rather than a copy. +- Gmail review decisions, import/link/unlink/relink and job creation use existing Gmail APIs. Outlook/Graph and IMAP connection models exist, but this review surface is Gmail-specific. +- The per-job composer currently logs a message to `Correspondence`; it is not a provider-send draft flow. Separate follow-up sending exists elsewhere and must not be mislabeled or silently reused. + +## Implemented first increment + +- `/correspondence` is the canonical **Job email** hub with linked-message and recruitment-suggestion views represented by `?view=review`. +- The review component embeds under the hub with correct heading hierarchy and without duplicate back navigation. +- `/correspondence/review` remains a compatibility route and redirects to the canonical filtered hub. +- Switching to review does not issue the linked-correspondence query; switching views reuses the existing tested review component and APIs. +- No provider connection, sync, import, link or send behavior changed. + +## Verification + +- Focused hub/review: 2 suites, 5/5 tests, including legacy redirect. +- Full frontend: 49/49 suites, 186/186 tests. +- Production build/TypeScript and `git diff --check`: pass. +- Implementation commit: `6008b4a`. + +## Remaining MAIL-001 work + +- Define one provider-neutral thread/list/detail view while preserving Gmail/Graph/IMAP capability differences. +- Surface provider identity, reauthorization, read/unread, pin/read-later/archive/spam/trash only where the provider supports it. +- Share thread detail and link/unlink actions between hub and job workspace. +- Design editable provider drafts with recipient/subject/thread/provider review and explicit confirmed, idempotent send; uncertain failures must not be retried blindly. +- Preserve minimal audit metadata without sensitive body logging; verify Free non-AI access and Pro-only AI assistance. +- Complete link/unlink/dismiss/draft/send/failure/two-user/application-embed tests plus browser/production provider gates. No real email may be sent during repository verification. + +## Validation limitation + +The first focused Jest invocation exhibited the repository's open-handle delay. The passing focused and full runs used `--forceExit`; the full run took 228.709 seconds. A Next build process also failed to exit after compilation; only the exact PIDs started by those build attempts were stopped, then a clean build completed. This is recorded as tooling/runtime behavior, not hidden. + +## Rollback + +Revert `6008b4a`. Both underlying pages/APIs and persisted email/correspondence data remain unchanged; the legacy route returns to direct rendering. diff --git a/docs/work-programmes/decisions.md b/docs/work-programmes/decisions.md index a203dd0..52ecf9f 100644 --- a/docs/work-programmes/decisions.md +++ b/docs/work-programmes/decisions.md @@ -369,3 +369,13 @@ - **Consequences:** original entries use Hide rather than Delete; custom entries receive explicit destructive confirmation. Existing render/public/PDF/version data remains compatible. - **User approval required:** No; this preserves the programme's explicit Career Profile separation and existing data. - **Reversible:** Yes. Revert `a5b74e0` and `2043349`; settings JSON remains backward-compatible. + +## DEC-038 — Job email has one canonical route with filtered compatibility redirects + +- **Date:** 2026-08-09 +- **Decision:** Make `/correspondence` the canonical Job email hub and represent recruitment review as `?view=review`. Redirect the legacy `/correspondence/review` route into that filtered view while reusing the existing review component and APIs. +- **Reason/evidence:** the two pages were separate navigation surfaces over related linked/review workflows, while the job workspace already reuses the same correspondence domain. Route composition removes duplicate information architecture without prematurely rewriting mature Gmail decision logic. +- **Alternatives considered:** delete the old route immediately; copy review cards into the inbox; merge backend endpoints before a provider capability trace; keep both pages indefinitely. These break bookmarks, duplicate behavior, expand risk or preserve the approved UX defect. +- **Consequences:** existing links remain compatible and there is one user-facing hub. Provider-neutral thread state and explicit draft/send remain separate MAIL-001 increments and are not implied by this routing change. +- **User approval required:** No; the product decision to consolidate and preserve route compatibility is explicit. +- **Reversible:** Yes. Revert `6008b4a`; no persisted correspondence/provider data changes. diff --git a/docs/work-programmes/master-progress.md b/docs/work-programmes/master-progress.md index 869dc0d..9135830 100644 --- a/docs/work-programmes/master-progress.md +++ b/docs/work-programmes/master-progress.md @@ -3,7 +3,7 @@ Updated: 2026-08-09 - **Overall programme status:** Active. Six packages are locally verified; nineteen packages through CAREER-002 are implemented with automated/runtime evidence but blocked from applicable browser/provider/production gates; MAIL-001 is in progress. -- **Current work package:** `MAIL-001` — consolidated job-email hub and explicit sending (`IN PROGRESS`); revalidate the current Gmail Review/Correspondence/provider boundaries before editing. +- **Current work package:** `MAIL-001` — consolidated job-email hub and explicit sending (`IN PROGRESS`); canonical routing is pushed, and provider-neutral shared thread/detail plus explicit draft/send is next. - **Completed work packages:** None are `DONE`; all repository security/AI packages still have applicable browser, provider and/or production gates. - **Locally verified work:** SEC-001, SEC-002, SEC-003, SEC-005A, CORE-001 and PROD-002 (`VERIFIED LOCALLY`). - **Implemented, verification incomplete:** SEC-004, SEC-005B, SEC-008, CORE-002, BG-001, OPS-001A/B/C, POL-001/002, AI-001/002/003/004, UX-001/002, QA-001, CAREER-001 and CAREER-002 (`IMPLEMENTED — NOT VERIFIED`). CAREER-002 now protects unsaved edits and provides tested structured custom-entry, profile-override and preview-error interactions; all automated/build gates pass. @@ -12,7 +12,7 @@ Updated: 2026-08-09 - **Deferred work:** None. Conditional multi-replica coordination, model deletion, realtime operation delivery and unrelated production changes remain outside current packages. - **Next five work packages:** MAIL-001 consolidated email experience; JOBS-001 job-search/application redesign; HOME-001 homepage/Pro promotion; UX-003 authentication/profile polish; PRODUCT-001 homepage/Pro claims. SEC-006/007 resume after package-index permission. - **Status counts:** 6 `VERIFIED LOCALLY`; 19 `IMPLEMENTED — NOT VERIFIED`; 1 `IN PROGRESS`; 8 `NOT STARTED`; 5 `BLOCKED`; 0 `DONE`; 0 `DEFERRED`. -- **Test status:** backend 601/601; frontend 49/49 suites and 184/184 tests; CAREER-002 focused 17/17 (editor 9/9) and CAREER-001 focused 16/16; production build and patch check pass. CAREER browser/production presentation was not run because browser tooling was finalized; prior UX-002 browser and sidecar 22/22 remain green. +- **Test status:** backend 601/601; frontend 49/49 suites and 186/186 tests; MAIL-001 focused 5/5; CAREER-002 focused 17/17 and CAREER-001 16/16; production build and patch check pass. Jest open-handle/slow-run behavior is recorded in V-127/V-128. - **Deployment status:** No deployment performed. No production migrations were run. AI operation worker remains disabled by default. - **Production status:** Unchanged and unverified. No provider/model call, model pull, external request or paid API occurred. - **Known regressions:** None found by automated suites. Jest still needs `--forceExit` and reports its existing open-handle notice. Direct clean EF-only SQLite migration still hits the pre-existing historical blank-chain defect before later migrations; normal startup owns reconciliation. Cross-feature monthly AI usage accounting remains a rollout gap. @@ -46,5 +46,6 @@ Updated: 2026-08-09 - `docs/verification/qa-001-job-term-quality.md` - `docs/verification/career-001-career-workspace.md` - `docs/verification/career-002-cv-builder.md` +- `docs/verification/mail-001-job-email-hub.md` - `docs/verification/prod-002-ai-evaluation.md` - `docs/work-programmes/master-work-plan.md` diff --git a/docs/work-programmes/master-work-plan.md b/docs/work-programmes/master-work-plan.md index f8fab7a..b1d7a23 100644 --- a/docs/work-programmes/master-work-plan.md +++ b/docs/work-programmes/master-work-plan.md @@ -651,9 +651,9 @@ Ordering differences from the suggested list: - **Required production verification:** provider read/draft/send requires explicit authorized synthetic account; never real unsolicited email. - **Status:** `IN PROGRESS`. - **Blocker:** real provider verification external; mocked/local implementation not blocked after dependencies. -- **Evidence:** final product decisions in source programme. -- **Commit:** none. -- **Remaining work:** route compatibility and one data model, no copies. +- **Evidence:** `docs/verification/mail-001-job-email-hub.md`; V-126–V-128. Canonical hub/review/legacy redirect passes 5/5 focused, 49/49 suites and 186/186 full plus build. +- **Commit:** `6008b4a` (`feat(email): consolidate correspondence routes`) — first increment only. +- **Remaining work:** provider-neutral shared detail/state; reauth/capability actions; editable explicit/idempotent draft/send and audit; tenant/free/pro/application tests; browser/production. No real email; uncertain sends need manual reconciliation. ### JOBS-001 — Job-search source and assessment redesign diff --git a/docs/work-programmes/session-handoff.md b/docs/work-programmes/session-handoff.md index 069160c..cd4e6bb 100644 --- a/docs/work-programmes/session-handoff.md +++ b/docs/work-programmes/session-handoff.md @@ -2,17 +2,17 @@ Updated: 2026-08-09 -- **Exact current task:** MAIL-001 — trace Gmail Review, Correspondence inbox/application embedding, provider connect/search/import/link/draft/send/archive/pin/read-later/spam/trash flows and existing tests before consolidating UI. -- **Last completed step:** CAREER-002 repository implementation was completed and pushed in `b58cc19`, `a5b74e0`, `2043349`. Save integrity, explicit custom entries, named profile-entry controls and visible preview retry pass all automated/build gates. -- **Files currently modified:** CAREER-002 evidence/log/master tracking documents only. Application code/tests are committed and pushed. -- **Commands already run:** complete Builder capability trace; three focused interaction cycles; three full frontend/build regressions; diff review/check; three implementation commits/pushes. See V-120–V-125. -- **Test results:** CAREER-002 focused 17/17 including editor 9/9; frontend full 49/49 suites and 184/184 tests; production build/TypeScript and patch check pass. -- **Services currently running:** none. Browser tabs were finalized earlier. Pre-existing Docker services were not changed. -- **Temporary files or processes:** none. No FlowCV account, private CV, external provider/model, paid service or production service was accessed. -- **Production changes currently active:** none. No deployment, migration, provider call or production payload occurred. -- **Rollback status:** revert CAREER-002 `2043349`, `a5b74e0`, `b58cc19` in reverse order; no schema/config/dependency/data migration. Production is unchanged. -- **Uncommitted changes:** CAREER-002 evidence/tracking documents only; commit/push before MAIL-001 application changes. -- **Known failures:** fresh FlowCV and CAREER browser/production verification; DOCX is documented as an extension point rather than a confirmed current export; real providers, MariaDB/SMTP/production unavailable; SEC-006 needs internet/package-index permission; parser isolation remains SEC-007. -- **Exact next action:** commit/push CAREER-002 final evidence, then read `work.md:454-527`, email architecture/audit findings, correspondence/Gmail components/controllers/services and provider tests; produce a shared-domain/route/action gap matrix before the smallest MAIL-001 change. -- **Work that can continue independently:** MAIL-001 repository work and later UX packages. SEC-006/007 await package-index permission; PROD-001/003/004 await production access. -- **Decisions still required from the user:** none for synthetic repository work. Provider connection/send testing, internet/package upgrades, private data, external/paid providers and production actions retain explicit approval/safety gates; SEC-009 retention/legal policy remains unresolved. +- **Exact current task:** MAIL-001 — trace backend provider capabilities and every draft/send endpoint/audit/idempotency path, then design the provider-neutral shared thread/detail and explicit-send contract without sending real email. +- **Last completed step:** the canonical Job email hub and legacy Gmail-review redirect were committed/pushed as `6008b4a`. Linked and review views reuse existing APIs/components and pass focused/full/build gates. +- **Files currently modified:** MAIL-001 verification/log/master tracking documents only. Application code/tests are committed and pushed. +- **Commands already run:** Phase 9/frontend/provider/architecture/test trace; focused hub/review tests; full frontend; production build; diff review/check; exact hung task-owned Node cleanup; implementation commit/push. See V-126–V-128. +- **Test results:** MAIL-001 focused 2 suites/5 tests; frontend full 49/49 suites and 186/186 tests; production build/TypeScript and patch check pass. Jest required force exit and full run took 228.709s. +- **Services currently running:** none started intentionally. Exact task-owned hung Jest/build Node processes were stopped; Codex browser runtimes were not touched. Pre-existing Docker services were not changed. +- **Temporary files or processes:** none. No provider account, private email, external model, paid service or production service was accessed. +- **Production changes currently active:** none. No deployment, migration, provider connection/sync/send or production payload occurred. +- **Rollback status:** revert `6008b4a` for hub routing; no schema/config/dependency/data migration. CAREER rollback records remain current. Production is unchanged. +- **Uncommitted changes:** MAIL-001 evidence/tracking documents only; commit/push before the next application increment. +- **Known failures:** provider-neutral details/actions and explicit idempotent send remain; Gmail is the only mature review UI; real provider/SMTP/MariaDB/production unavailable; fresh browser session unavailable this turn; Jest open handles; SEC-006 needs internet/package-index permission; parser isolation remains SEC-007. +- **Exact next action:** commit/push MAIL-001 progress evidence, then inspect `GmailController`, Graph/IMAP controllers/services/models, `CorrespondenceController`, follow-up send endpoint and audit storage/tests; write a capability/send-state matrix before changing the domain. +- **Work that can continue independently:** remaining MAIL-001 repository work and later UX packages. SEC-006/007 await package-index permission; PROD-001/003/004 await production access. +- **Decisions still required from the user:** none for synthetic/code-inspected repository work. Any provider connection or send test, internet/package upgrades, private data, external/paid providers and production actions retain explicit approval/safety gates; SEC-009 retention/legal policy remains unresolved.