cesnimda/jobtrackingapp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(rd21): expose committed revisions and refresh answer sources

Browse Source
This commit is contained in:
cesnimda
2026-10-23 12:51:36 +02:00
parent 05a738693e
commit 1b89a779d0
4 changed files with 141 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
job-tracker-ui/src/application-workspace-overlay.test.tsx
+56 -1
View File
@@ -27,7 +27,7 @@ jest.mock("./components/ApplicationAssets", () => ({
</div>
),
ApplicationCvSection: () => <div>CV section</div>,
ApplicationPackageDraftsSection: ({ jobId, initialApplicationAnswer, initialRecruiterMessage, onDirtyChange }: { jobId: number; initialApplicationAnswer: string; initialRecruiterMessage: string; onDirtyChange?: (dirty: boolean) => void }) => <div>Application drafts section<output data-testid="answer-props">{jobId}|{initialApplicationAnswer}|{initialRecruiterMessage}</output><button onClick={() => onDirtyChange?.(true)}>Make answers dirty</button></div>,
ApplicationPackageDraftsSection: ({ jobId, initialApplicationAnswer, initialRecruiterMessage, initialRevision, onDirtyChange }: { jobId: number; initialApplicationAnswer: string; initialRecruiterMessage: string; initialRevision: number; onDirtyChange?: (dirty: boolean) => void }) => <div>Application drafts section<output data-testid="answer-props">{jobId}|{initialApplicationAnswer}|{initialRecruiterMessage}|{initialRevision}</output><button onClick={() => onDirtyChange?.(true)}>Make answers dirty</button></div>,
SubmittedPackagesSection: () => <div>Frozen packages section</div>,
}));
jest.mock("./components/InterviewPrep", () => ({ ApplicationInterviewPrep: () => <div>Interview section</div> }));
@@ -77,6 +77,7 @@ const job = {
const overview = {
id: 42,
revision: 7,
jobTitle: "Backend Developer",
company: "Acme",
location: "Oslo",
@@ -151,6 +152,7 @@ function renderTable(path = "/jobs") {
}
beforeEach(() => {
mockedApi.get.mockReset();
window.localStorage.removeItem("uiLanguage");
mockedApi.get.mockImplementation((url: string) => {
if (url === "/companies") return Promise.resolve({ data: [{ id: 1, name: "Acme" }] } as any);
@@ -411,3 +413,56 @@ test("holds answers until their aggregate matches the route and ignores a late p
expect(mockedApi.post).not.toHaveBeenCalled();
expect(mockedApi.put).not.toHaveBeenCalled();
});
test("entering Answers waits for a fresh coherent snapshot after sibling writes", async () => {
renderTable("/jobs/42?section=application&sub=letter");
await screen.findByRole("heading", { name: "Backend Developer" });
let resolve!: (value: any) => void;
const pending = new Promise<any>(done => { resolve = done; });
mockedApi.get.mockReturnValueOnce(pending);
fireEvent.click(screen.getByRole("tab", { name: "Answers & message draft" }));
expect(screen.queryByTestId("answer-props")).not.toBeInTheDocument();
await act(async () => { resolve({ data: { ...overview, revision: 8, applicationAnswerDraft: "Fresh answer", recruiterMessageDraft: "Fresh message" } }); await pending; });
expect(await screen.findByTestId("answer-props")).toHaveTextContent("42|Fresh answer|Fresh message|8");
expect(mockedApi.get.mock.calls.filter(([url]) => url === "/jobapplications/42/workspace")).toHaveLength(2);
});
test("a late previous Answers-entry read cannot enable the current editor", async () => {
const { router } = renderTable("/jobs/42?section=application&sub=letter");
await screen.findByRole("heading", { name: "Backend Developer" });
let resolveOld!: (value: any) => void;
let resolveNew!: (value: any) => void;
const oldRead = new Promise<any>(done => { resolveOld = done; });
const newRead = new Promise<any>(done => { resolveNew = done; });
mockedApi.get.mockReturnValueOnce(oldRead).mockReturnValueOnce(newRead);
await act(async () => { await router.navigate("/jobs/42?section=application&sub=answers"); });
await act(async () => { await router.navigate("/jobs/42?section=application&sub=letter"); });
await act(async () => { await router.navigate("/jobs/42?section=application&sub=answers"); });
await act(async () => { resolveOld({ data: { ...overview, revision: 8 } }); await oldRead; });
expect(screen.queryByTestId("answer-props")).not.toBeInTheDocument();
await act(async () => { resolveNew({ data: { ...overview, revision: 9, applicationAnswerDraft: "Current answer" } }); await newRead; });
expect(await screen.findByTestId("answer-props")).toHaveTextContent("42|Current answer|Saved recruiter message|9");
});
test("a failed Answers-entry read stays closed until a successful retry", async () => {
renderTable("/jobs/42?section=application&sub=letter");
await screen.findByRole("heading", { name: "Backend Developer" });
mockedApi.get.mockRejectedValueOnce({ response: { status: 503 } });
fireEvent.click(screen.getByRole("tab", { name: "Answers & message draft" }));
const retry = await screen.findByRole("button", { name: "Retry" });
expect(screen.queryByTestId("answer-props")).not.toBeInTheDocument();
mockedApi.get.mockResolvedValueOnce({ data: { ...overview, revision: 9, applicationAnswerDraft: "Recovered answer" } });
fireEvent.click(retry);
expect(await screen.findByTestId("answer-props")).toHaveTextContent("42|Recovered answer|Saved recruiter message|9");
});
test("leaving a pending direct Answers entry still loads the workspace header", async () => {
let resolve!: (value: any) => void;
const pending = new Promise<any>(done => { resolve = done; });
mockedApi.get.mockReturnValueOnce(pending);
const { router } = renderTable("/jobs/42?section=application&sub=answers");
await act(async () => { await router.navigate("/jobs/42?section=application&sub=letter"); });
expect(await screen.findByRole("heading", { name: "Backend Developer" })).toBeInTheDocument();
await act(async () => { resolve({ data: { ...overview, jobTitle: "Late header" } }); await pending; });
expect(screen.queryByRole("heading", { name: "Late header" })).not.toBeInTheDocument();
});
job-tracker-ui/src/views/ApplicationWorkspacePage.tsx
+18 -5
View File
@@ -78,6 +78,9 @@ export function ApplicationWorkspace({
const [overlaySubsection, setOverlaySubsection] = useState<{ section: WorkspaceSectionKey; value: string } | null>(null);
const subsection = onSectionChange && overlaySubsection?.section === section
? overlaySubsection.value : workspaceSubsection(sectionOverride ?? params.get("section"), params.get("sub"));
const answersActive = section === "application" && subsection === "answers";
const answersEntry = useMemo(() => ({ jobId, answersActive }), [jobId, answersActive]);
const [readyAnswersEntry, setReadyAnswersEntry] = useState<object | null>(null);
const sectionId = useId();
const secondaryId = useId();
const panelRef = useRef<HTMLDivElement>(null);
@@ -85,6 +88,7 @@ export function ApplicationWorkspace({
const [loadedOverview, setOverview] = useState<WorkspaceOverview | null>(null);
const overview = loadedOverview?.id === jobId ? loadedOverview : null;
const overviewRequest = useRef(0);
const overviewLoadedJob = useRef<number | null>(null);
const [error, setError] = useState<ViewResourceError | null>(null);
const [loading, setLoading] = useState(true);
const [editOpen, setEditOpen] = useState(false);
@@ -136,7 +140,11 @@ export function ApplicationWorkspace({
setError(null);
setLoading(true);
const next = await applicationWorkspaceApi.overview(jobId);
if (request === overviewRequest.current) setOverview(next);
if (request === overviewRequest.current) {
setOverview(next);
overviewLoadedJob.current = next.id;
setReadyAnswersEntry(answersEntry);
}
} catch (err) {
if (request !== overviewRequest.current) return;
const status = (err as { response?: { status?: number } })?.response?.status;
@@ -144,12 +152,17 @@ export function ApplicationWorkspace({
} finally {
if (request === overviewRequest.current) setLoading(false);
}
}, [jobId, t]);
}, [jobId, t, answersEntry]);
const previousOverviewSource = useRef<{ jobId: number; t: typeof t; answersActive: boolean } | null>(null);
useEffect(() => {
void load();
const previous = previousOverviewSource.current;
previousOverviewSource.current = { jobId, t, answersActive };
// Each Answers entry needs a coherent source; leaving it does not need another aggregate read.
if (answersActive || !previous?.answersActive || previous.jobId !== jobId || previous.t !== t || overviewLoadedJob.current !== jobId) void load();
else setLoading(false);
return () => { overviewRequest.current += 1; };
}, [load]);
}, [load, answersActive, jobId, t]);
useEffect(() => {
// Direct entry gets a named target; keyboard tab activation keeps tab focus.
@@ -261,7 +274,7 @@ export function ApplicationWorkspace({
<Box role="tabpanel" id={`${secondaryId}-panel`} aria-labelledby={`${secondaryId}-${subsection}`} tabIndex={0} sx={{ display: "grid", gap: 2, minWidth: 0 }}>
{section === "application" && subsection === "cv" && jobId > 0 && <ApplicationCvSection key={jobId} jobId={jobId} includePackages={false} />}
{section === "application" && subsection === "letter" && jobId > 0 && <ApplicationCoverLetterSection key={jobId} jobId={jobId} onDirtyChange={setCoverLetterDirty} />}
{section === "application" && subsection === "answers" && overview && jobId > 0 && <ApplicationPackageDraftsSection
{answersActive && readyAnswersEntry === answersEntry && overview && jobId > 0 && <ApplicationPackageDraftsSection
key={jobId}
jobId={jobId}
initialRevision={overview.revision}