feat(processing): persist safe atomic operation history

2026-10-28 15:54:37 +01:00
parent 5f261083f3
commit 1f87301ee9
17 changed files with 501 additions and 32 deletions
@@ -0,0 +1,52 @@
+using JobTrackerApi.Models;
+using JobTrackerApi.Services;
+using Microsoft.EntityFrameworkCore;
+using Xunit;
+
+namespace JobTrackerApi.MariaDb.Tests;
+
+public sealed class UserOperationHistoryPersistenceTests
+{
+    private static CreateUserOperation Request(string key) => new("cv.process", key, "authorized", "local_only");
+
+    [Fact]
+    public async Task Concurrent_claim_and_repeated_stage_have_one_durable_event_each()
+    {
+        await using var database = await MariaDbDatabase.CreateAsync();
+        await using (var owner = database.Context())
+            await new UserOperationStore(owner, TimeProvider.System).CreateAsync(Request("history-concurrency"), default);
+        await using var first = database.Context(null!);
+        await using var second = database.Context(null!);
+        var claims = await Task.WhenAll(new UserOperationStore(first, TimeProvider.System).ClaimNextAsync(TimeSpan.FromSeconds(30), default),
+            new UserOperationStore(second, TimeProvider.System).ClaimNextAsync(TimeSpan.FromSeconds(30), default));
+        var lease = Assert.Single(claims.OfType<UserOperationLease>());
+        await using var ownerOne = database.Context();
+        await using var ownerTwo = database.Context();
+        var stages = await Task.WhenAll(new UserOperationStore(ownerOne, TimeProvider.System).ReportStageAsync(lease.OperationId, lease.LeaseToken, "cv_extracting", default),
+            new UserOperationStore(ownerTwo, TimeProvider.System).ReportStageAsync(lease.OperationId, lease.LeaseToken, "cv_extracting", default));
+        Assert.All(stages, count => Assert.Equal(1, count));
+        await using var readback = database.Context();
+        var events = await readback.UserOperationEvents.OrderBy(item => item.Id).ToListAsync();
+        Assert.Equal(new[] { "Created", "Claimed", "StageChanged" }, events.Select(item => item.Kind));
+        Assert.All(events, item => Assert.Equal("rd21-owner", item.OwnerUserId));
+        await using var other = database.Context("other");
+        Assert.Empty(await other.UserOperationEvents.ToListAsync());
+    }
+
+    [Fact]
+    public async Task Event_insert_failure_rolls_back_completion_and_notifications_in_MariaDB()
+    {
+        await using var database = await MariaDbDatabase.CreateAsync();
+        await using var owner = database.Context();
+        var store = new UserOperationStore(owner, TimeProvider.System);
+        var id = (await store.CreateAsync(Request("history-rollback"), default)).Operation.Id;
+        await using var worker = database.Context(null!);
+        var lease = Assert.IsType<UserOperationLease>(await new UserOperationStore(worker, TimeProvider.System).ClaimNextAsync(TimeSpan.FromSeconds(30), default));
+        await owner.Database.ExecuteSqlRawAsync("CREATE TRIGGER fail_history BEFORE INSERT ON UserOperationEvents FOR EACH ROW SIGNAL SQLSTATE '45000' SET MESSAGE_TEXT = 'synthetic event insert failure';");
+        await Assert.ThrowsAnyAsync<Exception>(() => store.CompleteAsync(id, lease.LeaseToken, null, default));
+        await using var readback = database.Context();
+        Assert.Equal(OperationStatuses.Running, (await readback.UserOperations.SingleAsync()).Status);
+        Assert.Equal(2, await readback.UserOperationEvents.CountAsync());
+        Assert.Empty(await readback.UserNotifications.ToListAsync());
+    }
+}