refactor(profile): slim ProfilePage and CareerProfilePage to their own concerns
Complete the Phase 2.2 split. Each dedicated component now carries only its own state, effects, and JSX; the shared-copy duplication from the split checkpoint is removed. - ProfilePage (/profile): 1372 -> ~495 lines. Dropped the 700-line master-CV block, all CV/rewrite/PDF state + helpers + the extraction-run polling effects. loadProfile now fetches only /auth/me (no runs/jobs). Saves identity only. - CareerProfilePage (/career): dropped identity fields, password, 2FA/sessions and their state; loadProfile no longer sets identity fields. Saves the master profile only. Owns the master-CV editing surface. Both save through the partial-update PUT /auth/profile, so neither can overwrite the other's data. The master career profile stays the only editable source of truth on /career. Tests: the CV-editing tests in profile-page.test.tsx now render CareerProfilePage (where that surface lives) — all 5 pass, fixing 4 pre-existing failures that were caused by the display:none shared block. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -246,11 +246,6 @@ export default function CareerProfilePage() {
|
||||
const [avatarFile, setAvatarFile] = useState<File | null>(null);
|
||||
const [cropOpen, setCropOpen] = useState(false);
|
||||
|
||||
const [email, setEmail] = useState("");
|
||||
const [userName, setUserName] = useState("");
|
||||
const [firstName, setFirstName] = useState("");
|
||||
const [lastName, setLastName] = useState("");
|
||||
const [displayName, setDisplayName] = useState("");
|
||||
const [headline, setHeadline] = useState("");
|
||||
const [profileCvText, setProfileCvText] = useState("");
|
||||
const [rewritingSection, setRewritingSection] = useState(false);
|
||||
@@ -273,8 +268,6 @@ export default function CareerProfilePage() {
|
||||
const [structuredCv, setStructuredCv] = useState<StructuredCvProfile>(emptyStructuredCv());
|
||||
const [extractionRuns, setExtractionRuns] = useState<ExtractionRun[]>([]);
|
||||
const runStatusRef = useRef<Record<number, string>>({});
|
||||
const [currentPassword, setCurrentPassword] = useState("");
|
||||
const [newPassword, setNewPassword] = useState("");
|
||||
|
||||
// Keep a ref to the latest carousel so the unmount cleanup can revoke the
|
||||
// outstanding preview object URLs without re-running on every change.
|
||||
@@ -308,11 +301,6 @@ export default function CareerProfilePage() {
|
||||
]);
|
||||
const r = profileResponse;
|
||||
setMe(r.data);
|
||||
setEmail(r.data?.email ?? "");
|
||||
setUserName(r.data?.userName ?? "");
|
||||
setFirstName(r.data?.firstName ?? "");
|
||||
setLastName(r.data?.lastName ?? "");
|
||||
setDisplayName(r.data?.displayName ?? "");
|
||||
setProfileCvText(r.data?.profileCvText ?? "");
|
||||
setStructuredCv(parseStructuredCvJson(r.data?.profileCvStructureJson));
|
||||
setExtractionRuns(runsResponse.data ?? []);
|
||||
@@ -570,36 +558,9 @@ export default function CareerProfilePage() {
|
||||
</Box>
|
||||
</Box>
|
||||
|
||||
{!careerOnly ? <>
|
||||
<AuthStatusCard />
|
||||
<GoogleAuthCard />
|
||||
<MicrosoftAuthCard />
|
||||
</> : null}
|
||||
|
||||
<Box sx={{ mt: 3, display: "grid", gridTemplateColumns: { xs: "1fr", md: "1fr 1fr" }, gap: 2 }}>
|
||||
{!careerOnly ? <Box sx={{ gridColumn: "1 / -1" }}>
|
||||
<Typography variant="h6">{t("profileAccountSection")}</Typography>
|
||||
{!isLocal ? (
|
||||
<Alert severity="info" sx={{ mt: 1 }}>
|
||||
{t("profileReadOnlyInfo")}
|
||||
</Alert>
|
||||
) : null}
|
||||
</Box> : null}
|
||||
|
||||
{!careerOnly ? <>
|
||||
<TextField label={t("profileDisplayName")} value={displayName} onChange={(e) => setDisplayName(e.target.value)} disabled={!isLocal} fullWidth />
|
||||
<TextField label={t("profileUsername")} value={userName} onChange={(e) => setUserName(e.target.value)} disabled={!isLocal} fullWidth />
|
||||
<TextField label={t("profileFirstName")} value={firstName} onChange={(e) => setFirstName(e.target.value)} disabled={!isLocal} fullWidth />
|
||||
<TextField label={t("profileLastName")} value={lastName} onChange={(e) => setLastName(e.target.value)} disabled={!isLocal} fullWidth />
|
||||
<TextField label={t("profileEmail")} value={email} onChange={(e) => setEmail(e.target.value)} disabled={!isLocal} fullWidth />
|
||||
<TextField
|
||||
label={t("profileHeadline")}
|
||||
value={headline}
|
||||
onChange={(e) => setHeadline(e.target.value)}
|
||||
helperText={t("profileHeadlineHelp")}
|
||||
fullWidth
|
||||
/>
|
||||
</> : null}
|
||||
|
||||
<Box sx={{ gridColumn: "1 / -1", p: 2, borderRadius: 3, border: "1px solid", borderColor: "divider", backgroundColor: "background.default", display: careerOnly ? "block" : "none" }}>
|
||||
<Box sx={{ display: "flex", justifyContent: "space-between", gap: 2, flexWrap: "wrap", alignItems: "center", mb: 1.5 }}>
|
||||
@@ -1307,14 +1268,9 @@ export default function CareerProfilePage() {
|
||||
onClick={async () => {
|
||||
setLoading(true);
|
||||
try {
|
||||
// Scoped save: /career persists only the master profile, /profile only identity.
|
||||
// The backend (PUT /auth/profile) does partial updates — omitted fields are left
|
||||
// unchanged — so neither surface wipes the other's data.
|
||||
const payload = careerOnly
|
||||
? { profileCvText, profileCvStructureJson: JSON.stringify(structuredCv) }
|
||||
: { email, userName, firstName, lastName, displayName };
|
||||
await api.put("/auth/profile", payload);
|
||||
if (!careerOnly) window.localStorage.setItem("profileHeadline", headline.trim());
|
||||
// /career saves only the master profile. The backend does partial updates, so
|
||||
// omitting identity fields leaves them untouched (they are owned by /profile).
|
||||
await api.put("/auth/profile", { profileCvText, profileCvStructureJson: JSON.stringify(structuredCv) });
|
||||
await loadProfile();
|
||||
toast(t("profileUpdated"), "success");
|
||||
} catch (e: any) {
|
||||
@@ -1329,43 +1285,9 @@ export default function CareerProfilePage() {
|
||||
</Button>
|
||||
</Box>
|
||||
|
||||
{!careerOnly ? <Box sx={{ gridColumn: "1 / -1", mt: 1 }}>
|
||||
<Divider sx={{ mb: 2 }} />
|
||||
<Typography variant="h6">{t("profileChangePassword")}</Typography>
|
||||
{!isLocal ? <Typography sx={{ color: "text.secondary" }}>{t("profilePasswordLocalOnly")}</Typography> : null}
|
||||
</Box> : null}
|
||||
|
||||
{!careerOnly ? <>
|
||||
<TextField label={t("profileCurrentPassword")} type="password" value={currentPassword} onChange={(e) => setCurrentPassword(e.target.value)} disabled={!isLocal} fullWidth />
|
||||
<TextField label={t("profileNewPassword")} type="password" value={newPassword} onChange={(e) => setNewPassword(e.target.value)} disabled={!isLocal} fullWidth />
|
||||
|
||||
<Box sx={{ gridColumn: "1 / -1", display: "flex", justifyContent: "flex-end" }}>
|
||||
<Button
|
||||
variant="outlined"
|
||||
disabled={!isLocal || loading}
|
||||
onClick={async () => {
|
||||
setLoading(true);
|
||||
try {
|
||||
await api.post("/auth/change-password", { currentPassword, newPassword });
|
||||
setCurrentPassword("");
|
||||
setNewPassword("");
|
||||
toast(t("profilePasswordUpdated"), "success");
|
||||
} catch (e: any) {
|
||||
const msg = e?.response?.data || e?.message || t("profilePasswordUpdateFailed");
|
||||
toast(String(msg), "error");
|
||||
} finally {
|
||||
setLoading(false);
|
||||
}
|
||||
}}
|
||||
>
|
||||
{t("profileUpdatePassword")}
|
||||
</Button>
|
||||
</Box>
|
||||
</> : null}
|
||||
</Box>
|
||||
|
||||
{!careerOnly && isLocal ? <TwoFactorSettingsCard /> : null}
|
||||
{!careerOnly && isLocal ? <SessionsSettingsCard /> : null}
|
||||
</Paper>
|
||||
);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user