cesnimda/jobtrackingapp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(cv): gate AI proposals on grounding and source freshness

Browse Source
This commit is contained in:
cesnimda
2026-10-08 14:28:06 +02:00
parent d8d262e4d1
commit 2398ff354e
27 changed files with 2553 additions and 157 deletions
Download Patch File Download Diff File Expand all files Collapse all files
job-tracker-ui/src/components/cv/AiSectionAssistant.tsx
+58 -17
View File
@@ -1,53 +1,94 @@
import React, { useEffect, useState } from "react";
import React, { useEffect, useRef, useState } from "react";
import AutoFixHighIcon from "@mui/icons-material/AutoFixHigh";
import { Alert, Box, Button, MenuItem, Paper, Stack, TextField, Typography } from "@mui/material";
import { getApiErrorMessage } from "../../api";
import { useAccountPlan } from "../../accountPlan";
import { AI_ACTIONS, cvBuilderApi } from "../../cvBuilder";
import { AI_ACTIONS, CvAiCallbacks, CvAiProposal, normalizeCvLanguage } from "../../cvBuilder";
import { useToast } from "../../toast";
import ProFeatureNotice from "../ProFeatureNotice";
import { useI18n } from "../../i18n/I18nProvider";
type Props = {
type Props = CvAiCallbacks & {
sectionName: string;
text: string;
context?: string;
documentLanguage?: string | null;
onApply: (suggestion: string) => void;
targetId: string;
};
const SECTION_ACTIONS = new Set(["improve", "professional", "shorten", "grammar", "impact", "bullets"]);
export default function AiSectionAssistant({ sectionName, text, context, documentLanguage, onApply }: Props) {
export default function AiSectionAssistant({ sectionName, text, context, documentLanguage, targetId, onGenerate, onAccept }: Props) {
const { t } = useI18n();
const { toast } = useToast();
const { canUseAi } = useAccountPlan();
const [open, setOpen] = useState(false);
const [action, setAction] = useState("improve");
const [suggestion, setSuggestion] = useState("");
const [proposal, setProposal] = useState<CvAiProposal | null>(null);
const [busy, setBusy] = useState(false);
const normalizedLanguage = documentLanguage === "no" || documentLanguage === "nb" ? "nb-NO" : documentLanguage ?? "en";
const [applying, setApplying] = useState(false);
const requestId = useRef(0);
const normalizedLanguage = normalizeCvLanguage(documentLanguage);
const [targetLanguage, setTargetLanguage] = useState(normalizedLanguage);
useEffect(() => setTargetLanguage(normalizedLanguage), [normalizedLanguage]);
useEffect(() => {
requestId.current += 1;
setProposal(null);
setSuggestion("");
setBusy(false);
setApplying(false);
return () => { requestId.current += 1; };
}, [text, targetId, normalizedLanguage, canUseAi]);
const discard = () => {
requestId.current += 1;
setProposal(null);
setSuggestion("");
setBusy(false);
setApplying(false);
};
const run = async () => {
if (!text.trim() || !canUseAi) return;
if (!text.trim() || !canUseAi || busy) return;
const request = ++requestId.current;
setBusy(true);
try {
const response = await cvBuilderApi.aiAssist({
const response = await onGenerate({
action,
text,
targetId,
language: targetLanguage,
context: [`Section: ${sectionName}. Preserve facts and do not invent achievements.`, context].filter(Boolean).join("\n"),
});
if (request !== requestId.current) return;
setProposal(response);
setSuggestion(response.result);
} catch (error) {
toast(getApiErrorMessage(error, t("cvAiFailed")), "error");
if (request === requestId.current) toast(getApiErrorMessage(error, t("cvAiFailed")), "error");
} finally {
setBusy(false);
if (request === requestId.current) { setBusy(false); setApplying(false); }
}
};
const accept = async () => {
if (!proposal || busy) return;
const request = ++requestId.current;
setBusy(true);
setApplying(true);
try {
await onAccept(proposal, suggestion);
if (request !== requestId.current) return;
discard();
setOpen(false);
toast(t("cvAiApplied", { section: sectionName }), "success");
} catch (error) {
if (request === requestId.current) toast(getApiErrorMessage(error, t("cvAiFailed")), "error");
} finally {
if (request === requestId.current) { setBusy(false); setApplying(false); }
}
};
@@ -74,26 +115,26 @@ export default function AiSectionAssistant({ sectionName, text, context, documen
<Paper variant="outlined" sx={{ p: 1.25, borderColor: "primary.main", bgcolor: "action.hover" }}>
<Stack spacing={1}>
<Stack direction={{ xs: "column", sm: "row" }} spacing={1} alignItems={{ sm: "center" }}>
<TextField select size="small" label={t("cvAiAction")} value={action} onChange={(event) => setAction(event.target.value)} sx={{ minWidth: 190 }}>
<TextField select size="small" disabled={busy} label={t("cvAiAction")} value={action} onChange={(event) => setAction(event.target.value)} sx={{ minWidth: 190 }}>
{AI_ACTIONS.filter((item) => SECTION_ACTIONS.has(item.key)).map((item) => <MenuItem key={item.key} value={item.key}>{actionLabel(item.key, item.label, t)}</MenuItem>)}
</TextField>
<TextField select size="small" label={t("cvAiLanguage")} value={targetLanguage} onChange={(event) => setTargetLanguage(event.target.value)} sx={{ minWidth: 150 }}>
<TextField select size="small" disabled={busy} label={t("cvAiLanguage")} value={targetLanguage} onChange={(event) => setTargetLanguage(event.target.value)} sx={{ minWidth: 150 }}>
<MenuItem value="en">{t("languageEnglish")}</MenuItem>
<MenuItem value="nb-NO">{t("languageNorwegianBokmal")}</MenuItem>
</TextField>
<Button size="small" variant="contained" disabled={busy || !text.trim()} onClick={() => void run()}>{busy ? t("cvAiWorking") : t("cvAiSuggest")}</Button>
<Button size="small" onClick={() => { setOpen(false); setSuggestion(""); }}>{t("cvAiClose")}</Button>
<Button size="small" disabled={applying} onClick={() => { discard(); setOpen(false); }}>{t("cvAiClose")}</Button>
</Stack>
{suggestion && <>
<Box>
<Typography variant="overline" color="text.secondary">{t("cvAiCurrent")}</Typography>
<Typography variant="body2" sx={{ whiteSpace: "pre-wrap" }}>{text}</Typography>
<Typography variant="body2" sx={{ whiteSpace: "pre-wrap" }}>{proposal?.original ?? text}</Typography>
</Box>
<TextField label={t("cvAiSuggested")} multiline minRows={3} fullWidth size="small" value={suggestion} onChange={(event) => setSuggestion(event.target.value)} />
<TextField label={t("cvAiSuggested")} multiline minRows={3} fullWidth size="small" disabled={busy} value={suggestion} onChange={(event) => setSuggestion(event.target.value)} />
<Alert severity="info" sx={{ py: 0 }}>{t("cvAiCheckFacts")}</Alert>
<Stack direction="row" spacing={1}>
<Button size="small" variant="contained" onClick={() => { onApply(suggestion); setSuggestion(""); setOpen(false); toast(t("cvAiApplied", { section: sectionName }), "success"); }}>{t("cvAiApply")}</Button>
<Button size="small" onClick={() => setSuggestion("")}>{t("cvAiReject")}</Button>
<Button size="small" variant="contained" disabled={busy || !proposal || !suggestion.trim()} onClick={() => void accept()}>{t("cvAiApply")}</Button>
<Button size="small" disabled={applying} onClick={discard}>{t("cvAiReject")}</Button>
</Stack>
</>}
</Stack>