From 3d9341e70f71a3e625f3a2108d366f6644f565d6 Mon Sep 17 00:00:00 2001 From: cesnimda Date: Sat, 10 Oct 2026 22:46:28 +0200 Subject: [PATCH] docs(redesign): prepare conditional Phase 6 design and UX review --- .../phase-5/p5-15/CONTINUATION_PLAN.md | 6 +- docs/redesign/phase-5/p5-15/README.md | 2 + .../phase-5/p5-15/p5-15-06/COMMITS.md | 2 +- docs/redesign/phase-6/README.md | 72 +++++++++++++++++ .../phase-6/evidence/planning-checks.json | 79 +++++++++++++++++++ 5 files changed, 157 insertions(+), 4 deletions(-) create mode 100644 docs/redesign/phase-6/README.md create mode 100644 docs/redesign/phase-6/evidence/planning-checks.json diff --git a/docs/redesign/phase-5/p5-15/CONTINUATION_PLAN.md b/docs/redesign/phase-5/p5-15/CONTINUATION_PLAN.md index 8dc4e14..e9d767a 100644 --- a/docs/redesign/phase-5/p5-15/CONTINUATION_PLAN.md +++ b/docs/redesign/phase-5/p5-15/CONTINUATION_PLAN.md @@ -89,8 +89,8 @@ Files: new `p5-15-06/README.md` and validation evidence; parent acceptance/57-gr Files: `docs/redesign/phase-6/README.md`, using `docs/redesign/IMPLEMENTATION_PLAN.md`. -- [ ] If severe blockers no longer prevent a scoped transition, record accepted baseline, deferred scope, manual/production gaps, design review checkpoints and Phase 7 dependencies. -- [ ] Commit/push preparation, verify remote=HEAD/clean tree/main unchanged; do not begin Phase 7 migration. +- [x] If severe blockers no longer prevent a scoped transition, record accepted baseline, deferred scope, manual/production gaps, design review checkpoints and Phase 7 dependencies. +- [x] Commit/push preparation, verify remote=HEAD/clean tree/main unchanged; do not begin Phase 7 migration. ## Evidence ownership @@ -100,4 +100,4 @@ Completed commits and command results are recorded in each successor report and ## Executed successor -Steps1–6 complete for safe available scope with independently pushed units and [final evidence](p5-15-06/README.md). This checklist marks investigation/reporting completion, not missing operator gates as passed: implemented scope CONDITIONAL GO, original scope NOT COMPLETE, production NO-GO. Human-reader work is postponed/NOT COMPLETE, physical devices and deployed Linux/fonts/recovery evidence unavailable. P5-13 remains deferred/unqualified/withheld. Phase6 preparation is the remaining independent planning unit. +Steps1–7 complete for safe available scope with independently pushed units and [final evidence](p5-15-06/README.md), baseline `9528504866054da10e20d5196e65de536c4c9499`. This checklist marks investigation/reporting completion, not missing operator gates as passed: implemented scope CONDITIONAL GO, original scope NOT COMPLETE, production NO-GO. Human-reader work is postponed/NOT COMPLETE, physical devices and deployed Linux/fonts/recovery evidence unavailable. P5-13 remains deferred/unqualified/withheld. [Phase6 preparation](../../phase-6/README.md) carries all obligations; next execution checkpoint is P6-01 review, not Phase7 migration. diff --git a/docs/redesign/phase-5/p5-15/README.md b/docs/redesign/phase-5/p5-15/README.md index 67782fe..0a56e19 100644 --- a/docs/redesign/phase-5/p5-15/README.md +++ b/docs/redesign/phase-5/p5-15/README.md @@ -6,6 +6,8 @@ The owner's latest instruction authorises continuous bounded repairs and indepen **Implemented scope: CONDITIONAL GO for Phase 6 review planning. Full originally planned Phase 5: NOT COMPLETE. Production: NO-GO.** Fresh312axe scans retain39all-enabled violation-node occurrences and2,367incomplete occurrences; automated success is not full accessibility acceptance. [Targeted debt disposition](p5-15-04/DEBT_DISPOSITION.md) retains contextual rule warnings, historical preference500 causes, the CV Unsaved incident and O(N) Board capacity. Twelve concurrent preference rounds and exact200/1,000-job Board membership pass locally without closing those production/manual obligations. [Commit ledger](p5-15-06/COMMITS.md) records independently pushed units; no production action follows. +[Phase6 review planning](../../phase-6/README.md) now uses final acceptance baseline `9528504866054da10e20d5196e65de536c4c9499`, retaining conditional implemented scope, original scope NOT COMPLETE and production NO-GO. Next review checkpoint: P6-01. No Phase7 migration or P5-13 activation begins. + The 57-group matrix now records **0 PASS / 56 PARTIAL / 0 FAIL / 1 DEFERRED =57**. Whole-group acceptance remains incomplete. Postponed human screen-reader acceptance is **NOT COMPLETE / NOT VERIFIED**; physical devices/software keyboards, incomplete axe triage and deployed font/portrait qualification remain open. P5-13 remains deferred/unqualified/Production-withheld, 0/366 calls, no human semantic review or review UI. P5-05 and followMode reviewed compose remain explicitly deferred. [Production assessment](p5-15-05/README.md): **NO-GO**, main unchanged. F04, current complete backup/isolated restore, deployed configuration/schema/secrets, rollback and smoke/monitoring evidence are still required. Phase 6 planning does not waive them or declare the original full Phase 5 scope complete. diff --git a/docs/redesign/phase-5/p5-15/p5-15-06/COMMITS.md b/docs/redesign/phase-5/p5-15/p5-15-06/COMMITS.md index e5f0f9a..2b4c9dc 100644 --- a/docs/redesign/phase-5/p5-15/p5-15-06/COMMITS.md +++ b/docs/redesign/phase-5/p5-15/p5-15-06/COMMITS.md @@ -23,4 +23,4 @@ Development branch `codex/ui-redesign-phase4`; no force pushes. Each completed u | `eba7ad19c6f60d08528ae357db33a56e6fe05f9c` | docs(acceptance): record final native export and photo readback | | `227e3b4a22a17d92ce59f74e69001df292e379fd` | test(acceptance): qualify preference concurrency and Board membership | -The P5-15-06 evidence commit is created/pushed after this ledger; its actual hash is recorded in the Phase6 handoff and final response, avoiding a self-referential fabricated hash. The subsequent Phase6 planning commit is also reported after creation. Focused before/after evidence is in each repair record; full post-change commands/times/hashes and limits are in evidence/validation.json. No production CI/deployed smoke, human acceptance or configured-model qualification is claimed. +Final P5-15-06 evidence commit: **`9528504866054da10e20d5196e65de536c4c9499`**, pushed with remote=HEAD and clean tree; main unchanged. The [Phase6 planning](../../../phase-6/README.md) commit is reported after creation rather than inventing its own self-referential hash. Focused before/after evidence is in each repair record; full post-change commands/times/hashes and limits are in evidence/validation.json. No production CI/deployed smoke, human acceptance or configured-model qualification is claimed. diff --git a/docs/redesign/phase-6/README.md b/docs/redesign/phase-6/README.md new file mode 100644 index 0000000..2351485 --- /dev/null +++ b/docs/redesign/phase-6/README.md @@ -0,0 +1,72 @@ +# Phase 6 — Design and UX Review + +**Review-planning readiness: CONDITIONAL GO.** Phase 5's implemented local scope can enter bounded design/UX review; the originally planned full scope is NOT COMPLETE and production release remains NO-GO. This is the transition/planning checkpoint, not Phase 7 migration or a release authorization. + +## Verified handoff + +Phase 5 final acceptance baseline: **`9528504866054da10e20d5196e65de536c4c9499`**, development `codex/ui-redesign-phase4`, committed/pushed with remote=HEAD and a clean tree. Final application change: `22455bba0a016f0cefabde46c539df588f789667`. Production local/remote `main` remains **`27657f31131cd95d42f0e1290853ec9c9b3959a4`**; a main push triggers deployment and is prohibited while NO-GO. + +Authority: [original Implementation Plan](../IMPLEMENTATION_PLAN.md), [Phase 5 plan](../phase-5/PHASE5_PLAN.md), [final acceptance](../phase-5/p5-15/p5-15-06/README.md), [57 original-group reconciliation](../phase-5/p5-15/PRESERVATION_ACCEPTANCE.md), [32 routes](../phase-5/p5-15/ROUTE_ACCEPTANCE.md), [pushed-unit ledger](../phase-5/p5-15/p5-15-06/COMMITS.md), [remaining findings](../phase-5/p5-15/p5-15-04/DEBT_DISPOSITION.md) and [production gate](../phase-5/p5-15/p5-15-05/README.md). Historical failures and incomplete acceptance are retained. + +| Inherited fresh gate | Result | +|---|---| +| Backend / frontend / ordinary browser | 1,033 / 498 / 148 passing | +| Separate diagnostics / sidecar / focused AI / real HTTP | 3 / 49 / 108 / 2 passing | +| Revision safety | 5/5 | +| Standard fidelity | 16/16, 36 preview=36 PDF pages | +| Settings exports | 8/8, 24 preview=24 PDF pages | +| Rate-limit / ingress / PDF admission / configuration | 9 / 6 / 1 / 3 passing | +| TypeScript / lint / builds / secrets / links / whitespace | Passing; exact native commands/times/fingerprints in final manifest | +| PRES / routes | 0PASS / 56PARTIAL / 0FAIL / 1DEFERRED =57; all32 route patterns remain PARTIAL for full acceptance | + +Counts are separate lanes/subsets, not summed into a fictional total. Final ordinary/native runs have zero skips, expected failures, flaky results or retries. P2-D01 is ordinary passing. This planning-only change does not claim another full runtime run; document/link/secret/whitespace validation is performed for the handoff. + +## Accepted implementation boundary + +Shell/navigation and utilities, Jobs Table/Board, Dashboard/Analytics, Job header/Overview/deeper sections, CV frame/navigation, section editing/source clarity, preview chrome, template/document controls and scoped responsive CV workflow have representative implemented/native evidence. All original routes/capabilities remain; later visual migration is not represented as a removed workflow. + +Five new audit barriers were repaired independently: keyboard-native file selection, hidden-initial preview measurement, drawer focus/return, CV-to-Career navigation and report target sizes. Two P1s and three P2s are no longer demonstrated failures on their tested paths. No PDF geometry, API status, ownership, source/override/history, submitted package or provider semantics were changed for appearance. + +The transition is conditional because whole-workflow/human/device/deployed acceptance is incomplete. It authorizes review planning and finite inspection of implemented scope, not certification of every capability. A newly demonstrated critical security/data or severe accessibility failure requires containment and a separate bounded repair before dependent work; it must not be dismissed as design preference. + +## Deferred scope and unresolved acceptance + +- **P5-13 remains DEFERRED / UNQUALIFIED / Production-withheld.** Actual deployed model/runtime identity, reachable inference, unchanged366 calls, independent human semantic review, AI review UI and final integration remain outstanding. Zero configured-target calls/zero human reviews; frozen corpus and deterministic authoritative grounding/stale/tenant guards retained. Production service registration remains withheld; no automatic activation. Existing unrelated AI is retained. +- Production hardware is owner-reported Ubuntu24.04/GTX1060 6GB/32GB RAM, distinct from Windows/RTX3080 development. `qwen3.5:4b-q4_K_M` is only a candidate. No actual driver/runtime/offload/throughput qualification or Docker recovery was performed. Separate approved feasibility/qualification work must precede target selection and activation. +- **Human reader acceptance: NOT COMPLETE / NOT VERIFIED.** Owner postponed available-operator work; no actual reader/version/device/spoken results supplied. Physical touch, native dragging, software keyboard and mobile AT also remain unverified. [M01–M13 operator packet](../phase-5/p5-15/p5-15-02/MANUAL_ACCEPTANCE.md) remains mandatory. +- Fresh312axe scans retain39all-enabled violation-node occurrences and2,367incomplete occurrences. Contrast/meaningful initials, heading/landmark structure, drawer AX names, panel associations and broader reflow require contextual disposition; no zero-violation compliance claim. Actual Chromium100/200/400 zoom and emulator input are finite evidence only. +- Production Linux font/portrait/asset qualification remains open despite passing local16/8 corpora and four tiny synthetic photo exports. Do not widen tolerances or infer production metric equivalence. +- Historical preference500/notification contention causes remain open: twelve native concurrent rounds pass but do not diagnose the old exceptions or clear swallowed language-save errors. CV Unsaved incident remains open; the800ms test boundary is qualified, historical trace absent. Other readiness rows retain their own status/owner. +- Board200/1,000 exact membership passes locally (render1,040/1,612ms), but O(N) full-array capacity and physical dragging remain unqualified. No supported-load/memory/latency budget exists yet. +- P5-05 quick preview and `followMode` reviewed compose UI remain explicitly deferred; full Job entry and compatibility query/state round-trip retained. No fake AI/compose/preview screen is included in acceptance. +- F04, current complete backup/isolated restore, actual configuration/schema/secrets, rollback and deployed smoke/monitoring remain release blockers. No production network/service/data change was performed. Prepared operator commands are not verification. + +The [complete readiness register](../phase-5/p5-15/READINESS_DEBT.md) retains other provider, domain concurrency, company-dialog error, worker, deletion/billing and cutover obligations. Phase 6 does not erase them or start B07. + +## Objectives and reusable foundations + +Use the original Phase 6 scope: consistency, usability, information density, light/dark quality, responsive behavior, Norwegian localisation, existing AI patterns, component reuse and performance before broad rollout. Review actual implemented workflows and representative empty/loading/error/conflict states, not idealized screenshots. + +Reuse [Phase 4 foundations](../phase-4/README.md): semantic theme/focus/status colors, typography/spacing, named modal controls, deliberate preview entry/exit, PageLayout/section primitives and Comfortable/Compact table density. Existing MUI controls, shell, Jobs query state, Job workspace sections and CV chrome are the starting point. Add no second saving/undo/navigation/renderer system and no new framework for stylistic preference. + +The rendered document is a separate physical contract from application chrome. Any review-driven change touching CV preview/template/layout must keep both unchanged fidelity suites and revision/override/frozen-package evidence green; ordinary UI reflow must not alter printed geometry. + +## Proposed bounded checkpoints + +| Checkpoint | Scope and entry | Required evidence / exit | Dependencies / push boundary | +|---|---|---|---| +| **P6-00 — Handoff and review programme** | This record; verified final Phase5 baseline and scope rulings | Accurate baseline, complete deferred/manual/release obligations and review order | Planning-only documentation commit/push; no release/migration | +| **P6-01 — System consistency and workflow review** | Next execution checkpoint: implemented shell, Jobs, Dashboard/Analytics, Job and CV surfaces | Representative route/state/locale/theme comparison; hierarchy/density/control/action consistency, duplicate/dead affordances; prioritized findings tied to PRES and existing tokens | Review first; any correction gets reproduction, focused regression and independent small commit/push. No broad redesign | +| **P6-02 — Usability and information density** | P6-01 findings and existing product capabilities | Complete task journeys, progressive disclosure, navigation/orientation, long-data and source-scope clarity; no feature removal or persistence change | Product/design owner; record actual user/manual evidence separately from agent review | +| **P6-03 — Locale/theme/accessibility closure** | Fresh triage and M01–M13 packet | EN/Bokmål labels, meaningful contrast, settled drawer names, headings/panels, enabled-action reflow; real reader/device/software-keyboard outcomes before complete acceptance | Qualified human/device operators; unavailable checks stay NOT VERIFIED. Bounded severe-barrier fixes before dependent rollout | +| **P6-04 — Reuse, capacity and rendering environment** | Existing components, finite Board and16/8 rendering baselines | Agreed performance/account/device envelope, measured CPU/memory/query/render cost; production-equivalent font/portrait tests; avoid duplicate components | Platform/CV/operator. Any virtualization/renderer change needs its own compatible design and membership/fidelity regressions; no speculative migration | +| **P6-05 — Existing AI interaction review** | Currently approved/operational AI only | Scope/provenance/review/failure conventions and minimum-context privacy; retain account/provider/Production-withholding guards | Deferred P5-13 is visibly excluded, not completed. No model calls, invented UI or activation from a consistency review | +| **P6-06 — Review acceptance and Phase7 handoff** | Prior findings/remediation and required evidence reconciled | Fresh affected/full regressions,57groups/32routes, three separate scope/full/production decisions, unresolved work and migration order | Phase7 starts only after a separate reviewed handoff; production GO is an independent operator/release decision | + +Manual/operator work may run alongside independent review; unavailable evidence does not repeatedly halt unrelated inspection. It cannot be impersonated by an agent or silently converted into PASS. Preserve independently reviewable commits and immediate remote synchronization; never force-push or touch main without a separately verified authorized release decision. + +## What Phase 7 inherits + +Phase7 will inherit the verified representative design language, original preservation/route inventory, compatible shared foundations, measured document renderer, test fixtures and unresolved gates. The original full-migration list still includes remaining authentication/onboarding/Career/library/Documents/application/mail/Notifications/Settings/Admin/error/dialog states. Already migrated representative Analytics/Settings portions are retained; remaining coverage must be reconciled explicitly rather than rebuilt or assumed complete. + +Before that migration: resolve system-level findings with bounded proof, complete required reader/device/rendering acceptance or keep accurately scoped conditional decisions, and retain all production prerequisites. No Phase7 implementation, B07, P5-13 return work or deployment begins in this planning checkpoint. diff --git a/docs/redesign/phase-6/evidence/planning-checks.json b/docs/redesign/phase-6/evidence/planning-checks.json new file mode 100644 index 0000000..31390e1 --- /dev/null +++ b/docs/redesign/phase-6/evidence/planning-checks.json @@ -0,0 +1,79 @@ +{ + "baseline": "9528504866054da10e20d5196e65de536c4c9499", + "checks": [ + { + "name": "documents", + "command": [ + "rtk", + "proxy", + "python", + "-X", + "utf8", + ".artifacts/p5-completion/check-documents.py" + ], + "startedUtc": "2026-10-10T20:46:23.912954+00:00", + "finishedUtc": "2026-10-10T20:46:24.334367+00:00", + "exitCode": 0, + "outputSha256": "cf402898ffb9056bd8290c2eb01aa69402e732db396c336546955f7cfa2627c7" + }, + { + "name": "secret-scan", + "command": [ + "rtk", + "proxy", + "python", + "-X", + "utf8", + "scripts/supply-chain.py", + "scan-secrets" + ], + "startedUtc": "2026-10-10T20:46:24.334367+00:00", + "finishedUtc": "2026-10-10T20:46:26.385108+00:00", + "exitCode": 0, + "outputSha256": "c5a88d5ebdc042adba125c1eaacbe44f9f4a5c19898c0f195573c00d511aa28d" + }, + { + "name": "working-whitespace", + "command": [ + "rtk", + "proxy", + "git", + "diff", + "--check" + ], + "startedUtc": "2026-10-10T20:46:26.385108+00:00", + "finishedUtc": "2026-10-10T20:46:26.463582+00:00", + "exitCode": 0, + "outputSha256": "d2993bc68ad9a63f711c8f5473155e2ba00fdcd461220cc3849185f2f9ad93e6" + }, + { + "name": "staged-whitespace", + "command": [ + "rtk", + "proxy", + "git", + "diff", + "--cached", + "--check" + ], + "startedUtc": "2026-10-10T20:46:26.463582+00:00", + "finishedUtc": "2026-10-10T20:46:26.543647+00:00", + "exitCode": 0, + "outputSha256": "d2993bc68ad9a63f711c8f5473155e2ba00fdcd461220cc3849185f2f9ad93e6" + } + ], + "documents": { + "checkedUtc": "2026-10-10T20:46:24.315196+00:00", + "documents": 20, + "relativeLinks": 1262, + "preservationGroups": 57, + "statuses": { + "PARTIAL": 56, + "DEFERRED": 1 + }, + "routePatterns": 32, + "errors": [] + }, + "runtime": "Inherited from the fresh final Phase5 manifest; no new runtime-suite claim for this planning-only change", + "manual": "NOT COMPLETE; owner-postponed screen-reader and unavailable physical-device/deployed gates retained" +}