fix(deploy): load production environment before backup
deploy.sh symlinked /opt/job-tracker/shared/.env for docker compose but never loaded it into its own shell. Its own decisions therefore ran against an empty environment: DATABASE_PROVIDER fell back to sqlite on a MariaDB host, so the deploy tarred the data volume, printed "Backup verified" and continued with no database dump. The operator saw a green backup line and a new file in the backups directory, and had no restore point. Load the shared env before any decision. Parsed line by line rather than sourced, because a compose .env is not a shell script and an unquoted value containing spaces would execute as a command. Values already in the environment win, so CI-provided APP_VERSION and friends still override the file. No value is echoed. Remove the sqlite default. DATABASE_PROVIDER must be stated; missing or unrecognised aborts the deploy. Validate deployment configuration before the backup, and so before anything is built, stopped or replaced: the connection string when the provider needs one, AI_SERVICE_TOKEN (compose declares it with :?) and AUTH_JWT_KEY (the backend throws on a blank key). Names in the output, never values. Verify each backup against its own format. A dump must be valid gzip, contain CREATE TABLE, and carry the "Dump completed" trailer, so a dump that died partway through is rejected. An archive must contain jobtracker.db. A tar can no longer pass the dump check. Also resolve the SQLite volume by its project-prefixed name and fail if absent. The bare jobtracker_data name would have silently created an empty volume and backed that up -- the same class of bug, found while testing this fix. Verified against a seeded MariaDB 11 container and real Docker volumes: provider selection, all four validation failures, both backup formats and their failure paths, truncated and trailer-stripped dumps, and zero secret occurrences across every test's output. Docs updated for the drift: deploy/README.md, deploy/first-production- deployment.md, docs/release-candidate-review.md (B1 closed) and .env.example, which now names the two database variables. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -1,6 +1,18 @@
|
||||
# Copy this file to `.env` (same folder as docker-compose.yml) and fill in values.
|
||||
#
|
||||
# Used by docker-compose.yml
|
||||
#
|
||||
# Database. deploy/deploy.sh REQUIRES DATABASE_PROVIDER to be set explicitly and
|
||||
# refuses to deploy without it — it selects which backup to take, and guessing it
|
||||
# wrong means backing up the wrong database. Use `mariadb` (or `mysql`) for a
|
||||
# server deployment, `sqlite` for a single-file local one.
|
||||
DATABASE_PROVIDER=sqlite
|
||||
# Required when DATABASE_PROVIDER is mariadb/mysql. Ignored for sqlite, which
|
||||
# stores its file in the jobtracker_data volume.
|
||||
# The host resolves from INSIDE the backend container: 127.0.0.1 means the
|
||||
# container, not the Docker host.
|
||||
JOBTRACKER_CONNECTION_STRING=
|
||||
|
||||
AUTH_JWT_KEY=CHANGE_ME_LONG_RANDOM_SECRET
|
||||
AUTH_ADMIN_EMAIL=admin@example.com
|
||||
AUTH_ADMIN_PASSWORD=CHANGE_ME_STRONG_PASSWORD
|
||||
|
||||
Reference in New Issue
Block a user