feat(S04/T02): Made the job table show actionable follow-up/package nex…
- job-tracker-ui/src/components/JobTable.tsx - job-tracker-ui/src/daily-control-loop.test.tsx - job-tracker-ui/src/i18n/translations.ts - .gsd/milestones/M001/slices/S04/S04-PLAN.md - .gsd/milestones/M001/slices/S04/tasks/T02-PLAN.md
This commit is contained in:
@@ -42,3 +42,9 @@ Strengthen the job table so the first daily view shows what action is actually d
|
||||
|
||||
- `job-tracker-ui/src/components/JobTable.tsx` — clearer next-action affordances.
|
||||
- `job-tracker-ui/src/daily-control-loop.test.tsx` — proof that the table participates in the routed daily loop.
|
||||
|
||||
## Observability Impact
|
||||
|
||||
- Signals changed: the table's urgency chips and primary row actions should now expose the same routed follow-up and package-work intents already used by dashboard and reminders.
|
||||
- How to inspect later: read `job-tracker-ui/src/components/JobTable.tsx` for the shared workspace-route usage and run `CI=true npm --prefix job-tracker-ui test -- --watch=false --runTestsByPath src/daily-control-loop.test.tsx` to confirm table, reminders, and dashboard all land in the expected workspace state.
|
||||
- Failure state made visible: if table actions drift from the shared routing contract, the focused UI test should fail with the wrong route/tab content instead of silently leaving decorative chips in place.
|
||||
|
||||
@@ -1,23 +1,89 @@
|
||||
---
|
||||
title: T02 summary
|
||||
status: done
|
||||
files:
|
||||
id: T02
|
||||
parent: S04
|
||||
milestone: M001
|
||||
provides:
|
||||
- Makes job-table urgency signals actionable and keeps table, reminders, and dashboard on the same routed job-workspace loop.
|
||||
key_files:
|
||||
- job-tracker-ui/src/components/JobTable.tsx
|
||||
- job-tracker-ui/src/daily-control-loop.test.tsx
|
||||
verification:
|
||||
- CI=true npm --prefix job-tracker-ui test -- --watch=false --runTestsByPath src/daily-control-loop.test.tsx
|
||||
- CI=true npm --prefix job-tracker-ui run build
|
||||
- job-tracker-ui/src/i18n/translations.ts
|
||||
- .gsd/milestones/M001/slices/S04/S04-PLAN.md
|
||||
- .gsd/milestones/M001/slices/S04/tasks/T02-PLAN.md
|
||||
key_decisions:
|
||||
- Derived table chips and primary row actions from one shared action-signal model so table urgency and routed next-action behavior cannot drift.
|
||||
patterns_established:
|
||||
- Use the shared `/jobs?open=...&tab=...&followMode=...` workspace route from overview surfaces and prove each surface with focused UI/browser checks.
|
||||
observability_surfaces:
|
||||
- job-tracker-ui/src/components/JobTable.tsx
|
||||
- job-tracker-ui/src/daily-control-loop.test.tsx
|
||||
- Browser UAT on the built app served locally with mocked API routes at http://localhost:4173
|
||||
- .gsd/milestones/M001/slices/S04/S04-PLAN.md verification/failure-path notes
|
||||
duration: ~2h
|
||||
verification_result: passed
|
||||
completed_at: 2026-03-24T13:55:43+01:00
|
||||
blocker_discovered: false
|
||||
---
|
||||
|
||||
Made the job table expose the next action directly and prove the daily loop end-to-end.
|
||||
# T02: Make the job table expose the right next action and prove the daily loop
|
||||
|
||||
What changed:
|
||||
- `job-tracker-ui/src/components/JobTable.tsx`
|
||||
- follow-up and CV status chips now route directly into the right job workspace tab
|
||||
- the table participates in the same routed workspace flow as dashboard and reminders
|
||||
- `job-tracker-ui/src/daily-control-loop.test.tsx`
|
||||
- expanded the focused test to prove the table chip routes into the follow-up workspace and that reminders can route into the tailored-CV workspace
|
||||
**Made the job table show actionable follow-up/package next steps and proved table, reminders, and dashboard all land in the same job workspace flow.**
|
||||
|
||||
Verification:
|
||||
- Focused daily-loop test passed
|
||||
- Frontend build passed
|
||||
## What Happened
|
||||
|
||||
I first fixed the flagged observability gaps in the slice and task plans so this unit explicitly described its failure-path coverage and inspection surfaces.
|
||||
|
||||
In `job-tracker-ui/src/components/JobTable.tsx`, I replaced the split decorative/action logic with a shared action-signal model. The table now derives both row chips and the primary “Next action” control from the same follow-up/package readiness signals, so the visible urgency affordance and the routed action cannot drift apart. Package work now reflects the same readiness inputs already used by the table filters: missing tailored CV, missing notes, or both.
|
||||
|
||||
I updated translations in `job-tracker-ui/src/i18n/translations.ts` so the new package-work affordances and details are user-facing copy instead of hardcoded strings.
|
||||
|
||||
In `job-tracker-ui/src/daily-control-loop.test.tsx`, I expanded the focused daily-loop proof so the table explicitly participates in the routed loop: the test now clicks a table urgency signal for follow-up work and the table’s next-action button for package work, while the earlier reminders/dashboard proofs remain in place.
|
||||
|
||||
For runtime verification, I also exercised the built app in a browser. Because `dotnet` is unavailable in this environment, I served the compiled UI locally and mocked the frontend’s own API contract in-browser, then verified that table, reminders, and dashboard each opened the expected job workspace state.
|
||||
|
||||
## Verification
|
||||
|
||||
Verified the focused UI test passes, the frontend production build succeeds, and browser UAT confirms the routed daily loop across all three surfaces.
|
||||
|
||||
- Focused test: `CI=true npm --prefix job-tracker-ui test -- --watch=false --runTestsByPath src/daily-control-loop.test.tsx`
|
||||
- Build: `CI=true npm --prefix job-tracker-ui run build`
|
||||
- Browser UAT on built app (`npx serve -s job-tracker-ui/build -l 4173`) with mocked API contract:
|
||||
- `/jobs`: clicked table next action for Backend Developer and confirmed Follow-up context + saved cover-letter reuse signal
|
||||
- `/reminders`: clicked Missing tailored CV → Open and confirmed Tailored CV workspace for Platform Engineer
|
||||
- `/dashboard`: clicked Follow up card action and confirmed routed follow-up workspace
|
||||
- Network errors were cleared after route mocking; the verified browser interactions completed without failed mocked requests
|
||||
|
||||
## Verification Evidence
|
||||
|
||||
| # | Command | Exit Code | Verdict | Duration |
|
||||
|---|---------|-----------|---------|----------|
|
||||
| 1 | `CI=true npm --prefix job-tracker-ui test -- --watch=false --runTestsByPath src/daily-control-loop.test.tsx` | 0 | ✅ pass | 4.723s |
|
||||
| 2 | `CI=true npm --prefix job-tracker-ui run build` | 0 | ✅ pass | 12.969s |
|
||||
| 3 | Browser UAT on `http://localhost:4173` with mocked `http://localhost:5202/api/*` routes: table → follow-up workspace, reminders → tailored CV workspace, dashboard → follow-up workspace | 0 | ✅ pass | ~4m |
|
||||
|
||||
## Diagnostics
|
||||
|
||||
Inspect `job-tracker-ui/src/components/JobTable.tsx` to see the shared action-signal derivation that drives both urgency chips and primary next-action buttons.
|
||||
|
||||
Run `CI=true npm --prefix job-tracker-ui test -- --watch=false --runTestsByPath src/daily-control-loop.test.tsx` to catch drift between table, reminders, dashboard, and the routed workspace state.
|
||||
|
||||
For browser-level inspection, serve the built UI and verify these surfaces route into `/jobs` with the expected workspace content:
|
||||
- table signal / next-action controls
|
||||
- reminders Open actions
|
||||
- dashboard Needs Follow-up actions
|
||||
|
||||
## Deviations
|
||||
|
||||
Used browser-level API route mocks for manual UAT because the local ASP.NET API could not be started in this environment (`dotnet` is not installed). The shipped UI code was still exercised in a real browser against its own HTTP contract.
|
||||
|
||||
## Known Issues
|
||||
|
||||
The focused Jest run still emits existing React Router v7 future-flag warnings from the test harness. They do not fail the task’s verification gate and were not introduced by this change.
|
||||
|
||||
## Files Created/Modified
|
||||
|
||||
- `job-tracker-ui/src/components/JobTable.tsx` — unified actionable urgency chips and primary next-action routing for follow-up and package work
|
||||
- `job-tracker-ui/src/daily-control-loop.test.tsx` — extended the focused loop test to prove the table participates in the same routed workspace flow
|
||||
- `job-tracker-ui/src/i18n/translations.ts` — added user-facing copy for package-work affordances and details
|
||||
- `.gsd/milestones/M001/slices/S04/S04-PLAN.md` — added explicit slice-level failure-path verification guidance
|
||||
- `.gsd/milestones/M001/slices/S04/tasks/T02-PLAN.md` — added the missing Observability Impact section
|
||||
|
||||
Reference in New Issue
Block a user