cesnimda/jobtrackingapp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(cv): bind letter proposals to current sources and preserve document choices

Browse Source
This commit is contained in:
cesnimda
2026-10-26 03:44:37 +01:00
parent 8948c988e2
commit 8979244576
21 changed files with 816 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
JobTrackerApi.Tests/CoverLetterDocumentContractTests.cs
+23
View File
@@ -1,11 +1,34 @@
using JobTrackerApi.Models;
using JobTrackerApi.Services;
using System.Text.Json;
using Xunit;
namespace JobTrackerApi.Tests;
public sealed class CoverLetterDocumentContractTests
{
[Theory]
[InlineData(null, "en")]
[InlineData("{}", "en")]
[InlineData("{\"senderName\":\"Legacy sender\"}", "en")]
[InlineData("{\"language\":\"en\"}", "en")]
[InlineData("{\"language\":\"nb\"}", "nb-NO")]
[InlineData("{\"language\":\"nb-NO\"}", "nb-NO")]
[InlineData("{\"language\":\" NB-no \"}", "nb-NO")]
[InlineData("{\"language\":null}", "en")]
[InlineData("{\"language\":\"fr\"}", "en")]
[InlineData("{\"language\":\"en\\\" onload=alert(1)\"}", "en")]
public void Document_language_defaults_normalizes_and_roundtrips_only_supported_values(string? json, string expected)
{
var settings = CoverLetterDocumentSettingsJson.Deserialize(json);
var normalized = CoverLetterDocumentSettingsJson.Serialize(settings);
Assert.Equal(expected, JsonDocument.Parse(normalized).RootElement.GetProperty("language").GetString());
Assert.Equal(normalized, CoverLetterDocumentSettingsJson.Serialize(CoverLetterDocumentSettingsJson.Deserialize(normalized)));
var html = new CoverLetterDocumentRenderer().Render("Reviewed letter — æøå", settings).Html;
Assert.Contains($"<html lang=\"{expected}\">", html);
Assert.DoesNotContain("onload=", html);
}
[Fact]
public void Document_style_reuses_cv_allowlists_clamps_non_finite_values_and_escapes_all_metadata()
{