fix: harden admin system fallback and benchmark review

2026-04-01 13:38:22 +02:00
parent cc55fc0cf8
commit 9191e4cc5b
4 changed files with 264 additions and 7 deletions
@@ -133,6 +133,35 @@ public sealed class AuthAndSystemControllerTests
        Assert.Equal("person@example.com", result.GoogleLink.Email);
    }

+    [Fact]
+    public async Task Admin_system_email_settings_falls_back_when_override_store_is_unavailable()
+    {
+        var emailSettings = new Mock<IEmailSettingsResolver>();
+        emailSettings.Setup(x => x.GetAdminDtoAsync(It.IsAny<CancellationToken>())).ThrowsAsync(new InvalidOperationException("missing SystemEmailSettings"));
+
+        var cfg = new ConfigurationBuilder()
+            .AddInMemoryCollection(new Dictionary<string, string?>
+            {
+                ["Email:Enabled"] = "false",
+                ["Email:FromName"] = "Jobbjakt"
+            })
+            .Build();
+
+        var controller = new AdminSystemController(
+            cfg,
+            new AppPaths(cfg, new FakeHostEnv()),
+            null!,
+            Mock.Of<ISummarizerService>(),
+            new FakeEnv(),
+            emailSettings.Object);
+
+        var result = await controller.GetEmailSettings(CancellationToken.None);
+        var ok = Assert.IsType<OkObjectResult>(result.Result);
+        var dto = Assert.IsType<EmailSettingsAdminDto>(ok.Value);
+        Assert.False(dto.Enabled);
+        Assert.Contains("fallback", dto.FromName, StringComparison.OrdinalIgnoreCase);
+    }
+
    [Fact]
    public async Task Admin_system_probe_endpoint_runs_probe_once()
    {