docs(phase10): record publication and retained compatibility reviews

2026-11-02 21:45:56 +01:00
parent 78f7396adb
commit 927f909b0d
4 changed files with 27 additions and 0 deletions
@@ -2,6 +2,8 @@

 ## Latest checkpoint — CLEAN-20 explicitly approved and verified

+**Published and independently verified:** `78f7396adb2f1d3452c10e60bc0dbbd3a4a602e4` on `origin/feature/phase10-cleanup`; normal push exit 0 and subsequent ls-remote exact match. Graphify AST update completed locally (18,532 nodes / 46,020 edges); generated graph remains untracked. P10-02 and P10-03 now record bounded compatibility/backend retain dispositions, with no further removal candidate proven. P10-04/05 and independent audit are still incomplete.
+
 Owner replied **"Approve CLEAN-20 only"** in this chat. This supersedes historical approval-pending statements below, without authorising any other deletion. [P10-01](P10-01.md) records the exact one-file removal, fresh typecheck/lint/build and 5/5 browser results, preserved 34 routes/57 groups, and 1,279 unchanged source files. Publication receipt follows in the next checkpoint. No final Phase 10 or production acceptance implied. Resume with this latest section, not the superseded controller/publication history below.

 2 November 2026. Worktree: `C:\Users\Connor\.codex\worktrees\p10-assessment\Job tracker`. Branch: `feature/phase10-cleanup`. Initial HEAD: `fc5b9d377199ce51f480a920a3772108094929e3`; reported handoff `5cb903b989742b7a96cb22ddf4c0e24993b18980` is an ancestor and matched its original branch's live remote readback. Frozen application source remains `ba04d817fed26d659bfa2a56b089d6cac851dc34`.
@@ -0,0 +1,12 @@
+# P10-02 — CV/document compatibility disposition
+
+Review after published CLEAN-20. No additional safe CV/document deletion proven. Retain all assessed paths; no implementation removal nominated. This is a completed bounded retain/remove review, not fresh functional acceptance or a claim of exhaustive dead-code proof.
+
+Reused the source-bound P10-00 inventory and accepted handoff: all 1,279 remaining frozen files match; only approved App.css is absent. Fresh active-consumer confirmation:
+
+- `CareerProfilePage.tsx:410,447,868` distinguishes non-Docling and Docling persisted runs and calls the legacy accept endpoint with expected revision. `ProfileCvController.cs:270–314` exposes that endpoint, rejects inappropriate document-import acceptance, checks revisions and preserves concurrency conflicts. **Retain both workflows.**
+- `CvTheme.cs:199` and `ThemedCvRenderer.cs:27,242–282` resolve explicit design-version-2 settings while retaining historical layout branches. **Retain legacy rendering and frozen settings.**
+- `ApplicationAssetsService` remains the revision/history writer, with current version snapshots and design entitlement validation. Existing null/blank/no-op/restore semantics and canonical Career Profile ownership are unchanged. **Retain, no writer consolidation.**
+- Current editor/gallery/thumbnail and original fixtures retain their P10-00 positive consumers. No duplicate replacement proven; no imported data, old extraction record or submitted binary removed.
+
+Tests: no new P10-02 product tests; sources unchanged and historical CV/provider/PDF/RD21 evidence reused only within original qualifications. CLEAN-20 Career Workspace sample is fresh but not historical-format/PDF requalification. P10-04/05 and independent audit remain required. No migration or PDF rendering requested. Deferred CV-import overhaul stays outside scope.
@@ -0,0 +1,11 @@
+# P10-03 — Backend, dependency and configuration disposition
+
+Bounded review complete with **no proven additional safe deletion**. Reuse P10-00 CLEAN-11–19 active-consumer inventory; source comparison confirms backend, dependencies, locks, scripts and configuration are unchanged. Do not manufacture a removal to satisfy a stage name. Implementation scope is empty; full independent audit and P10-04/05 acceptance remain open.
+
+- Keep canonical mapper, versioned writers, legacy parser and disabled optional interpretation adapter: different responsibilities/current readers persist. Disabled is not obsolete.
+- Keep migration history and both database providers. Reviewed `SQLITE_RETIREMENT.md` again: installation inventory, full-fidelity export/restore, transfer reconciliation, coverage parity, approved cutover/reverse transfer and retention sign-off are not established. Existing SQLite browser fixture is itself a current consumer. SQLite removal remains separately gated and does not block unrelated cleanup.
+- Current project embeds licensed document fonts and declares runtime/platform/provider packages. No package has a complete runtime/build/test/script/container/platform absence proof. No upgrades, lock changes, flag activation or platform consolidation performed.
+- Keep current routes/redirects, locale keys, original tests and frozen PDF oracles. Dynamic consumers and historical compatibility defeat name/age-based deletion.
+- Duplicate reminder-read optimisation is still unmeasured and therefore not nominated for cleanup.
+
+Fresh supporting check from P10-01: locked API restore/Release build and frontend offline restore/typecheck/lint/build passed. These prove builds for retained inputs, not unused-package absence or fresh security/provider qualification. Backup-parser remediation lives on its independent release branch; it is not silently integrated into this Phase 10 branch.