fix(a11y): make confirmation messages keyboard scrollable
This commit is contained in:
@@ -0,0 +1,9 @@
|
|||||||
|
# Confirmation keyboard scrolling — 20 October 2026
|
||||||
|
|
||||||
|
The Linux compose journey found a serious `scrollable-region-focusable` violation in the shared confirmation dialog at a short landscape viewport. Its message body can overflow independently while containing no focusable content. The shared owner is `ConfirmProvider`, also used by attachment deletion, application workspace changes, CV template changes and Career evidence deletion.
|
||||||
|
|
||||||
|
The body now exposes a keyboard-focusable region named by the existing localized dialog title. Cancel retains initial focus; confirmation, dismissal, focus restoration and Promise resolution are unchanged. No new strings, dialog framework or saving semantics are introduced.
|
||||||
|
|
||||||
|
The strengthened existing unit case failed ordinarily before the implementation (one failure, one pass). Afterward all eight cases in the confirmation, confirmation-flow, dialog-flow and modal-state suites passed. The full ten-case native compose suite passed without retries/skips/flaky outcomes at 07:28:17–07:29:43 UTC against a fresh production export. This includes the eight-width bilingual theme/keyboard journey and its unchanged all-enabled axe assertion. Build passed. No test inventory change, accessibility waiver or production authorization change is made.
|
||||||
|
|
||||||
|
Human screen-reader and physical-device acceptance remain pending. This narrow correction does not accept the remaining Phase 7 migration or establish live deployment success.
|
||||||
@@ -31,6 +31,10 @@ test('renders app-owned confirmation dialog', async () => {
|
|||||||
expect(screen.getByRole('button', { name: /delete/i })).toBeInTheDocument();
|
expect(screen.getByRole('button', { name: /delete/i })).toBeInTheDocument();
|
||||||
expect(screen.getByRole('dialog', { name: 'Delete job' })).toHaveAccessibleDescription('Are you sure?');
|
expect(screen.getByRole('dialog', { name: 'Delete job' })).toHaveAccessibleDescription('Are you sure?');
|
||||||
expect(screen.getByRole('button', { name: 'Cancel' })).toHaveFocus();
|
expect(screen.getByRole('button', { name: 'Cancel' })).toHaveFocus();
|
||||||
|
const messageRegion = screen.getByRole('region', { name: 'Delete job' });
|
||||||
|
expect(messageRegion).toHaveAttribute('tabindex', '0');
|
||||||
|
messageRegion.focus();
|
||||||
|
expect(messageRegion).toHaveFocus();
|
||||||
});
|
});
|
||||||
|
|
||||||
test('uses the selected language for shared dialog defaults', async () => {
|
test('uses the selected language for shared dialog defaults', async () => {
|
||||||
|
|||||||
@@ -23,6 +23,7 @@ const ConfirmContext = createContext<ConfirmContextValue | null>(null);
|
|||||||
export function ConfirmProvider({ children }: { children: React.ReactNode }) {
|
export function ConfirmProvider({ children }: { children: React.ReactNode }) {
|
||||||
const i18n = useOptionalI18n();
|
const i18n = useOptionalI18n();
|
||||||
const messageId = useId();
|
const messageId = useId();
|
||||||
|
const titleId = useId();
|
||||||
const resolverRef = useRef<((value: boolean) => void) | null>(null);
|
const resolverRef = useRef<((value: boolean) => void) | null>(null);
|
||||||
const cancelButtonRef = useRef<HTMLButtonElement>(null);
|
const cancelButtonRef = useRef<HTMLButtonElement>(null);
|
||||||
const [state, setState] = useState<ConfirmState>({
|
const [state, setState] = useState<ConfirmState>({
|
||||||
@@ -60,13 +61,13 @@ export function ConfirmProvider({ children }: { children: React.ReactNode }) {
|
|||||||
return (
|
return (
|
||||||
<ConfirmContext.Provider value={value}>
|
<ConfirmContext.Provider value={value}>
|
||||||
{children}
|
{children}
|
||||||
<Dialog open={state.open} onClose={() => closeWith(false)} aria-describedby={messageId} fullWidth maxWidth="xs"
|
<Dialog open={state.open} onClose={() => closeWith(false)} aria-labelledby={titleId} aria-describedby={messageId} fullWidth maxWidth="xs"
|
||||||
slotProps={{
|
slotProps={{
|
||||||
paper: { sx: { borderRadius: 3, border: 1, borderColor: "divider", backgroundImage: "none" } },
|
paper: { sx: { borderRadius: 3, border: 1, borderColor: "divider", backgroundImage: "none" } },
|
||||||
transition: { onEntered: () => cancelButtonRef.current?.focus() },
|
transition: { onEntered: () => cancelButtonRef.current?.focus() },
|
||||||
}}>
|
}}>
|
||||||
<DialogTitle sx={{ pb: 1, fontWeight: 800 }}>{state.title}</DialogTitle>
|
<DialogTitle id={titleId} sx={{ pb: 1, fontWeight: 800 }}>{state.title}</DialogTitle>
|
||||||
<DialogContent>
|
<DialogContent role="region" aria-labelledby={titleId} tabIndex={0}>
|
||||||
<Alert severity={state.destructive ? "warning" : "info"} variant="outlined" sx={{ mb: 2 }}>
|
<Alert severity={state.destructive ? "warning" : "info"} variant="outlined" sx={{ mb: 2 }}>
|
||||||
{state.destructive
|
{state.destructive
|
||||||
? i18n?.t("confirmDestructiveHint") ?? "This action may be hard to undo."
|
? i18n?.t("confirmDestructiveHint") ?? "This action may be hard to undo."
|
||||||
|
|||||||
Reference in New Issue
Block a user