fix: keep preview retry controls stationary during pointer activation

This commit is contained in:
cesnimda
2026-10-24 23:31:58 +02:00
parent e80815f8df
commit b313e20bad
8 changed files with 79 additions and 4 deletions
@@ -192,7 +192,11 @@ for (const [mode, language] of [["light", "en"], ["dark", "nb"], ["light", "nb"]
await expect(frame.getByText("Reviewed CV-only æøå", { exact: true })).toBeVisible();
await page.getByText(t.cvEditorPreviewUnavailable, { exact: true }).evaluate(node => node.scrollIntoView({ block: "center" }));
await capture(page, info, `error-${suffix}`);
await page.getByRole("button", { name: t.cvEditorRetryPreview, exact: true }).click();
// A held pointer must keep its target even if focus handlers schedule a layout frame.
await page.getByRole("button", { name: t.cvEditorRetryPreview, exact: true }).hover();
await page.mouse.down();
await page.evaluate(() => new Promise<void>(resolve => requestAnimationFrame(() => requestAnimationFrame(() => resolve()))));
await page.mouse.up();
await expect(frame.getByText("Canonical engineer", { exact: true })).toBeVisible();
await expect(page.getByText(t.cvEditorPreviewUnavailable, { exact: true })).not.toBeVisible();
await page.getByRole("button", { name: t.cvEditorRedo, exact: true }).click();
+4 -2
View File
@@ -181,8 +181,9 @@ test("[PRES-C06 C10 E08] stale editor retains and downloads its draft; reviewed
await expect(headline).toBeVisible();
const remote = await page.request.put(`${apiUrl}/cv/variants/${cv.id}`, { headers, data: { expectedVersion: cv.version, settings: { ...cv.settings, headline: "Remote reviewed edit" } } });
expect(remote.status()).toBe(200);
const rejectedSave = page.waitForResponse(response => response.url() === `${apiUrl}/cv/variants/${cv.id}` && response.request().method() === "PUT" && response.status() === 409);
await headline.fill("Local recoverable draft æøå");
await page.getByRole("button", { name: "Save now", exact: true }).click();
expect((await rejectedSave).status()).toBe(409);
await expect(page.getByText("CV changed elsewhere", { exact: true })).toBeVisible();
await expect(headline).toHaveValue("Local recoverable draft æøå");
const downloadPromise = page.waitForEvent("download");
@@ -201,8 +202,9 @@ test("[PRES-C06 C10 E08] stale editor retains and downloads its draft; reviewed
await page.getByRole("dialog").getByRole("button", { name: "Reload saved CV", exact: true }).click();
await expect(page.getByRole("dialog")).toHaveCount(0);
await expect(headline).toHaveValue("Remote reviewed edit");
const reviewedSave = page.waitForResponse(response => response.url() === `${apiUrl}/cv/variants/${cv.id}` && response.request().method() === "PUT" && response.status() === 200);
await headline.fill("Reviewed combined edit");
await page.getByRole("button", { name: "Save now", exact: true }).click();
expect((await reviewedSave).status()).toBe(200);
await expect(page.getByText("Saved", { exact: true })).toBeVisible();
expect((await (await page.request.get(`${apiUrl}/cv/variants/${cv.id}`)).json()).version).toBe(3);
await page.getByRole("tab", { name: "History", exact: true }).click();