cesnimda/jobtrackingapp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(i18n): localize admin recovery states

Browse Source
This commit is contained in:
cesnimda
2026-08-29 23:40:29 +02:00
parent 10ce0f2086
commit cf6509ce13
7 changed files with 125 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
job-tracker-ui/src/admin-audit-page.test.tsx
+55
View File
@@ -0,0 +1,55 @@
import React from "react";
import "@testing-library/jest-dom";
import { fireEvent, render, screen } from "@testing-library/react";
import { api } from "./api";
import { I18nProvider } from "./i18n/I18nProvider";
import { ToastProvider } from "./toast";
import AdminAuditPage from "./views/AdminAuditPage";
jest.mock("./api", () => ({
api: { get: jest.fn(), post: jest.fn() },
getApiErrorMessage: jest.fn((_error, fallback) => fallback),
}));
const mockedApi = api as jest.Mocked<typeof api>;
function renderPage() {
return render(<ToastProvider><I18nProvider><AdminAuditPage /></I18nProvider></ToastProvider>);
}
beforeEach(() => {
jest.clearAllMocks();
window.localStorage.clear();
});
test("distinguishes an unavailable audit log from an empty audit log and retries", async () => {
mockedApi.get.mockRejectedValueOnce(new Error("offline"));
renderPage();
expect(await screen.findByText("Unable to load audit events")).toBeInTheDocument();
expect(screen.queryByText("No events.")).not.toBeInTheDocument();
mockedApi.get.mockResolvedValueOnce({ data: [] } as any);
fireEvent.click(screen.getByRole("button", { name: "Retry" }));
expect(await screen.findByText("No events.")).toBeInTheDocument();
});
test("localizes audit actions in Bokmål without translating stored event data", async () => {
window.localStorage.setItem("uiLanguage", "nb-NO");
mockedApi.get.mockResolvedValueOnce({ data: [{
id: 7,
type: "Deleted",
at: "2026-08-29T12:00:00Z",
jobApplicationId: 42,
companyName: "Example AS",
note: "User-authored note",
}] } as any);
renderPage();
expect(await screen.findByRole("button", { name: "Angre" })).toBeInTheDocument();
expect(screen.getByRole("button", { name: "Gjenopprett" })).toBeInTheDocument();
expect(screen.getByText("Example AS - Jobb #42")).toBeInTheDocument();
expect(screen.getByText("User-authored note")).toBeInTheDocument();
});
job-tracker-ui/src/components/SettingsView.tsx
+4 -4
View File
@@ -79,9 +79,9 @@ export default function SettingsView({
let active = true;
api.get<NotificationPrefs>("/notification-settings")
.then(({ data }) => { if (active) setNotificationPrefs(data); })
.catch((error) => { if (active) setNotificationError(getApiErrorMessage(error, "Notification settings could not be loaded.")); });
.catch((error) => { if (active) setNotificationError(getApiErrorMessage(error, t("settingsNotificationsLoadFailed"))); });
return () => { active = false; };
}, []);
}, [t]);
const saveNotifications = async () => {
if (!notificationPrefs) return;
@@ -90,9 +90,9 @@ export default function SettingsView({
try {
const { data } = await api.put<NotificationPrefs>("/notification-settings", notificationPrefs);
setNotificationPrefs(data);
toast("Notification settings saved.", "success");
toast(t("settingsNotificationsSaved"), "success");
} catch (error) {
setNotificationError(getApiErrorMessage(error, "Notification settings could not be saved."));
setNotificationError(getApiErrorMessage(error, t("settingsNotificationsSaveFailed")));
} finally { setSavingNotifications(false); }
};
job-tracker-ui/src/i18n/translations.ts
+26
View File
@@ -991,6 +991,9 @@ export const translations = {
settingsNotificationsFollowUpReminders: "Email reminders for follow-ups",
settingsNotificationsGhostedJobs: "Email alerts for ghosted jobs",
settingsNotificationsInAppReminders: "Highlight reminders in the app",
settingsNotificationsLoadFailed: "Notification settings could not be loaded.",
settingsNotificationsSaved: "Notification settings saved.",
settingsNotificationsSaveFailed: "Notification settings could not be saved.",
settingsCheckSystemStatus: "Check system status",
profileTitle: "Profile",
profileHeadlinePlaceholder: "Add a short headline to personalize your account view.",
@@ -1057,6 +1060,8 @@ export const translations = {
profileCvRetryQueued: "CV processing queued again.",
profileCvRetryFailed: "Could not retry CV processing.",
profileCvRetryProcessing: "Retry processing",
profileCvRunFailed: "CV {trigger} failed.",
profileCvRunReady: "CV {trigger} is ready to review.",
profileCvDiffSummary: "{added} additions | {updated} updates",
profileCvNeedAttention: "{count} need attention",
profileCvNoChangesFound: "No profile changes found",
@@ -1715,6 +1720,14 @@ export const translations = {
attachmentsDownloadFailed: "Download failed.",
attachmentsPreviewFailed: "Preview failed.",
adminAuditRestored: "Restored.",
adminAuditRestore: "Restore",
adminAuditRestoreFailed: "Restore failed.",
adminAuditUndo: "Undo",
adminAuditUndone: "Undone.",
adminAuditUndoFailed: "Undo failed.",
adminAuditLoadFailed: "Unable to load audit events",
adminAuditLoadFailedBody: "The audit log cannot reach the API right now.",
adminAuditJobFallback: "Job #{id}",
adminAuditTitle: "Audit log",
adminAuditSubtitle: "Admin-only.",
adminAuditAt: "At",
@@ -3290,6 +3303,9 @@ export const translations = {
settingsNotificationsFollowUpReminders: "E-postpåminnelser for oppfølginger",
settingsNotificationsGhostedJobs: "E-postvarsler for ghostede jobber",
settingsNotificationsInAppReminders: "Fremhev påminnelser i appen",
settingsNotificationsLoadFailed: "Varslingsinnstillingene kunne ikke lastes.",
settingsNotificationsSaved: "Varslingsinnstillingene er lagret.",
settingsNotificationsSaveFailed: "Varslingsinnstillingene kunne ikke lagres.",
settingsCheckSystemStatus: "Sjekk systemstatus",
profileTitle: "Profil",
profileHeadlinePlaceholder: "Legg til en kort overskrift for å gjøre kontovisningen mer personlig.",
@@ -3356,6 +3372,8 @@ export const translations = {
profileCvRetryQueued: "CV-behandlingen er satt i kø på nytt.",
profileCvRetryFailed: "Kunne ikke prøve CV-behandlingen på nytt.",
profileCvRetryProcessing: "Prøv behandlingen på nytt",
profileCvRunFailed: "CV {trigger} mislyktes.",
profileCvRunReady: "CV {trigger} er klar til gjennomgang.",
profileCvDiffSummary: "{added} tillegg | {updated} oppdateringer",
profileCvNeedAttention: "{count} trenger gjennomgang",
profileCvNoChangesFound: "Ingen profilendringer funnet",
@@ -4014,6 +4032,14 @@ export const translations = {
attachmentsDownloadFailed: "Nedlasting mislyktes.",
attachmentsPreviewFailed: "Forhåndsvisning mislyktes.",
adminAuditRestored: "Gjenopprettet.",
adminAuditRestore: "Gjenopprett",
adminAuditRestoreFailed: "Gjenoppretting mislyktes.",
adminAuditUndo: "Angre",
adminAuditUndone: "Angret.",
adminAuditUndoFailed: "Kunne ikke angre.",
adminAuditLoadFailed: "Kunne ikke laste revisjonshendelser",
adminAuditLoadFailedBody: "Revisjonsloggen fikk ikke kontakt med API-et akkurat nå.",
adminAuditJobFallback: "Jobb #{id}",
adminAuditTitle: "Revisjonslogg",
adminAuditSubtitle: "Kun for admin.",
adminAuditAt: "Tidspunkt",
job-tracker-ui/src/views/AdminAuditPage.tsx
+31 -31
View File
@@ -1,4 +1,4 @@
import React, { useCallback, useEffect, useMemo, useState } from "react";
import React, { useState } from "react";
import {
Box,
@@ -17,6 +17,8 @@ import {
import { api } from "../api";
import { useToast } from "../toast";
import { useI18n } from "../i18n/I18nProvider";
import { useViewResource } from "../hooks/useViewResource";
import ViewStateNotice from "../components/ViewStateNotice";
type AuditItem = {
id: number;
@@ -39,36 +41,26 @@ function canUndo(type: string) {
export default function AdminAuditPage() {
const { toast } = useToast();
const { t } = useI18n();
const [items, setItems] = useState<AuditItem[]>([]);
const [loading, setLoading] = useState(false);
const { language, t } = useI18n();
const [busyId, setBusyId] = useState<number | null>(null);
const load = useCallback(async () => {
setLoading(true);
try {
const auditResource = useViewResource(
async () => {
const r = await api.get<AuditItem[]>("/admin/audit?take=200");
setItems(r.data ?? []);
} catch {
setItems([]);
} finally {
setLoading(false);
}
}, []);
useEffect(() => {
void load();
}, [load]);
return r.data ?? [];
},
{ initialData: [], errorMessage: t("adminAuditLoadFailed"), deps: [t] },
);
const undo = async (e: AuditItem) => {
if (!canUndo(e.type)) return;
setBusyId(e.id);
try {
const res = await api.post<{ ok: boolean; message: string }>(`/admin/audit/${e.id}/undo`, {});
toast(res.data?.message || "Undone.", "success");
await load();
toast(res.data?.message || t("adminAuditUndone"), "success");
await auditResource.reload();
} catch (err: any) {
const msg = err?.response?.data?.message || err?.response?.data || err?.message || "Undo failed.";
const msg = err?.response?.data?.message || err?.response?.data || err?.message || t("adminAuditUndoFailed");
toast(String(msg), "error");
} finally {
setBusyId(null);
@@ -80,16 +72,16 @@ export default function AdminAuditPage() {
try {
await api.post(`/jobapplications/${e.jobApplicationId}/restore`, {});
toast(t("adminAuditRestored"), "success");
await load();
await auditResource.reload();
} catch (err: any) {
const msg = err?.response?.data || err?.message || "Restore failed.";
const msg = err?.response?.data || err?.message || t("adminAuditRestoreFailed");
toast(String(msg), "error");
} finally {
setBusyId(null);
}
};
const rows = useMemo(() => items, [items]);
const rows = auditResource.data;
return (
<Paper sx={{ mt: 0, p: 2 }}>
@@ -100,7 +92,15 @@ export default function AdminAuditPage() {
{t("adminAuditSubtitle")}
</Typography>
<TableContainer sx={{ borderRadius: 2, border: "none", boxShadow: "0px 1px 2px 0px rgba(15,23,42,0.04), 0px 8px 24px -12px rgba(15,23,42,0.12)" }}>
<ViewStateNotice
loading={auditResource.loading}
error={auditResource.error}
title={t("adminAuditLoadFailed")}
description={t("adminAuditLoadFailedBody")}
onRetry={auditResource.reload}
/>
{!auditResource.error ? <TableContainer sx={{ borderRadius: 2, border: "none", boxShadow: "0px 1px 2px 0px rgba(15,23,42,0.04), 0px 8px 24px -12px rgba(15,23,42,0.12)" }}>
<Table size="small">
<TableHead>
<TableRow>
@@ -113,7 +113,7 @@ export default function AdminAuditPage() {
</TableRow>
</TableHead>
<TableBody>
{loading ? (
{auditResource.loading ? (
<TableRow>
<TableCell colSpan={6}>
<Typography sx={{ color: "text.secondary" }}>{t("loading")}</Typography>
@@ -127,7 +127,7 @@ export default function AdminAuditPage() {
</TableRow>
) : (
rows.map((e) => {
const jobLabel = e.jobTitle || `Job #${e.jobApplicationId}`;
const jobLabel = e.jobTitle || t("adminAuditJobFallback", { id: e.jobApplicationId });
const ownerLabel = e.ownerEmail || e.ownerUserName || e.ownerUserId || "-";
const details = e.oldValue || e.newValue ? `${e.oldValue ?? ""} -> ${e.newValue ?? ""}` : "";
const disabled = busyId === e.id;
@@ -135,7 +135,7 @@ export default function AdminAuditPage() {
return (
<TableRow key={e.id} hover>
<TableCell>{e.at ? new Date(e.at).toLocaleString() : ""}</TableCell>
<TableCell>{e.at ? new Date(e.at).toLocaleString(language === "nb" ? "nb-NO" : "en-GB") : ""}</TableCell>
<TableCell>
<Chip label={e.type} size="small" variant="outlined" />
</TableCell>
@@ -161,12 +161,12 @@ export default function AdminAuditPage() {
<Box sx={{ display: "flex", gap: 1, flexWrap: "wrap" }}>
{canUndo(e.type) ? (
<Button size="small" variant="outlined" disabled={disabled} onClick={() => void undo(e)}>
Undo
{t("adminAuditUndo")}
</Button>
) : null}
{showRestore ? (
<Button size="small" variant="contained" disabled={disabled} onClick={() => void restore(e)}>
Restore
{t("adminAuditRestore")}
</Button>
) : null}
</Box>
@@ -177,7 +177,7 @@ export default function AdminAuditPage() {
)}
</TableBody>
</Table>
</TableContainer>
</TableContainer> : null}
</Paper>
);
}
job-tracker-ui/src/views/CareerProfilePage.tsx
+5 -5
View File
@@ -250,11 +250,11 @@ export default function CareerProfilePage() {
setLoadError(null);
} catch (error: any) {
setMe(null);
setLoadError(String(error?.response?.data || error?.message || "Unable to load profile right now."));
setLoadError(String(error?.response?.data || error?.message || t("profileLoadFailed")));
} finally {
setLoading(false);
}
}, []);
}, [t]);
useEffect(() => {
void loadProfile();
@@ -292,14 +292,14 @@ export default function CareerProfilePage() {
const status = cvRunStatus(run);
const prior = previous[run.id];
if (activeRunLabels.has(prior) && status === "pending_review") {
toast(`CV ${run.trigger} is ready to review.`, "info");
toast(t("profileCvRunReady", { trigger: run.trigger }), "info");
}
if (activeRunLabels.has(prior) && status === "failed") {
toast(run.errorMessage || `CV ${run.trigger} failed.`, "error");
toast(run.errorMessage || t("profileCvRunFailed", { trigger: run.trigger }), "error");
}
previous[run.id] = status;
}
}, [extractionRuns, toast]);
}, [extractionRuns, t, toast]);
// Field-review lookup passed to the extracted sections. They stay decoupled from the full profile
// shape; the parent still owns structuredCv and the metadata source.
job-tracker-ui/src/views/ProfilePage.tsx
+2 -2
View File
@@ -108,11 +108,11 @@ export default function ProfilePage() {
setLoadError(null);
} catch (error: any) {
setMe(null);
setLoadError(String(error?.response?.data || error?.message || "Unable to load profile right now."));
setLoadError(String(error?.response?.data || error?.message || t("profileLoadFailed")));
} finally {
setLoading(false);
}
}, []);
}, [t]);
useEffect(() => {
void loadProfile();