From ee8efd361d03e15a342089e84856e06eb2684ba2 Mon Sep 17 00:00:00 2001 From: cesnimda Date: Mon, 10 Aug 2026 09:49:30 +0200 Subject: [PATCH] docs(email): record free access boundary --- docs/audits/verification-log.md | 1 + docs/verification/mail-001-job-email-hub.md | 11 +++++++++-- docs/work-programmes/decisions.md | 10 ++++++++++ docs/work-programmes/master-progress.md | 4 ++-- docs/work-programmes/master-work-plan.md | 6 +++--- docs/work-programmes/session-handoff.md | 12 ++++++------ 6 files changed, 31 insertions(+), 13 deletions(-) diff --git a/docs/audits/verification-log.md b/docs/audits/verification-log.md index d3185e9..4168644 100644 --- a/docs/audits/verification-log.md +++ b/docs/audits/verification-log.md @@ -176,3 +176,4 @@ Output was reduced to filenames and commit counts. The token artifact appears un | V-142 | Provider-scope/contract inventory; focused correspondence context/inbox/job-detail Jest; full frontend Jest; production build; `git diff --check` | Repository root / `job-tracker-ui` | Verify the shared Application Workspace passes real job context without inventing unsupported provider actions | PASS — removed `null as any`; both application surfaces use one small context contract; focused 3/3 suites and 10/10 tests; full 50/50 suites and 192/192 tests; production build/TypeScript pass; `ff547df` committed | Gmail/Graph installed scopes do not include mutation and IMAP is read-only; no provider/network/browser/production action occurred | Provider mutation remains unsupported and honestly deferred | | V-143 | Focused correspondence-inbox Jest; focused Gmail unlink API tests; full backend/frontend; production build; `git diff --check` | Repository root / `job-tracker-ui` | Verify canonical-hub Gmail unlink confirmation, provider-copy disclosure and cross-user isolation | PASS — hub 8/8; unlink API 2/2 including real-database User A/User B denial; backend 623/623; frontend 50/50 suites and 193/193 tests; build/TypeScript pass; `1dabbeb` committed | Mocked UI and local SQLite only; no provider message was deleted and no provider/network/production action occurred | Browser/provider/production verification remains | | V-144 | Focused correspondence-inbox Jest; full frontend Jest; production build; `git diff --check` | `job-tracker-ui` / repository root | Verify disconnected/read-only/send-capable/provider-failure states remain honest without hiding saved correspondence | PASS — focused 9/9; full 50/50 suites and 194/194 tests; build/TypeScript pass; disconnected no longer claims read access; status failure leaves saved inbox visible; `f9e641c` committed | Mocked status responses only; no provider/network/browser/production action occurred | Provider mutation capabilities remain unsupported | +| V-145 | Email draft/storage inventory; focused `EmailSendControllerTests`; full backend; route authorization reflection; `git diff --check` | Repository root | Verify basic authenticated provider email remains Free while preserving send safety, and identify a privacy-safe durable-draft boundary | PASS/PARTIAL — local authentication is required with no Pro policy; focused 7/7 and backend 624/624; no existing email-draft entity safely owns recipient/subject/body/thread/provider/request state, so browser storage/job recruiter drafts were rejected as unsafe conflation | No provider/network/browser/production action; durable draft schema/API remains unimplemented | Free access verified; durable draft design pending | diff --git a/docs/verification/mail-001-job-email-hub.md b/docs/verification/mail-001-job-email-hub.md index b611346..39515ad 100644 --- a/docs/verification/mail-001-job-email-hub.md +++ b/docs/verification/mail-001-job-email-hub.md @@ -71,7 +71,7 @@ Status: `IN PROGRESS`. Canonical hub routing, provider-neutral reads, explicit-c - Confirmed composer focused tests: 7/7. - Full backend: 620/620; full frontend: 49/49 suites, 190/190 tests. - Production build/TypeScript and `git diff --check`: pass. -- Implementation commits: `6008b4a`, `536d403`, `a20775c`, `653f011`, `e9937ac`, `123fc55`, `449faeb`, `ee5ef7e`, `8fe3903`, `aff34cc`, `ff547df`, `1dabbeb`, `f9e641c`. +- Implementation commits: `6008b4a`, `536d403`, `a20775c`, `653f011`, `e9937ac`, `123fc55`, `449faeb`, `ee5ef7e`, `8fe3903`, `aff34cc`, `ff547df`, `1dabbeb`, `f9e641c`, `7f41cb2`. ## Implemented editable composer increment @@ -129,6 +129,13 @@ Status: `IN PROGRESS`. Canonical hub routing, provider-neutral reads, explicit-c - Failure of the provider-status endpoint is no longer silent. The hub shows a warning while keeping owner-saved JobTracker correspondence available and usable. - No provider scope, mailbox mutation or connection state changed. Focused hub tests pass 9/9, full frontend passes 50/50 suites and 194/194 tests, and production build/TypeScript passes. +## Verified Free non-AI access + +- The provider read/send controller requires authenticated local application access but has no Pro policy on the class or send action. A regression test pins both sides of this boundary. +- The send path still requires an owned job, connected send-capable provider, explicit confirmation and idempotency; Free access does not weaken those controls. +- The hub has no AI-assistance action today, so there is no AI email feature to mislabel as Free or Pro. Any future AI drafting must use the existing Pro/privacy admission boundary without changing basic email access. +- Focused send tests pass 7/7 and full backend passes 624/624. + ## Remaining MAIL-001 work - Extend shared provider-neutral thread navigation while preserving provider capability differences; application context and Gmail unlink are now shared. @@ -136,7 +143,7 @@ Status: `IN PROGRESS`. Canonical hub routing, provider-neutral reads, explicit-c - Share thread detail and link/unlink actions between hub and job workspace. - Add durable draft/refresh recovery and compose-new-message behavior if confirmed by the remaining workflow inventory; replies are implemented. - Complete account deletion coverage under SEC-009 before production rollout; job-level hard-delete cascade and export coverage are verified. -- Preserve minimal audit metadata without sensitive body logging; verify Free non-AI access and Pro-only AI assistance. +- Preserve minimal audit metadata without sensitive body logging. Free non-AI access is verified; future AI assistance remains a Pro/privacy-gated addition, not a prerequisite for basic email. - Complete remaining link/unlink/dismiss/draft/send/failure/two-user browser/production provider gates. Shared application-context behavior is now covered locally. No real email may be sent during repository verification. ## Validation limitation diff --git a/docs/work-programmes/decisions.md b/docs/work-programmes/decisions.md index 3d95cd5..bc60c71 100644 --- a/docs/work-programmes/decisions.md +++ b/docs/work-programmes/decisions.md @@ -519,3 +519,13 @@ - **Consequences:** users can distinguish connection state from send consent and know saved data remains available. Mailbox organization actions remain absent until a reviewed provider contract and re-consent path exist. - **User approval required:** No; this corrects local state communication and invokes no provider. - **Reversible:** Yes. Revert `f9e641c`; no API, schema, scope or stored state changes. + +## DEC-053 — Basic email stays Free; private drafts need a tenant-owned store + +- **Date:** 2026-08-10 +- **Decision:** Pin basic provider email to local authenticated access without a Pro policy. Do not persist private email content in browser storage or reuse recruiter-message/job draft fields for provider email recovery. +- **Reason/evidence:** the current send route and hub have no entitlement gate, while all send safety checks remain. Repository inventory found no email-draft entity that owns provider/thread/recipient/subject/body/idempotency together; existing recruiter drafts are a different product domain. +- **Alternatives considered:** add Pro to basic email; use localStorage/sessionStorage; overload `RecruiterMessageDraft`; claim in-memory replies are durable. These violate the product decision, expose content on shared browsers, conflate domains or overstate recovery. +- **Consequences:** Free users retain non-AI email. Durable/new-message drafts require an owner-filtered database model, bounded API, export/deletion coverage and rollback migration as a separate cohesive increment. Future AI assistance remains Pro/privacy gated. +- **User approval required:** No; this is repository-local verification and a safety boundary inside approved MAIL-001. +- **Reversible:** The regression test can be reverted with `7f41cb2`; no runtime/schema state changed. Adding a Pro gate later would be an explicit product change. diff --git a/docs/work-programmes/master-progress.md b/docs/work-programmes/master-progress.md index b7fec00..dd5b3f2 100644 --- a/docs/work-programmes/master-progress.md +++ b/docs/work-programmes/master-progress.md @@ -2,7 +2,7 @@ Updated: 2026-08-10 -- **Overall programme status:** Active. Seven packages are locally verified; nineteen packages through CAREER-002 are implemented with automated/runtime evidence but blocked from applicable browser/provider/production gates; MAIL-001 is in progress with thirteen committed implementation increments. Gitea run 609 passes complete pull-request CI in 4m20s; DEP-001 now awaits approved merge-to-main and production verification only. +- **Overall programme status:** Active. Seven packages are locally verified; nineteen packages through CAREER-002 are implemented with automated/runtime evidence but blocked from applicable browser/provider/production gates; MAIL-001 is in progress with fourteen committed implementation/test increments. Gitea run 609 passes complete pull-request CI in 4m20s; DEP-001 now awaits approved merge-to-main and production verification only. - **Current work package:** `MAIL-001` — consolidated job-email hub and explicit sending (`IN PROGRESS`); routing/reads/detail, ledger, Gmail/Graph delivery/re-consent, safe send API/UI, recovery, legacy SMTP retirement and content-free export/job-cascade coverage are committed. Application context, confirmed Gmail unlink and honest disconnected/read-only/send/failure states are shared. Provider mailbox mutations and durable/new-message drafts remain; full account deletion stays SEC-009. - **Completed work packages:** None are `DONE`; all repository security/AI packages still have applicable browser, provider and/or production gates. - **Locally verified work:** SEC-001, SEC-002, SEC-003, SEC-005A, CORE-001, PROD-002 and DEP-001 (`VERIFIED LOCALLY`). @@ -12,7 +12,7 @@ Updated: 2026-08-10 - **Deferred work:** None. Conditional multi-replica coordination, model deletion, realtime operation delivery and unrelated production changes remain outside current packages. - **Next five work packages:** MAIL-001 consolidated email experience; JOBS-001 job-search/application redesign; HOME-001 homepage/Pro promotion; UX-003 authentication/profile polish; PRODUCT-001 homepage/Pro claims. SEC-006/007 resume after package-index permission. - **Status counts:** 7 `VERIFIED LOCALLY`; 19 `IMPLEMENTED — NOT VERIFIED`; 1 `IN PROGRESS`; 8 `NOT STARTED`; 5 `BLOCKED`; 0 `DONE`; 0 `DEFERRED`. -- **Test status:** backend 623/623; frontend 50/50 suites and 194/194 tests; Playwright smoke 4/4; npm audit 0 vulnerabilities; DEP-001 focused router 24/24 and production build pass; MAIL-001 provider states 9/9, hub unlink 8/8 UI and 2/2 API, shared context 10/10, export/cascade 16/16, recovery/send 10/10, legacy follow-up/backend worker 10/10, legacy UI 2/2, composer 7/7, delivery/capability 18/18, provider/correspondence 5/5 and hub detail 5/5. Jest open-handle/slow-run behavior is recorded in V-127/V-128/V-130/V-131/V-135/V-142/V-143/V-144. +- **Test status:** backend 624/624; frontend 50/50 suites and 194/194 tests; Playwright smoke 4/4; npm audit 0 vulnerabilities; DEP-001 focused router 24/24 and production build pass; MAIL-001 Free send 7/7, provider states 9/9, hub unlink 8/8 UI and 2/2 API, shared context 10/10, export/cascade 16/16, recovery/send 10/10, legacy follow-up/backend worker 10/10, legacy UI 2/2, composer 7/7, delivery/capability 18/18, provider/correspondence 5/5 and hub detail 5/5. Jest open-handle/slow-run behavior is recorded in V-127/V-128/V-130/V-131/V-135/V-142/V-143/V-144. - **Deployment status:** Gitea pull-request run 609 passed the complete CI job in 4m20s. Deploy was intentionally skipped because the workflow deploys only a `push` to `main`; live remains unchanged. No merge/deployment was performed directly, no production migrations were run and the AI operation worker remains disabled by default. - **Production status:** Unchanged and unverified. No provider/model call, model pull, external request or paid API occurred. - **Known regressions:** None found by automated/local browser checks. Jest still needs `--forceExit` and reports its existing open-handle notice. Email-provider/send tests are fake/local only; real delivery is not claimed. Current MAIL browser evidence is 1280×720 only because the browser surface could not resize or perform native Tab traversal. Interrupted attempts are aged after 15 minutes and notified without retry; the five-minute scan is unmeasured on a large ledger. Direct clean EF-only SQLite migration still hits the pre-existing historical blank-chain defect before later migrations; normal startup owns reconciliation. Cross-feature monthly AI usage accounting remains a rollout gap. diff --git a/docs/work-programmes/master-work-plan.md b/docs/work-programmes/master-work-plan.md index b22863e..1a87e8d 100644 --- a/docs/work-programmes/master-work-plan.md +++ b/docs/work-programmes/master-work-plan.md @@ -651,9 +651,9 @@ Ordering differences from the suggested list: - **Required production verification:** provider read/draft/send requires explicit authorized synthetic account; never real unsolicited email. - **Status:** `IN PROGRESS`. - **Blocker:** real provider verification is external; required 375/768/1440/theme/keyboard browser gates were unavailable in the current browser surface. Mocked/local repository implementation remains unblocked. -- **Evidence:** `docs/verification/mail-001-job-email-hub.md`; V-126–V-144. Provider states 9/9; hub unlink 8/8 UI and 2/2 API; shared application context focused 10/10; export/cascade focused 16/16; recovery/send focused 10/10; legacy follow-up/worker 10/10; composer 7/7; delivery/capability 18/18; provider/correspondence 5/5; hub detail 5/5; backend 623/623; frontend 50/50 suites and 194/194 tests plus build/audit; local empty/disconnected and compatibility-route browser smoke at 1280×720. -- **Commit:** `6008b4a` (hub), `536d403` (neutral reads), `a20775c` (safe detail), `653f011` (ledger), `e9937ac` (Gmail/Graph delivery adapters and consent), `123fc55` (explicit-confirmed send API), `449faeb` (confirmed reply composer), `ee5ef7e` (interrupted-send recovery), `8fe3903` (legacy SMTP retirement), `aff34cc` (content-free export and cascade evidence), `ff547df` (shared application context), `1dabbeb` (confirmed hub unlink), `f9e641c` (honest provider states). -- **Remaining work:** full account deletion remains SEC-009; durable/new-message drafts; shared thread/application actions and category capabilities; free/pro and browser/production verification. Existing connections need explicit re-consent; IMAP remains read-only. No real email; uncertain sends need manual reconciliation. +- **Evidence:** `docs/verification/mail-001-job-email-hub.md`; V-126–V-145. Free send policy 7/7; provider states 9/9; hub unlink 8/8 UI and 2/2 API; shared application context focused 10/10; export/cascade focused 16/16; recovery/send focused 10/10; legacy follow-up/worker 10/10; composer 7/7; delivery/capability 18/18; provider/correspondence 5/5; hub detail 5/5; backend 624/624; frontend 50/50 suites and 194/194 tests plus build/audit; local empty/disconnected and compatibility-route browser smoke at 1280×720. +- **Commit:** `6008b4a` (hub), `536d403` (neutral reads), `a20775c` (safe detail), `653f011` (ledger), `e9937ac` (Gmail/Graph delivery adapters and consent), `123fc55` (explicit-confirmed send API), `449faeb` (confirmed reply composer), `ee5ef7e` (interrupted-send recovery), `8fe3903` (legacy SMTP retirement), `aff34cc` (content-free export and cascade evidence), `ff547df` (shared application context), `1dabbeb` (confirmed hub unlink), `f9e641c` (honest provider states), `7f41cb2` (Free email policy regression). +- **Remaining work:** full account deletion remains SEC-009; privacy-safe durable/new-message drafts; mailbox category capabilities; browser/production verification. Existing connections need explicit re-consent; IMAP remains read-only. No real email; uncertain sends need manual reconciliation. ### JOBS-001 — Job-search source and assessment redesign diff --git a/docs/work-programmes/session-handoff.md b/docs/work-programmes/session-handoff.md index dd4b358..d6559c7 100644 --- a/docs/work-programmes/session-handoff.md +++ b/docs/work-programmes/session-handoff.md @@ -3,16 +3,16 @@ Updated: 2026-08-10 - **Exact current task:** MAIL-001 — trace shared provider-neutral thread/application actions and implement only capabilities the existing providers can safely support. -- **Last completed step:** canonical Job email now distinguishes disconnected/read-only/send-capable/status-failure states without hiding saved correspondence; `f9e641c` is committed and frontend 194/194/build pass. -- **Files currently modified:** MAIL-001 tracking only; provider-state implementation is committed as `f9e641c`. -- **Commands already run:** dependency/audit/router/full frontend/build; legacy follow-up/export/recovery/provider suites; full backend; Gitea run inspection; Playwright; MAIL context/unlink/provider-state focused and full suites/build. See V-126–V-144. -- **Test results:** npm audit 0 vulnerabilities; Gitea pull-request CI PASS in 4m20s; backend 623/623; frontend 50/50 suites and 194/194 tests; Playwright 4/4; production build passes. MAIL provider states 9/9, unlink 8/8 UI and 2/2 API, shared context 10/10, export/cascade 16/16. +- **Last completed step:** basic email Free access is pinned by `7f41cb2`; focused 7/7 and backend 624/624 pass. Draft inventory rejects browser storage and recruiter-draft reuse as privacy/domain violations. +- **Files currently modified:** MAIL-001 tracking only; Free-access regression is committed as `7f41cb2`. +- **Commands already run:** dependency/audit/router/full frontend/build; legacy follow-up/export/recovery/provider suites; full backend; Gitea run inspection; Playwright; MAIL context/unlink/provider-state/Free-policy focused and full suites/build. See V-126–V-145. +- **Test results:** npm audit 0 vulnerabilities; Gitea pull-request CI PASS in 4m20s; backend 624/624; frontend 50/50 suites and 194/194 tests; Playwright 4/4; production build passes. MAIL Free send 7/7, provider states 9/9, unlink 8/8 UI and 2/2 API, shared context 10/10, export/cascade 16/16. - **Services currently running:** none on task-owned ports 3000/5202. Playwright stopped its disposable API/Next servers. Pre-existing Docker services were not changed. - **Temporary files or processes:** disposable local user `audit-mail-20260810@example.test`, its local session, two synthetic screenshots and a startup-created local database backup. The API applied already-committed pending development migrations to the local development database. No provider account, real email, private content, paid service or production service was accessed. - **Production changes currently active:** none. No deployment, migration, provider connection/sync/send or production payload occurred. - **Rollback status:** revert `ee5ef7e` to stop recovery, then `449faeb` to remove the composer; keep admission disabled before reverting `123fc55`/`e9937ac` and downgrade the ledger before reverting `653f011`. No production migration/deploy/provider grant occurred. -- **Uncommitted changes:** tracking for `f9e641c` only; commit and push before the next implementation increment. +- **Uncommitted changes:** tracking for `7f41cb2` only; commit and push before the next implementation increment. - **Known failures:** live deployment is not verified because PR deploy is intentionally skipped and the active branch is not approved for merge. Durable/new-message drafts, full thread/category actions and non-Gmail review remain; existing accounts need re-consent and IMAP stays read-only. Browser/provider/MariaDB/production unavailable or unverified; recovery scan performance is unmeasured at large ledger scale; Jest open handles; SEC-006 parser dependency work is still separately gated; parser isolation remains SEC-007. -- **Exact next action:** commit/push the tracking for `f9e641c`, then revalidate durable draft/new-message requirements and choose a privacy-safe storage boundary. Do not place message content in logs or unauthenticated browser storage. +- **Exact next action:** commit/push the tracking for `7f41cb2`, then design the owner-filtered email-draft entity/API, export/deletion coverage and reversible provider SQL before implementing it. Do not place message content in logs or unauthenticated browser storage. - **Work that can continue independently:** remaining MAIL-001 repository work and later UX packages. SEC-006/007 await package-index permission; PROD-001/003/004 await production access. - **Decisions still required from the user:** none for synthetic/code-inspected repository work. Any provider connection or send test, internet/package upgrades, private data, external/paid providers and production actions retain explicit approval/safety gates; SEC-009 retention/legal policy remains unresolved.