From fb7240f2ff148f46b77d8b43365a3aab317d2955 Mon Sep 17 00:00:00 2001 From: cesnimda Date: Mon, 10 Aug 2026 10:01:48 +0200 Subject: [PATCH] docs(email): record draft export evidence --- docs/audits/verification-log.md | 1 + docs/verification/mail-001-job-email-hub.md | 11 +++++++++-- docs/work-programmes/decisions.md | 10 ++++++++++ docs/work-programmes/master-progress.md | 6 +++--- docs/work-programmes/master-work-plan.md | 6 +++--- docs/work-programmes/session-handoff.md | 10 +++++----- 6 files changed, 31 insertions(+), 13 deletions(-) diff --git a/docs/audits/verification-log.md b/docs/audits/verification-log.md index f2305ac..0533adb 100644 --- a/docs/audits/verification-log.md +++ b/docs/audits/verification-log.md @@ -178,3 +178,4 @@ Output was reduced to filenames and commit counts. The token artifact appears un | V-144 | Focused correspondence-inbox Jest; full frontend Jest; production build; `git diff --check` | `job-tracker-ui` / repository root | Verify disconnected/read-only/send-capable/provider-failure states remain honest without hiding saved correspondence | PASS — focused 9/9; full 50/50 suites and 194/194 tests; build/TypeScript pass; disconnected no longer claims read access; status failure leaves saved inbox visible; `f9e641c` committed | Mocked status responses only; no provider/network/browser/production action occurred | Provider mutation capabilities remain unsupported | | V-145 | Email draft/storage inventory; focused `EmailSendControllerTests`; full backend; route authorization reflection; `git diff --check` | Repository root | Verify basic authenticated provider email remains Free while preserving send safety, and identify a privacy-safe durable-draft boundary | PASS/PARTIAL — local authentication is required with no Pro policy; focused 7/7 and backend 624/624; no existing email-draft entity safely owns recipient/subject/body/thread/provider/request state, so browser storage/job recruiter drafts were rejected as unsafe conflation | No provider/network/browser/production action; durable draft schema/API remains unimplemented | Free access verified; durable draft design pending | | V-146 | `EmailDraftPersistenceTests`; full backend; backend build; `dotnet ef migrations has-pending-model-changes`; SQLite/MariaDB up/down script generation; disposable full-chain SQLite migration rehearsal; staged diff review | Repository root | Verify an inert owner-filtered email-draft persistence boundary, job lifecycle, additive dual-provider migration and rollback | PASS/PARTIAL — two-owner real-SQLite isolation/cascade passes; backend 625/625; build has 0 warnings/errors; model current; SQLite and MariaDB up/down SQL are bounded and reversible; `14b396a` pushed | Full-chain disposable SQLite apply is blocked before the new migration by pre-existing `AddJobEntityAndProspectStages` blank-chain drift (`LastReminderEmailSentAt` is referenced before creation); MariaDB SQL generated but not executed; no API/UI/provider/content logging added | Draft persistence verified; historical migration blocker remains JT-019 | +| V-147 | Focused `BackupControllerTests|BackgroundWorkerTenantTests.Daily_export_writes_one_isolated_atomic_file_per_owner`; full backend; staged diff review | Repository root | Verify readable private draft coverage through existing owner-isolated export boundaries | PASS — focused 4/4 and backend 625/625; encrypted on-demand export includes User A's complete draft and excludes User B; daily export writes exactly one matching draft per hashed owner file; `2fa4e38` pushed | Synthetic content and local stores only; daily exports inherit the existing plaintext-at-rest export-folder boundary; complete account deletion/backup retention remains SEC-009 | Export prerequisite verified; API/UI remains unexposed | diff --git a/docs/verification/mail-001-job-email-hub.md b/docs/verification/mail-001-job-email-hub.md index 04f9ed1..339ce3a 100644 --- a/docs/verification/mail-001-job-email-hub.md +++ b/docs/verification/mail-001-job-email-hub.md @@ -2,7 +2,7 @@ Updated: 2026-08-10 -Status: `IN PROGRESS`. Canonical hub routing, provider-neutral reads, explicit-confirmed send API, editable reply UI, interrupted-send recovery, legacy SMTP retirement, send-attempt export coverage, shared application context and inert tenant-owned draft persistence are implemented and locally verified; remaining draft API/UI, provider actions and full account-deletion lifecycle remain. +Status: `IN PROGRESS`. Canonical hub routing, provider-neutral reads, explicit-confirmed send API, editable reply UI, interrupted-send recovery, legacy SMTP retirement, send-attempt/draft export coverage, shared application context and inert tenant-owned draft persistence are implemented and locally verified; remaining draft API/UI, provider actions and full account-deletion lifecycle remain. ## Revalidated current boundaries @@ -144,12 +144,19 @@ Status: `IN PROGRESS`. Canonical hub routing, provider-neutral reads, explicit-c - No route, UI, provider call, token or content log was added. Export coverage and the complete SEC-009 deletion lifecycle remain prerequisites before private draft content becomes reachable. - A disposable full migration-chain SQLite rehearsal is blocked in the older `AddJobEntityAndProspectStages` migration because it references `LastReminderEmailSentAt` before any migration creates it. The failure occurs before `AddEmailDrafts` and remains tracked as JT-019 schema-chain debt. +## Implemented readable draft export coverage + +- Authenticated encrypted backups and the existing per-owner daily JSON export now include one explicit readable draft shape: job/provider/recipient/subject/plain body/thread/revision/timestamps. +- Both paths query through the owner filter and restrict drafts to the already exported owned job IDs. Synthetic two-owner tests prove the on-demand backup excludes another tenant and each hashed daily file contains only its matching owner's content. +- Focused export tests pass 4/4 and the full backend remains 625/625. No new public route, log, provider call or browser storage was added. +- Daily files inherit the existing export-folder protection and retention boundary. Complete live/export/backup deletion and retention remain SEC-009 work, not an implied guarantee from MAIL-001. + ## Remaining MAIL-001 work - Extend shared provider-neutral thread navigation while preserving provider capability differences; application context and Gmail unlink are now shared. - Add read/unread, pin/read-later/archive/spam/trash only where the provider supports it; identity, disconnected/read-only/send-capable and provider-status failure states are now explicit. - Share thread detail and link/unlink actions between hub and job workspace. -- Add a bounded owner/job-validating draft API, readable export coverage, refresh recovery and compose-new-message behavior on top of the inert persistence model; replies are implemented. +- Add a bounded owner/job-validating draft API, refresh recovery and compose-new-message behavior on top of the persistence/export model; replies are implemented. - Complete account deletion coverage under SEC-009 before production rollout; job-level hard-delete cascade and export coverage are verified. - Preserve minimal audit metadata without sensitive body logging. Free non-AI access is verified; future AI assistance remains a Pro/privacy-gated addition, not a prerequisite for basic email. - Complete remaining link/unlink/dismiss/draft/send/failure/two-user browser/production provider gates. Shared application-context behavior is now covered locally. No real email may be sent during repository verification. diff --git a/docs/work-programmes/decisions.md b/docs/work-programmes/decisions.md index f6f0dfb..cedddaa 100644 --- a/docs/work-programmes/decisions.md +++ b/docs/work-programmes/decisions.md @@ -539,3 +539,13 @@ - **Consequences:** migration `20260810075206_AddEmailDrafts` is additive and reversible, but production must not expose drafts until export/deletion coverage and a bounded owner/job-validating API are verified. A full blank SQLite migration rehearsal remains blocked by the pre-existing JT-019 historical-chain defect, not this migration. - **User approval required:** No; MAIL-001 authorizes repository-local durable drafts and no production migration/provider action occurred. - **Reversible:** Downgrade the migration before reverting `14b396a`. No reachable application behavior exists in this increment. + +## DEC-055 — Export drafts through existing owner-scoped backup boundaries + +- **Date:** 2026-08-10 +- **Decision:** Include complete readable email drafts in the authenticated encrypted backup and per-owner daily export, using an explicit DTO and the owning job ID set. Do not add a separate export route. +- **Reason/evidence:** private draft data must be portable before it is user-reachable. Existing exports already own tenant isolation and readable user data; focused two-owner tests prove the on-demand payload and hashed daily files contain only their owner's draft. +- **Alternatives considered:** omit bodies; export only metadata; add a draft-only download; delay export until account deletion. These produce an incomplete user export, duplicate authorization or expose a reachable data category without portability. +- **Consequences:** daily JSON exports now contain draft bodies under the same filesystem-at-rest protections and retention policy as correspondence. SEC-009 must explicitly delete live drafts and define backup/export retention; no export schema version was broken because the collection is additive. +- **User approval required:** No; this is a repository-local privacy prerequisite using synthetic data and existing export authority. +- **Reversible:** Revert `2fa4e38`; stored drafts remain unchanged, but draft UI/API must not ship without another readable export path. diff --git a/docs/work-programmes/master-progress.md b/docs/work-programmes/master-progress.md index a8df7f7..a9b4271 100644 --- a/docs/work-programmes/master-progress.md +++ b/docs/work-programmes/master-progress.md @@ -2,8 +2,8 @@ Updated: 2026-08-10 -- **Overall programme status:** Active. Seven packages are locally verified; nineteen packages through CAREER-002 are implemented with automated/runtime evidence but blocked from applicable browser/provider/production gates; MAIL-001 is in progress with fifteen committed implementation/test increments. Gitea run 609 passes complete pull-request CI in 4m20s; DEP-001 now awaits approved merge-to-main and production verification only. -- **Current work package:** `MAIL-001` — consolidated job-email hub and explicit sending (`IN PROGRESS`); routing/reads/detail, ledger, Gmail/Graph delivery/re-consent, safe send API/UI, recovery, legacy SMTP retirement, content-free send export and inert tenant-owned draft persistence are committed. Application context, confirmed Gmail unlink and honest disconnected/read-only/send/failure states are shared. Readable draft export/API/UI and provider mailbox mutations remain; full account deletion stays SEC-009. +- **Overall programme status:** Active. Seven packages are locally verified; nineteen packages through CAREER-002 are implemented with automated/runtime evidence but blocked from applicable browser/provider/production gates; MAIL-001 is in progress with sixteen committed implementation/test increments. Gitea run 609 passes complete pull-request CI in 4m20s; DEP-001 now awaits approved merge-to-main and production verification only. +- **Current work package:** `MAIL-001` — consolidated job-email hub and explicit sending (`IN PROGRESS`); routing/reads/detail, ledger, Gmail/Graph delivery/re-consent, safe send API/UI, recovery, legacy SMTP retirement, send/draft export and inert tenant-owned draft persistence are committed. Application context, confirmed Gmail unlink and honest disconnected/read-only/send/failure states are shared. Bounded draft API/UI and provider mailbox mutations remain; full account deletion stays SEC-009. - **Completed work packages:** None are `DONE`; all repository security/AI packages still have applicable browser, provider and/or production gates. - **Locally verified work:** SEC-001, SEC-002, SEC-003, SEC-005A, CORE-001, PROD-002 and DEP-001 (`VERIFIED LOCALLY`). - **Implemented, verification incomplete:** SEC-004, SEC-005B, SEC-008, CORE-002, BG-001, OPS-001A/B/C, POL-001/002, AI-001/002/003/004, UX-001/002, QA-001, CAREER-001 and CAREER-002 (`IMPLEMENTED — NOT VERIFIED`). CAREER-002 now protects unsaved edits and provides tested structured custom-entry, profile-override and preview-error interactions; all automated/build gates pass. @@ -12,7 +12,7 @@ Updated: 2026-08-10 - **Deferred work:** None. Conditional multi-replica coordination, model deletion, realtime operation delivery and unrelated production changes remain outside current packages. - **Next five work packages:** MAIL-001 consolidated email experience; JOBS-001 job-search/application redesign; HOME-001 homepage/Pro promotion; UX-003 authentication/profile polish; PRODUCT-001 homepage/Pro claims. SEC-006/007 resume after package-index permission. - **Status counts:** 7 `VERIFIED LOCALLY`; 19 `IMPLEMENTED — NOT VERIFIED`; 1 `IN PROGRESS`; 8 `NOT STARTED`; 5 `BLOCKED`; 0 `DONE`; 0 `DEFERRED`. -- **Test status:** backend 625/625; frontend 50/50 suites and 194/194 tests; Playwright smoke 4/4; npm audit 0 vulnerabilities; DEP-001 focused router 24/24 and production build pass; MAIL-001 draft persistence 1/1, Free send 7/7, provider states 9/9, hub unlink 8/8 UI and 2/2 API, shared context 10/10, export/cascade 16/16, recovery/send 10/10, legacy follow-up/backend worker 10/10, legacy UI 2/2, composer 7/7, delivery/capability 18/18, provider/correspondence 5/5 and hub detail 5/5. EF model-current and SQLite/MariaDB up/down draft scripts pass; a full blank-chain SQLite apply remains blocked by pre-existing JT-019 drift. Jest open-handle/slow-run behavior is recorded in V-127/V-128/V-130/V-131/V-135/V-142/V-143/V-144. +- **Test status:** backend 625/625; frontend 50/50 suites and 194/194 tests; Playwright smoke 4/4; npm audit 0 vulnerabilities; DEP-001 focused router 24/24 and production build pass; MAIL-001 readable draft export 4/4, draft persistence 1/1, Free send 7/7, provider states 9/9, hub unlink 8/8 UI and 2/2 API, shared context 10/10, prior send export/cascade 16/16, recovery/send 10/10, legacy follow-up/backend worker 10/10, legacy UI 2/2, composer 7/7, delivery/capability 18/18, provider/correspondence 5/5 and hub detail 5/5. EF model-current and SQLite/MariaDB up/down draft scripts pass; a full blank-chain SQLite apply remains blocked by pre-existing JT-019 drift. Jest open-handle/slow-run behavior is recorded in V-127/V-128/V-130/V-131/V-135/V-142/V-143/V-144. - **Deployment status:** Gitea pull-request run 609 passed the complete CI job in 4m20s. Deploy was intentionally skipped because the workflow deploys only a `push` to `main`; live remains unchanged. No merge/deployment was performed directly, no production migrations were run and the AI operation worker remains disabled by default. - **Production status:** Unchanged and unverified. No provider/model call, model pull, external request or paid API occurred. - **Known regressions:** None found by automated/local browser checks. Jest still needs `--forceExit` and reports its existing open-handle notice. Email-provider/send tests are fake/local only; real delivery is not claimed. Current MAIL browser evidence is 1280×720 only because the browser surface could not resize or perform native Tab traversal. Interrupted attempts are aged after 15 minutes and notified without retry; the five-minute scan is unmeasured on a large ledger. Direct clean EF-only SQLite migration still hits the pre-existing historical blank-chain defect before later migrations; normal startup owns reconciliation. Cross-feature monthly AI usage accounting remains a rollout gap. diff --git a/docs/work-programmes/master-work-plan.md b/docs/work-programmes/master-work-plan.md index 0c09999..0bc67e7 100644 --- a/docs/work-programmes/master-work-plan.md +++ b/docs/work-programmes/master-work-plan.md @@ -651,9 +651,9 @@ Ordering differences from the suggested list: - **Required production verification:** provider read/draft/send requires explicit authorized synthetic account; never real unsolicited email. - **Status:** `IN PROGRESS`. - **Blocker:** real provider verification is external; required 375/768/1440/theme/keyboard browser gates were unavailable in the current browser surface. Mocked/local repository implementation remains unblocked. -- **Evidence:** `docs/verification/mail-001-job-email-hub.md`; V-126–V-146. Durable draft persistence 1/1 with dual-provider reversible SQL; Free send policy 7/7; provider states 9/9; hub unlink 8/8 UI and 2/2 API; shared application context focused 10/10; export/cascade focused 16/16; recovery/send focused 10/10; legacy follow-up/worker 10/10; composer 7/7; delivery/capability 18/18; provider/correspondence 5/5; hub detail 5/5; backend 625/625; frontend 50/50 suites and 194/194 tests plus build/audit; local empty/disconnected and compatibility-route browser smoke at 1280×720. -- **Commit:** `6008b4a` (hub), `536d403` (neutral reads), `a20775c` (safe detail), `653f011` (ledger), `e9937ac` (Gmail/Graph delivery adapters and consent), `123fc55` (explicit-confirmed send API), `449faeb` (confirmed reply composer), `ee5ef7e` (interrupted-send recovery), `8fe3903` (legacy SMTP retirement), `aff34cc` (content-free export and cascade evidence), `ff547df` (shared application context), `1dabbeb` (confirmed hub unlink), `f9e641c` (honest provider states), `7f41cb2` (Free email policy regression), `14b396a` (inert tenant draft persistence). -- **Remaining work:** full account deletion remains SEC-009; readable draft export plus bounded draft API/new-message/refresh UI; mailbox category capabilities; browser/production verification. Existing connections need explicit re-consent; IMAP remains read-only. No real email; uncertain sends need manual reconciliation. JT-019 blocks a clean full-chain SQLite rehearsal before the new draft migration. +- **Evidence:** `docs/verification/mail-001-job-email-hub.md`; V-126–V-147. Durable draft persistence 1/1 with dual-provider reversible SQL and readable export 4/4; Free send policy 7/7; provider states 9/9; hub unlink 8/8 UI and 2/2 API; shared application context focused 10/10; prior send export/cascade focused 16/16; recovery/send focused 10/10; legacy follow-up/worker 10/10; composer 7/7; delivery/capability 18/18; provider/correspondence 5/5; hub detail 5/5; backend 625/625; frontend 50/50 suites and 194/194 tests plus build/audit; local empty/disconnected and compatibility-route browser smoke at 1280×720. +- **Commit:** `6008b4a` (hub), `536d403` (neutral reads), `a20775c` (safe detail), `653f011` (ledger), `e9937ac` (Gmail/Graph delivery adapters and consent), `123fc55` (explicit-confirmed send API), `449faeb` (confirmed reply composer), `ee5ef7e` (interrupted-send recovery), `8fe3903` (legacy SMTP retirement), `aff34cc` (content-free export and cascade evidence), `ff547df` (shared application context), `1dabbeb` (confirmed hub unlink), `f9e641c` (honest provider states), `7f41cb2` (Free email policy regression), `14b396a` (inert tenant draft persistence), `2fa4e38` (owner-isolated readable draft export). +- **Remaining work:** full account deletion remains SEC-009; bounded draft API/new-message/refresh UI; mailbox category capabilities; browser/production verification. Existing connections need explicit re-consent; IMAP remains read-only. No real email; uncertain sends need manual reconciliation. JT-019 blocks a clean full-chain SQLite rehearsal before the new draft migration. ### JOBS-001 — Job-search source and assessment redesign diff --git a/docs/work-programmes/session-handoff.md b/docs/work-programmes/session-handoff.md index b1ba059..d8efe59 100644 --- a/docs/work-programmes/session-handoff.md +++ b/docs/work-programmes/session-handoff.md @@ -2,17 +2,17 @@ Updated: 2026-08-10 -- **Exact current task:** MAIL-001 — add readable owner-isolated draft export coverage before exposing the new private draft store through an API or UI. -- **Last completed step:** inert tenant-owned draft persistence and its reversible SQLite/MariaDB migration were committed/pushed as `14b396a`; two-owner SQLite isolation/cascade and backend 625/625 pass. -- **Files currently modified:** authoritative MAIL-001 tracking/evidence only; application persistence is committed. +- **Exact current task:** MAIL-001 — design and implement the bounded authenticated draft API over the now-exportable tenant-owned store; do not wire UI until API isolation/concurrency tests pass. +- **Last completed step:** complete readable draft coverage for encrypted on-demand and hashed per-owner daily exports was committed/pushed as `2fa4e38`; focused 4/4 and backend 625/625 pass. +- **Files currently modified:** authoritative MAIL-001 tracking/evidence only; persistence/export code is committed. - **Commands already run:** dependency/audit/router/full frontend/build; legacy follow-up/export/recovery/provider suites; full backend; Gitea run inspection; Playwright; MAIL context/unlink/provider-state/Free-policy/draft-persistence focused and full suites/build; EF model-current and dual-provider up/down scripts. See V-126–V-146. - **Test results:** npm audit 0 vulnerabilities; Gitea pull-request CI PASS in 4m20s at run 609; backend 625/625; frontend 50/50 suites and 194/194 tests; Playwright 4/4; production build passes. Draft isolation/cascade 1/1; EF model current; SQLite/MariaDB draft up/down scripts pass. Full blank-chain SQLite apply fails earlier in `AddJobEntityAndProspectStages` on missing `LastReminderEmailSentAt` (JT-019). - **Services currently running:** none on task-owned ports 3000/5202. Playwright stopped its disposable API/Next servers. Pre-existing Docker services were not changed. - **Temporary files or processes:** no task-owned process is running and the failed disposable migration database was removed. Existing synthetic browser evidence/account and startup-created local backup remain documented. No provider account, real email, private content, paid service or production service was accessed. - **Production changes currently active:** none. No deployment, migration, provider connection/sync/send or production payload occurred. - **Rollback status:** downgrade `20260810075206_AddEmailDrafts` before reverting `14b396a`; then follow the existing MAIL rollback order (`ee5ef7e`, `449faeb`, `123fc55`/`e9937ac`, ledger downgrade before `653f011`). No production migration/deploy/provider grant occurred. -- **Uncommitted changes:** tracking/evidence for `14b396a` and V-146 only; commit and push before the export increment. +- **Uncommitted changes:** tracking/evidence for `2fa4e38` and V-147 only; commit and push before the draft API increment. - **Known failures:** live deployment is not verified because PR deploy is intentionally skipped and the active branch is not approved for merge. Draft export/API/UI, full thread/category actions and non-Gmail review remain; existing accounts need re-consent and IMAP stays read-only. A clean full-chain SQLite apply fails in the pre-existing JT-019 migration before the new draft migration. Browser/provider/MariaDB/production unavailable or unverified; recovery scan performance is unmeasured at large ledger scale; Jest open handles; SEC-006 parser dependency work is still separately gated; parser isolation remains SEC-007. -- **Exact next action:** add explicit readable `EmailDraft` coverage to encrypted on-demand and tenant daily exports with two-owner tests; only then design the bounded draft API. Keep content out of logs, notifications and browser storage. +- **Exact next action:** add authenticated list/get/create/update/delete draft endpoints with owned-job validation, bounded plain-text fields, revision conflict handling and two-user direct-ID tests. Keep content out of logs, notifications and browser storage; no provider call or send occurs on save. - **Work that can continue independently:** remaining MAIL-001 repository work and later UX packages. SEC-006/007 await package-index permission; PROD-001/003/004 await production access. - **Decisions still required from the user:** none for synthetic/code-inspected repository work. Any provider connection or send test, internet/package upgrades, private data, external/paid providers and production actions retain explicit approval/safety gates; SEC-009 retention/legal policy remains unresolved.