feat: complete release readiness work #28

Open
cesnimda wants to merge 110 commits from release-readiness into main
6 changed files with 20 additions and 7 deletions
Showing only changes of commit 050b99ca36 - Show all commits
+1
View File
@@ -180,3 +180,4 @@ Output was reduced to filenames and commit counts. The token artifact appears un
| V-146 | `EmailDraftPersistenceTests`; full backend; backend build; `dotnet ef migrations has-pending-model-changes`; SQLite/MariaDB up/down script generation; disposable full-chain SQLite migration rehearsal; staged diff review | Repository root | Verify an inert owner-filtered email-draft persistence boundary, job lifecycle, additive dual-provider migration and rollback | PASS/PARTIAL — two-owner real-SQLite isolation/cascade passes; backend 625/625; build has 0 warnings/errors; model current; SQLite and MariaDB up/down SQL are bounded and reversible; `14b396a` pushed | Full-chain disposable SQLite apply is blocked before the new migration by pre-existing `AddJobEntityAndProspectStages` blank-chain drift (`LastReminderEmailSentAt` is referenced before creation); MariaDB SQL generated but not executed; no API/UI/provider/content logging added | Draft persistence verified; historical migration blocker remains JT-019 |
| V-147 | Focused `BackupControllerTests|BackgroundWorkerTenantTests.Daily_export_writes_one_isolated_atomic_file_per_owner`; full backend; staged diff review | Repository root | Verify readable private draft coverage through existing owner-isolated export boundaries | PASS — focused 4/4 and backend 625/625; encrypted on-demand export includes User A's complete draft and excludes User B; daily export writes exactly one matching draft per hashed owner file; `2fa4e38` pushed | Synthetic content and local stores only; daily exports inherit the existing plaintext-at-rest export-folder boundary; complete account deletion/backup retention remains SEC-009 | Export prerequisite verified; API/UI remains unexposed |
| V-148 | Focused `EmailDraftsControllerTests`; full backend; backend build; staged diff review | Repository root | Verify bounded authenticated draft CRUD, owner/job isolation and optimistic revision conflicts without provider side effects | PASS — focused 4/4; backend 629/629; build 0 warnings/errors; incomplete autosave, validation, unknown provider, foreign job/direct ID/update/delete denial, stale update/delete conflicts and owned delete pass on real SQLite; `a9bb22e` pushed | Synthetic content/local database only; no UI/browser/provider/send/production action | API boundary verified; UI recovery remains |
| V-149 | Focused draft API/export/persistence tests; full backend; EF model-current; SQLite/MariaDB up/down migration scripts; staged diff review | Repository root | Prevent refresh-restored drafts from receiving a new delivery identity | PASS — focused 9/9, backend 629/629 and model-current pass; creation assigns a canonical UUID, edits preserve it, exports include it, all-owner list remains tenant-filtered, and reversible provider SQL is generated; `80b5532` pushed | MariaDB SQL generated only; historical JT-019 still blocks full blank SQLite chain; no UI/provider/send/production action | UI safety prerequisite verified |
@@ -158,6 +158,8 @@ Status: `IN PROGRESS`. Canonical hub routing, provider-neutral reads, explicit-c
- Updates and deletes require the caller's current revision and execute atomically; stale writes return a reload conflict rather than silently overwriting newer content.
- Real-SQLite tests cover foreign job creation, direct foreign IDs, foreign list/update/delete attempts, stale updates/deletes and preservation of the other tenant. Focused 4/4, backend 629/629 and build pass.
- Saving a draft never calls a provider or send path. Delivery still requires the separate connected/send-capable, explicit-confirmed, idempotent API.
- Every created draft now owns a canonical client-request UUID that survives edits and refresh and is included in the user export. This prevents a restored draft from silently obtaining a fresh ledger identity and bypassing duplicate-send protection.
- The API can list all drafts for the authenticated owner to support refresh recovery; foreign drafts remain absent under both explicit owner predicates and the global filter.
## Remaining MAIL-001 work
+10
View File
@@ -559,3 +559,13 @@
- **Consequences:** saving never sends or checks connection state. Send still uses the separate explicit-confirmed/idempotent boundary and revalidates all fields/provider consent. UI must surface revision conflicts and treat bodies as untrusted plain text.
- **User approval required:** No; this is approved local MAIL-001 work with synthetic data and no provider/production action.
- **Reversible:** Revert `a9bb22e`; the inert/exported schema remains for a later UI. Existing stored drafts are unaffected.
## DEC-057 — Persist one delivery identity for the life of a draft
- **Date:** 2026-08-10
- **Decision:** Assign every server draft one canonical client-request UUID, preserve it across edits/refresh, include it in readable exports, and allow listing all current-owner drafts for recovery.
- **Reason/evidence:** the send ledger keys idempotency by client request ID. Generating a new UUID after refresh would let identical restored content reserve a second delivery attempt. Focused tests prove creation, edit preservation, export and tenant-filtered all-draft listing.
- **Alternatives considered:** generate UUID only at send; regenerate after every edit/refresh; derive it from content; store it only in browser memory. These permit duplicate delivery after refresh, conflate content changes with attempt identity or lose the safety state on navigation.
- **Consequences:** one draft maps to one send attempt identity until the user explicitly starts a new attempt after a confirmed failure. A sent/restored draft can only replay the existing ledger result. The additive migration defaults only during the same pre-exposure rollout; no draft UI existed before it.
- **User approval required:** No; this closes a local safety dependency before UI exposure and sends no email.
- **Reversible:** Downgrade `20260810080858_AddEmailDraftClientRequestId` before reverting `80b5532`. Do not deploy draft UI without an equivalent persisted idempotency identity.
+2 -2
View File
@@ -2,8 +2,8 @@
Updated: 2026-08-10
- **Overall programme status:** Active. Seven packages are locally verified; nineteen packages through CAREER-002 are implemented with automated/runtime evidence but blocked from applicable browser/provider/production gates; MAIL-001 is in progress with seventeen committed implementation/test increments. Gitea run 609 passes complete pull-request CI in 4m20s; DEP-001 now awaits approved merge-to-main and production verification only.
- **Current work package:** `MAIL-001` — consolidated job-email hub and explicit sending (`IN PROGRESS`); routing/reads/detail, ledger, Gmail/Graph delivery/re-consent, safe send API/UI, recovery, legacy SMTP retirement, send/draft export and tenant-owned revisioned draft API are committed. Application context, confirmed Gmail unlink and honest disconnected/read-only/send/failure states are shared. Draft recovery/new-message UI and provider mailbox mutations remain; full account deletion stays SEC-009.
- **Overall programme status:** Active. Seven packages are locally verified; nineteen packages through CAREER-002 are implemented with automated/runtime evidence but blocked from applicable browser/provider/production gates; MAIL-001 is in progress with eighteen committed implementation/test increments. Gitea run 609 passes complete pull-request CI in 4m20s; DEP-001 now awaits approved merge-to-main and production verification only.
- **Current work package:** `MAIL-001` — consolidated job-email hub and explicit sending (`IN PROGRESS`); routing/reads/detail, ledger, Gmail/Graph delivery/re-consent, safe send API/UI, recovery, legacy SMTP retirement, send/draft export and tenant-owned revisioned draft API/idempotency identity are committed. Application context, confirmed Gmail unlink and honest disconnected/read-only/send/failure states are shared. Draft recovery/new-message UI and provider mailbox mutations remain; full account deletion stays SEC-009.
- **Completed work packages:** None are `DONE`; all repository security/AI packages still have applicable browser, provider and/or production gates.
- **Locally verified work:** SEC-001, SEC-002, SEC-003, SEC-005A, CORE-001, PROD-002 and DEP-001 (`VERIFIED LOCALLY`).
- **Implemented, verification incomplete:** SEC-004, SEC-005B, SEC-008, CORE-002, BG-001, OPS-001A/B/C, POL-001/002, AI-001/002/003/004, UX-001/002, QA-001, CAREER-001 and CAREER-002 (`IMPLEMENTED — NOT VERIFIED`). CAREER-002 now protects unsaved edits and provides tested structured custom-entry, profile-override and preview-error interactions; all automated/build gates pass.
+2 -2
View File
@@ -651,8 +651,8 @@ Ordering differences from the suggested list:
- **Required production verification:** provider read/draft/send requires explicit authorized synthetic account; never real unsolicited email.
- **Status:** `IN PROGRESS`.
- **Blocker:** real provider verification is external; required 375/768/1440/theme/keyboard browser gates were unavailable in the current browser surface. Mocked/local repository implementation remains unblocked.
- **Evidence:** `docs/verification/mail-001-job-email-hub.md`; V-126V-148. Draft API 4/4, persistence 1/1 with dual-provider reversible SQL and readable export 4/4; Free send policy 7/7; provider states 9/9; hub unlink 8/8 UI and 2/2 API; shared application context focused 10/10; prior send export/cascade focused 16/16; recovery/send focused 10/10; legacy follow-up/worker 10/10; composer 7/7; delivery/capability 18/18; provider/correspondence 5/5; hub detail 5/5; backend 629/629; frontend 50/50 suites and 194/194 tests plus build/audit; local empty/disconnected and compatibility-route browser smoke at 1280×720.
- **Commit:** `6008b4a` (hub), `536d403` (neutral reads), `a20775c` (safe detail), `653f011` (ledger), `e9937ac` (Gmail/Graph delivery adapters and consent), `123fc55` (explicit-confirmed send API), `449faeb` (confirmed reply composer), `ee5ef7e` (interrupted-send recovery), `8fe3903` (legacy SMTP retirement), `aff34cc` (content-free export and cascade evidence), `ff547df` (shared application context), `1dabbeb` (confirmed hub unlink), `f9e641c` (honest provider states), `7f41cb2` (Free email policy regression), `14b396a` (inert tenant draft persistence), `2fa4e38` (owner-isolated readable draft export), `a9bb22e` (tenant-safe revisioned draft API).
- **Evidence:** `docs/verification/mail-001-job-email-hub.md`; V-126V-149. Draft API/idempotency 9/9, persistence 1/1 with dual-provider reversible SQL and readable export 4/4; Free send policy 7/7; provider states 9/9; hub unlink 8/8 UI and 2/2 API; shared application context focused 10/10; prior send export/cascade focused 16/16; recovery/send focused 10/10; legacy follow-up/worker 10/10; composer 7/7; delivery/capability 18/18; provider/correspondence 5/5; hub detail 5/5; backend 629/629; frontend 50/50 suites and 194/194 tests plus build/audit; local empty/disconnected and compatibility-route browser smoke at 1280×720.
- **Commit:** `6008b4a` (hub), `536d403` (neutral reads), `a20775c` (safe detail), `653f011` (ledger), `e9937ac` (Gmail/Graph delivery adapters and consent), `123fc55` (explicit-confirmed send API), `449faeb` (confirmed reply composer), `ee5ef7e` (interrupted-send recovery), `8fe3903` (legacy SMTP retirement), `aff34cc` (content-free export and cascade evidence), `ff547df` (shared application context), `1dabbeb` (confirmed hub unlink), `f9e641c` (honest provider states), `7f41cb2` (Free email policy regression), `14b396a` (inert tenant draft persistence), `2fa4e38` (owner-isolated readable draft export), `a9bb22e` (tenant-safe revisioned draft API), `80b5532` (persisted draft send identity).
- **Remaining work:** full account deletion remains SEC-009; new-message/refresh draft UI; mailbox category capabilities; browser/production verification. Existing connections need explicit re-consent; IMAP remains read-only. No real email; uncertain sends need manual reconciliation. JT-019 blocks a clean full-chain SQLite rehearsal before the new draft migration.
### JOBS-001 — Job-search source and assessment redesign
+3 -3
View File
@@ -3,15 +3,15 @@
Updated: 2026-08-10
- **Exact current task:** MAIL-001 — connect reply/new-message UI to revisioned server drafts with refresh recovery and explicit conflict handling; preserve the existing send confirmation boundary.
- **Last completed step:** bounded authenticated draft CRUD was committed/pushed as `a9bb22e`; focused real-SQLite 4/4, backend 629/629 and build pass with no provider/send side effects.
- **Last completed step:** persisted draft client-request identity and tenant-filtered all-draft recovery listing were committed/pushed as `80b5532`; focused 9/9, backend 629/629, EF model-current and dual-provider up/down scripts pass.
- **Files currently modified:** authoritative MAIL-001 tracking/evidence only; persistence/export/API code is committed.
- **Commands already run:** dependency/audit/router/full frontend/build; legacy follow-up/export/recovery/provider suites; full backend; Gitea run inspection; Playwright; MAIL context/unlink/provider-state/Free-policy/draft-persistence focused and full suites/build; EF model-current and dual-provider up/down scripts. See V-126V-146.
- **Test results:** npm audit 0 vulnerabilities; Gitea pull-request CI PASS in 4m20s at run 609; backend 625/625; frontend 50/50 suites and 194/194 tests; Playwright 4/4; production build passes. Draft isolation/cascade 1/1; EF model current; SQLite/MariaDB draft up/down scripts pass. Full blank-chain SQLite apply fails earlier in `AddJobEntityAndProspectStages` on missing `LastReminderEmailSentAt` (JT-019).
- **Services currently running:** none on task-owned ports 3000/5202. Playwright stopped its disposable API/Next servers. Pre-existing Docker services were not changed.
- **Temporary files or processes:** no task-owned process is running and the failed disposable migration database was removed. Existing synthetic browser evidence/account and startup-created local backup remain documented. No provider account, real email, private content, paid service or production service was accessed.
- **Production changes currently active:** none. No deployment, migration, provider connection/sync/send or production payload occurred.
- **Rollback status:** downgrade `20260810075206_AddEmailDrafts` before reverting `14b396a`; then follow the existing MAIL rollback order (`ee5ef7e`, `449faeb`, `123fc55`/`e9937ac`, ledger downgrade before `653f011`). No production migration/deploy/provider grant occurred.
- **Uncommitted changes:** tracking/evidence for `a9bb22e` and V-148 only; commit and push before the draft UI increment.
- **Rollback status:** downgrade `20260810080858_AddEmailDraftClientRequestId`, then `20260810075206_AddEmailDrafts`, before reverting draft commits; then follow the existing MAIL rollback order (`ee5ef7e`, `449faeb`, `123fc55`/`e9937ac`, ledger downgrade before `653f011`). No production migration/deploy/provider grant occurred.
- **Uncommitted changes:** tracking/evidence for `80b5532` and V-149 only; commit and push before the draft UI increment.
- **Known failures:** live deployment is not verified because PR deploy is intentionally skipped and the active branch is not approved for merge. Draft export/API/UI, full thread/category actions and non-Gmail review remain; existing accounts need re-consent and IMAP stays read-only. A clean full-chain SQLite apply fails in the pre-existing JT-019 migration before the new draft migration. Browser/provider/MariaDB/production unavailable or unverified; recovery scan performance is unmeasured at large ledger scale; Jest open handles; SEC-006 parser dependency work is still separately gated; parser isolation remains SEC-007.
- **Exact next action:** inventory the correspondence composer state and API client, then add explicit Save draft/resume/delete/new-message UI with visible revision conflict/reload. Do not autosave silently until race/navigation behavior is covered; sending must still require the existing confirmation and idempotency UUID.
- **Work that can continue independently:** remaining MAIL-001 repository work and later UX packages. SEC-006/007 await package-index permission; PROD-001/003/004 await production access.