cesnimda
daa9694bc7
Shell (the single auth guard wrapping every protected route under /*)
redirected unauthenticated visitors straight to /login instead of the home
page, contrary to the intended behaviour. Root cause was one line in
App.tsx's Shell render gate.
Everything else in the guard was already correct: a single centralized
check (no per-page duplication), a loading gate that blocks render until
/auth/config + /auth/me resolve (no flicker-redirect), and 401-triggered
re-checks via the axios interceptor + auth-changed event for expired
sessions mid-session.
Fix:
- Shell now redirects to "/" (home) instead of "/login", still passing
state={{ from: path }} so the originally-requested page isn't lost.
- LandingPage forwards that location.state through to /login on every
"Sign in" CTA (6 call sites collapsed into one goToLogin() helper), so
the home-page bounce doesn't drop the deep-link intent — sign-in still
returns the user to the page they wanted instead of dropping them on
the default /jobs.
- Added LandingPage.authRedirect.test.tsx covering the from-state handoff
end to end (Landing -> click Sign in -> /login receives from). Full
suite: 25 suites, 56 tests green.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
50 lines
1.8 KiB
TypeScript
50 lines
1.8 KiB
TypeScript
import React from "react";
|
|
import "@testing-library/jest-dom";
|
|
import { render, screen, waitFor } from "@testing-library/react";
|
|
import userEvent from "@testing-library/user-event";
|
|
import { MemoryRouter, Route, Routes, useLocation } from "react-router-dom";
|
|
import { api } from "./api";
|
|
import LandingPage from "./pages/LandingPage";
|
|
|
|
jest.mock("./api", () => ({
|
|
api: {
|
|
get: jest.fn(),
|
|
post: jest.fn(),
|
|
interceptors: { request: { use: jest.fn() }, response: { use: jest.fn() } },
|
|
},
|
|
}));
|
|
|
|
const mockedApi = api as jest.Mocked<typeof api>;
|
|
|
|
function LoginStub() {
|
|
const location = useLocation() as { state?: { from?: string } };
|
|
return <div>login page, from={location.state?.from ?? "none"}</div>;
|
|
}
|
|
|
|
// Regression check for the auth-guard fix: a protected route bounces an
|
|
// unauthenticated visitor to "/" with `state.from` set to the page they
|
|
// wanted. The home page must forward that state to /login so sign-in
|
|
// returns them to the originally-requested page instead of dropping them
|
|
// on /jobs.
|
|
describe("LandingPage forwards deep-link intent to /login", () => {
|
|
it("preserves location.state.from through the Sign in CTA", async () => {
|
|
mockedApi.get.mockRejectedValueOnce(new Error("401")); // /auth/me: not signed in
|
|
|
|
render(
|
|
<MemoryRouter initialEntries={[{ pathname: "/", state: { from: "/jobs/42" } }]}>
|
|
<Routes>
|
|
<Route path="/" element={<LandingPage />} />
|
|
<Route path="/login" element={<LoginStub />} />
|
|
</Routes>
|
|
</MemoryRouter>,
|
|
);
|
|
|
|
await waitFor(() => expect(mockedApi.get).toHaveBeenCalledWith("/auth/me"));
|
|
|
|
const signInButtons = await screen.findAllByText("Sign in", { selector: "button" });
|
|
await userEvent.click(signInButtons[0]);
|
|
|
|
expect(await screen.findByText("login page, from=/jobs/42")).toBeInTheDocument();
|
|
});
|
|
});
|