cesnimda
6.4 KiB
P6-01 — System consistency and workflow review
Baseline: 3d9341e70f71a3e625f3a2108d366f6644f565d6, codex/ui-redesign-phase4, fetched remote=HEAD and clean checkout. This executes the approved sequence, not a replacement P6-00. Production main remains 27657f31131cd95d42f0e1290853ec9c9b3959a4, NO-GO.
Method and boundary
Review current loaded native SQLite/API/browser workflows, rendered EN/Bokmål and light/dark states, shared owners and existing regressions. Compare function and semantics before appearance. Native collection is automated inspection, not human usability, reader or device acceptance. The inherited 1,033 backend / 498 frontend / 148 browser baseline is separate from fresh checkpoint runs.
The thirteen-area responsive audit exercises authentication, shell, commands, Jobs, Board, Dashboard, Analytics, Job workspace, Career Profile, CV, Documents, Settings and administration. It includes breakpoint transitions, long recorded content, keyboard dialogs/navigation, source route, native file selection, physical preview measurement and emulated orientation/input. The existing route audit covers 32 patterns; no route or capability is removed here. All 57 original contracts remain unchanged; historical P2-D01 expected-failure statements are superseded by its ordinary passing native package case.
Surface and component inventory
| Surface | Current implementation / evidence | Consistency decision |
|---|---|---|
| Shell, navigation, commands | AppShell / QuickCommandDialog; native drawer, route and command journeys | Retain approved hierarchy and existing focus-return architecture |
| Jobs Table / Board | JobsWorkspacePage, JobTable, KanbanBoard; shared query/filter state, saved-search repair, pointer/keyboard movement | Comfortable/Compact affects application density, never CV paper; full-result scaling remains open |
| Dashboard / Analytics | DashboardView variants; exact recorded status links, period/filter native journeys | Shared reporting patterns intentional; no invented metrics or Phase8 customization |
| Job workspace | ApplicationWorkspacePage sections; native route/package/attachment evidence | Retain deeper section ownership and frozen submission semantics |
| CV editor / preview / settings | CvBuilderEditor; PageSection, document settings and verified preview lifecycle | Separate app chrome from physical renderer; keep normal save/undo/revision system |
| Career Profile / CV library | Existing canonical forms and variant list | Remaining full visual migration belongs to Phase7; semantic/contrast defects still require bounded correction |
| Documents / correspondence | Existing retrieval, association, composition and export paths | Do not mistake pending visual migration for lost capabilities |
| Settings / Rules | PageLayout / PageSection; session-owned Rules drafts | Retain save/discard contracts; add missing tab/panel associations separately |
| Auth / admin / remaining dialogs | Existing supported routes and permission controls | Phase7 visual migration remains; basic landmarks, heading hierarchy and modal feedback are current obligations |
Shared authorities are theme.ts, PageLayout, ViewStateNotice/useViewResource, existing toast/confirm/prompt providers and pipeline status definitions. No replacement framework, parallel token system, saving model, navigation model or renderer is justified. Public landing gradients are an intentional existing marketing variation, not evidence of systemic app inconsistency.
Prioritised findings
See findings register. Investigate all 39 inherited all-enabled axe occurrences by their actual root, including the seven drawer name reports. They are not 39 independent bugs and are not waived because ordinary tests pass. Reader/device verification remains missing.
Concrete review targets: profile/avatar contrast, login and application heading semantics, Settings tab associations, settled drawer names, modal save-error discoverability and swallowed language-save failures. Correct them at existing owners with reproduction and regression evidence; do not broaden into full legacy-page migrations. CV cross-document landmark reports require context, not changing the PDF renderer to appease a best-practice scan.
Preservation and remaining acceptance
Relevant contracts: PRES-E02/E06/E07/E08, J05/J07/J08, W01/W08, C06–C12 and S01/S03/S04. Current whole-group acceptance remains 0PASS / 56PARTIAL / 0FAIL / 1DEFERRED =57. Finite native evidence cannot close every sub-workflow or mandatory human check. P5-13 remains deferred, unqualified and Production-withheld; no model calls or AI UI.
Carry forward human reader/device/software keyboard, production font/portrait, preference500 root-cause, Board capacity, historical CV Unsaved, all production ingress/backup/restore/configuration/schema/rollback and other readiness obligations. No production access or mutation is attempted. Subsequent checkpoints provide bounded corrections and fresh final regression; Phase7 implementation is excluded.
Axe root reconciliation
Inherited39occurrences:2contrast (avatar),13heading-order (contextual implicit Typography),1missing-main+1missing-H1+10region (login),5landmark-unique (outer main/name plus separate preview frame),7drawer child command-name (transition sample). Explicit semantic props preserve visual variants; no global variant mapping or print-document change. Settled drawer evidence is required before classification.
Fresh checkpoint evidence and decision
CONDITIONAL GO to P6-02. Fresh native audit10/10, zero skips/retries/flaky/failures; sanitized exact results.45all-enabled scans record36violation-node occurrences: the inherited39 differ only in the transitional drawer sample (4now versus7previously); this variation is not a resolution. Current incompletes331 (294contrast,26prohibited-attribute,7hidden-focus,2attribute-value,2target-size). Historical267retained scans and2367combined incompletes remain evidence, not another fresh run. No human/device acceptance is claimed.
Code-path review was independently divided among three read-only agents; runtime/visual conclusions remain the native evidence boundary. No production application change belongs to this audit unit. Next: bounded feedback repairs and complete task journeys. Commit/push recorded in the chronological checkpoint log.