docs(release): record tar-status false acceptance and bounded fix

This commit is contained in:
cesnimda
2026-11-16 23:04:34 +01:00
parent a516bfb4b3
commit 2fb41a96ce
11 changed files with 125 additions and 0 deletions
@@ -1,5 +1,18 @@
# Recovery implementation review and rehearsal plan
## RR-16 tar failure propagation
16 November 2026. Source `a516bfb4b38468f9bdc222744a02c07bc5b013c3`, after RR-15 on `codex/release-rollback-health`. A valid gzip stream containing a tar database header without its declared body passed verification: tar failed after printing the matching member and the old pipeline returned grep's success. One deterministic local fixture reproduced this false acceptance and next-gate continuation.
The existing container command now writes its listing to the container's private temporary filesystem and checks tar success before matching the exact database basename. Every call already runs in a fresh `docker run --rm` container; no new mount, service, image, permissions or dependency was introduced. The local shim substitutes the container-only listing path into its disposable fixture directory.
- RED: one focused method FAILED. GREEN:22 backup methods PASSED, including the three RR-15 negative names, three valid names and truncated-tar case. Earlier21/19 methods overlap22.
- Native Bash syntax receipt records exit0 and current source hash; whitespace check passed. AST refresh passed18,554 nodes/46,015 edges.
- Real local GNU tar/gzip were exercised, with Docker and later deployment gates mocked. Actual Alpine/BusyBox image execution, filesystem permissions, usable SQLite contents, regular-file/link safety, path-name ambiguity, database/files/key consistency, encryption and restore remain unqualified. No full deployment script, Docker service, database or remote backup was executed.
- The fix stays on the isolated release branch; A3 integration, isolated recovery and final release approval remain open. Previous rollback6 is historical and was not rerun for this unchanged handler.
Source/native/canonical evidence: [backup-tar-status/SOURCE_RECEIPTS.json](evidence/backup-tar-status/SOURCE_RECEIPTS.json).
## RR-15 SQLite archive member check
16 November 2026. Bounded source `4c6c22074a9a097412f63d0d25399d5d1a20424f`, branch `codex/release-rollback-health`, based on `4019569a`. Existing SQLite archive validation accepted any listing containing the substring `jobtracker.db`. Real synthetic gzip/tar archives containing only `jobtracker.db-wal`, `old-jobtracker.db` or `jobtracker.db.backup` each passed format verification and reached the next mocked deploy gate.
@@ -19,5 +19,6 @@ Discovery only, 2026-11-02. These are qualification gaps unless a concrete defec
| RR-13 | Off-host encryption and recovery-set consistency need independent proof. Failed transfer, partial monthly copy and retention errors previously let deployment continue | Transfer/marker gates and explicit daily prune, monthly enumeration/sort and removal failure propagation FIXED AND OFFLINE-TESTED. Retention suite16/16 preceded permission protection follow-up1c8761b1; final backup suite19/19 methods. Four retention failure assertions and two permission failure subtests reproduced first. See [retention follow-up](11_BACKUP_RESTORE_ROLLBACK.md#rr-13-retention-failure-propagation). See also [permission follow-up](11_BACKUP_RESTORE_ROLLBACK.md#rr-13-backup-permission-gate). Actual encryption, retrieval/decryption and database/files/key/tombstone consistency require approved isolation |
| RR-14 | July first-deploy runbook inferred rollback safety from its no-op migration baseline, while current migration Up methods add schema | Historical scope and current qualification links clarified. `AddJobRevision` adds Version and `AddUserOperationEvents` creates a table/indexes. Exact old/new image compatibility after migration/writes remains an isolated rehearsal gate |
| RR-15 | SQLite backup listing accepted a WAL or similarly named file without the database member | FIXED AND OFFLINE-TESTED at `4c6c2207`: exact member basename required; three false-positive archives reproduced first,21 backup methods/syntax passed. [Bounded evidence](11_BACKUP_RESTORE_ROLLBACK.md#rr-15-sqlite-archive-member-check). Real SQLite contents, regular-file/link safety, tar errors, restore and recovery-set consistency remain unqualified |
| RR-16 | Tar failure was hidden by a matching member's successful grep | FIXED AND OFFLINE-TESTED at `a516bfb4`: valid gzip/truncated tar reproduced false acceptance; tar listing must succeed before matching.22 backup methods/syntax passed; [bounded evidence](11_BACKUP_RESTORE_ROLLBACK.md#rr-16-tar-failure-propagation). Real target-image/restore/security qualification remains open |
Continue evidence work against the [source endpoint and environment census](03_ENDPOINT_ENVIRONMENT_CENSUS.md). Actual qualification requires an accepted candidate and isolated environment. Every fix needs minimal scope, targeted verification and the applicable stage approval.
@@ -0,0 +1,39 @@
{
"sourceCommit": "a516bfb4b38468f9bdc222744a02c07bc5b013c3",
"sourcesLfSha256": {
"deploy/deploy.sh": "2c743f45bc658a4aca225e43d5db0a572f64d547a7f59d0e176d4900cc3b1e6b",
"scripts/test-deploy-backup.py": "1a5171c66ce0c6e84bdd977e3243e11b388cbcadcea90558196339e802335e2d"
},
"evidenceLfSha256": {
"backup-tar-red.txt": "c8c2379521732202468215731471a4e2f95ebd529bb221055842c95c4eb4ec4f",
"backup-tar-green.txt": "13f0827655aaeec58d9813221c77662bb5a40e09ec06a89531acb2bef2ff6807",
"backup-tar-syntax.json": "cd7b504df0752e308efcb533f4dc66a8ade8a8f473e9e3caf3ca19885bfa0d00",
"backup-tar-graph.txt": "c82670cc55f5e0913895e41c1cebe63be6a38e176722979e918e38bf998c0181"
},
"nativeReceipts": [
{
"path": "backup-tar-red.txt",
"gzipPath": "backup-tar-red.txt.gz",
"rawSha256": "03855b0190e7536ccecef5d231566a5dbfa37e791fb2fe6f0e024fcc441514b5",
"gzipSha256": "f5f193a162a32fd9039cd4715ea1064eb0b6e2f2f4bbb123608996eaac21934c"
},
{
"path": "backup-tar-green.txt",
"gzipPath": "backup-tar-green.txt.gz",
"rawSha256": "eedcd9ff7addf9bc70ce97d2b58f9ee8c77e92a49c92c5287c15bcfda70dd784",
"gzipSha256": "125a6efda6e271cb09ed94abf46e4206db92ff69fc271e78633091be206a9792"
},
{
"path": "backup-tar-syntax.json",
"gzipPath": "backup-tar-syntax.json.gz",
"rawSha256": "56561c68f65ad606da2faccbc45b9e783a509ea47997ea5dd736afa1f48a7d6f",
"gzipSha256": "82ef3bebbc56ffdaa47a533add5bccc27ab83f13fc82e434efc8f7a12b22fa88"
},
{
"path": "backup-tar-graph.txt",
"gzipPath": "backup-tar-graph.txt.gz",
"rawSha256": "7bcdd1d183f74e8eecd9bc5c64e4b3cfde106ca4ddf3972ad9c0f9103dd837db",
"gzipSha256": "52b0e14413dcf05d84494c19cd63c5a9573f6424b5c66deda03f57f2b532ba4e"
}
]
}
@@ -0,0 +1,18 @@
Re-extracting code files in . (no LLM needed)...
[graphify watch] 330 file(s) not classified (no supported extension or shebang), skipped: .dockerignore, .env.example, .git, .gitattributes, .gitignore, App.css (+324 more)
AST cache: 1935/2347 files served from cache (82%); 412 to extract
AST extraction: 100/412 uncached files (24%) [16 workers]
AST extraction: 200/412 uncached files (48%) [16 workers]
AST extraction: 300/412 uncached files (72%) [16 workers]
AST extraction: 400/412 uncached files (97%) [16 workers]
AST extraction: 412/412 uncached files (100%) [16 workers]
warning: 8 .sql file(s) contributed nothing to the graph because a dependency is missing: tree_sitter_sql not installed. Install it with: pip install "graphifyy[sql]" (#1745)
warning: 139 code file(s) yielded no symbols (0.13 MB) — a data file, or source this extractor models no symbols for: JobTrackerApi.Tests/PdfBrowserStub/Program.cs, JobTrackerApi/Program.cs, JobTrackerApi/Properties/AssemblyInfo.cs, browser-extension/tests/capture-url.test.mjs, docs/audits/2026-09-07/validation/evidence/b05-excel-probe.ps1 (+134 more)
[graphify watch] community set changed since labeling (0 saved labels, 1071 communities now; renamed 151 community(ies) by their hub). Run `graphify label` to refresh names with the LLM.
Graph has 18554 nodes (above 5000 limit). Building aggregated community view...
graph.html written (aggregated: 1071 community nodes, 3090 cross-community edges)
Tip: run with --obsidian for full node-level detail.
[graphify watch] Rebuilt: 18554 nodes, 46015 edges, 1071 communities
[graphify watch] graph.json, graph.html and GRAPH_REPORT.md updated in graphify-out
Code graph updated. For doc/paper/image changes run /graphify --update in your AI assistant.
Tip: set GEMINI_API_KEY or GOOGLE_API_KEY to use Gemini for semantic extraction.
@@ -0,0 +1,27 @@
test_empty_password_is_preserved (__main__.BackupConnectionTests.test_empty_password_is_preserved) ... ok
test_invalid_or_ambiguous_input_never_invokes_dump_or_exposes_input (__main__.BackupConnectionTests.test_invalid_or_ambiguous_input_never_invokes_dump_or_exposes_input) ... ok
test_quoted_separators_and_shell_characters_remain_data (__main__.BackupConnectionTests.test_quoted_separators_and_shell_characters_remain_data) ... ok
test_single_quoted_unicode_password_and_database_alias_are_preserved (__main__.BackupConnectionTests.test_single_quoted_unicode_password_and_database_alias_are_preserved) ... ok
test_supported_host_alias_and_case_reach_dump_unchanged (__main__.BackupConnectionTests.test_supported_host_alias_and_case_reach_dump_unchanged) ... ok
test_exact_database_member_at_root_or_in_a_directory_is_accepted (__main__.BackupDatabaseMemberTests.test_exact_database_member_at_root_or_in_a_directory_is_accepted) ... ok
test_sidecar_or_similar_name_is_not_the_database_member (__main__.BackupDatabaseMemberTests.test_sidecar_or_similar_name_is_not_the_database_member) ... ok
test_valid_gzip_with_truncated_tar_database_member_is_rejected (__main__.BackupDatabaseMemberTests.test_valid_gzip_with_truncated_tar_database_member_is_rejected) ... ok
test_both_permission_failures_block_verification_and_next_gate (__main__.BackupPermissionTests.test_both_permission_failures_block_verification_and_next_gate) ... ok
test_fallback_permission_success_preserves_verification (__main__.BackupPermissionTests.test_fallback_permission_success_preserves_verification) ... ok
test_host_permission_success_does_not_need_fallback (__main__.BackupPermissionTests.test_host_permission_success_does_not_need_fallback) ... ok
test_completed_monthly_snapshot_contains_both_artifacts_and_stamp (__main__.BackupRetentionTests.test_completed_monthly_snapshot_contains_both_artifacts_and_stamp) ... ok
test_daily_prune_failure_blocks_monthly_pruning_upload_and_deploy (__main__.BackupRetentionTests.test_daily_prune_failure_blocks_monthly_pruning_upload_and_deploy) ... ok
test_empty_monthly_enumeration_does_not_request_removal (__main__.BackupRetentionTests.test_empty_monthly_enumeration_does_not_request_removal) ... ok
test_marker_publish_failure_does_not_expose_complete_marker_or_proceed (__main__.BackupRetentionTests.test_marker_publish_failure_does_not_expose_complete_marker_or_proceed) ... ok
test_monthly_enumeration_failure_blocks_pruning_upload_and_deploy (__main__.BackupRetentionTests.test_monthly_enumeration_failure_blocks_pruning_upload_and_deploy) ... ok
test_monthly_prune_failure_stops_before_remaining_months_upload_and_deploy (__main__.BackupRetentionTests.test_monthly_prune_failure_stops_before_remaining_months_upload_and_deploy) ... ok
test_partial_monthly_copy_cannot_mark_snapshot_complete_or_proceed (__main__.BackupRetentionTests.test_partial_monthly_copy_cannot_mark_snapshot_complete_or_proceed) ... ok
test_preserves_the_existing_completed_monthly_snapshot (__main__.BackupRetentionTests.test_preserves_the_existing_completed_monthly_snapshot) ... ok
test_daily_copy_failure_stops_before_remaining_files_and_monthly_copy (__main__.BackupUploadTests.test_daily_copy_failure_stops_before_remaining_files_and_monthly_copy) ... ok
test_monthly_copy_failure_blocks_deploy (__main__.BackupUploadTests.test_monthly_copy_failure_blocks_deploy) ... ok
test_uploads_only_current_daily_files_then_monthly_snapshot (__main__.BackupUploadTests.test_uploads_only_current_daily_files_then_monthly_snapshot) ... ok
----------------------------------------------------------------------
Ran 22 tests in 9.967s
OK
@@ -0,0 +1,16 @@
test_valid_gzip_with_truncated_tar_database_member_is_rejected (__main__.BackupDatabaseMemberTests.test_valid_gzip_with_truncated_tar_database_member_is_rejected) ... FAIL
======================================================================
FAIL: test_valid_gzip_with_truncated_tar_database_member_is_rejected (__main__.BackupDatabaseMemberTests.test_valid_gzip_with_truncated_tar_database_member_is_rejected)
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\Users\Connor\.codex\worktrees\release-readiness-discovery\Job tracker\scripts\test-deploy-backup.py", line 417, in test_valid_gzip_with_truncated_tar_database_member_is_rejected
self.assertNotEqual(0, result.returncode, result.stdout + result.stderr)
AssertionError: 0 == 0 : FORMAT VERIFIED
NEXT DEPLOY GATE WOULD START
----------------------------------------------------------------------
Ran 1 test in 0.214s
FAILED (failures=1)
@@ -0,0 +1,11 @@
{
"command": [
"bash",
"-n",
"deploy/deploy.sh"
],
"exitCode": 0,
"stdout": "",
"stderr": "",
"sourceLfSha256": "2c743f45bc658a4aca225e43d5db0a572f64d547a7f59d0e176d4900cc3b1e6b"
}