Clean error alerts and harden startup migration

This commit is contained in:
2026-04-11 18:07:20 +02:00
parent b52371ea79
commit 48cd83b442
5 changed files with 47 additions and 14 deletions
+1
View File
@@ -59,6 +59,7 @@ namespace JobTrackerApi.Data
.HasIndex(c => c.OwnerUserId);
modelBuilder.Entity<Correspondence>()
.HasQueryFilter(c => CurrentUserId != null && c.JobApplication.OwnerUserId == CurrentUserId)
.HasOne(c => c.JobApplication)
.WithMany(j => j.Messages)
.HasForeignKey(c => c.JobApplicationId)
+8 -2
View File
@@ -60,11 +60,17 @@ builder.Services.AddDbContext<JobTrackerContext>((sp, options) =>
// Avoid ServerVersion.AutoDetect here because it forces an immediate DB connection
// during service registration, which can crash the API if MariaDB is temporarily
// unavailable or on a different network during deploy startup.
options.UseMySql(cs, new MariaDbServerVersion(new Version(11, 0, 0)));
options.UseMySql(cs, new MariaDbServerVersion(new Version(11, 0, 0)), mysql =>
{
mysql.MigrationsAssembly("JobTrackerApi");
});
}
else
{
options.UseSqlite(cs);
options.UseSqlite(cs, sqlite =>
{
sqlite.MigrationsAssembly("JobTrackerApi");
});
}
// We create Identity tables on startup in environments where `dotnet ef` isn't available.
@@ -870,7 +870,17 @@ public static class StartupInitializationExtensions
}
}
db.Database.Migrate();
try
{
using var migrationScope = app.Services.CreateScope();
var migrationDb = migrationScope.ServiceProvider.GetRequiredService<JobTrackerContext>();
migrationDb.Database.Migrate();
}
catch (Exception ex)
{
app.Logger.LogError(ex, "Database migration failed during startup initialization.");
throw;
}
// Optional: seed an initial admin user for local username/password login.
// Set Auth:AdminEmail and Auth:AdminPassword to enable.
+19 -8
View File
@@ -1,26 +1,37 @@
import axios from "axios";
import { clearAuthClientState, getCsrfToken } from "./auth";
function looksLikeHtml(value: string) {
return /<\s*html\b|<\s*body\b|<\s*head\b|<\s*title\b|<\s*!doctype\b/i.test(value);
}
function sanitizeServerMessage(value: string, fallback: string) {
const text = value.trim();
if (!text) return fallback;
if (looksLikeHtml(text)) return fallback;
return text.length > 300 ? `${text.slice(0, 297).trimEnd()}...` : text;
}
export function getApiErrorMessage(error: any, fallback = "Request failed.") {
const data = error?.response?.data;
if (typeof data === "string" && data.trim()) return data.trim();
if (typeof data?.message === "string" && data.message.trim()) return data.message.trim();
if (typeof data?.detail === "string" && data.detail.trim()) return data.detail.trim();
if (typeof data?.title === "string" && data.title.trim()) return data.title.trim();
if (typeof data === "string" && data.trim()) return sanitizeServerMessage(data, fallback);
if (typeof data?.message === "string" && data.message.trim()) return sanitizeServerMessage(data.message, fallback);
if (typeof data?.detail === "string" && data.detail.trim()) return sanitizeServerMessage(data.detail, fallback);
if (typeof data?.title === "string" && data.title.trim()) return sanitizeServerMessage(data.title, fallback);
if (Array.isArray(data?.errors)) {
const first = data.errors.find((value: unknown) => typeof value === "string" && value.trim());
if (first) return first;
if (first) return sanitizeServerMessage(first, fallback);
}
if (data?.errors && typeof data.errors === "object") {
for (const value of Object.values(data.errors)) {
if (Array.isArray(value)) {
const first = value.find((item: unknown) => typeof item === "string" && item.trim());
if (first) return first;
if (first) return sanitizeServerMessage(first, fallback);
}
if (typeof value === "string" && value.trim()) return value.trim();
if (typeof value === "string" && value.trim()) return sanitizeServerMessage(value, fallback);
}
}
if (typeof error?.message === "string" && error.message.trim()) return error.message.trim();
if (typeof error?.message === "string" && error.message.trim()) return sanitizeServerMessage(error.message, fallback);
return fallback;
}
+8 -3
View File
@@ -10,9 +10,14 @@ jest.mock('./api', () => ({
interceptors: { request: { use: jest.fn() }, response: { use: jest.fn() } },
},
getApiErrorMessage: jest.fn((error: any, fallback?: string) => {
if (typeof error?.response?.data === 'string' && error.response.data.trim()) return error.response.data;
if (typeof error?.message === 'string' && error.message.trim()) return error.message;
return fallback || 'Request failed.';
const text = typeof error?.response?.data === 'string' && error.response.data.trim()
? error.response.data.trim()
: typeof error?.message === 'string' && error.message.trim()
? error.message.trim()
: '';
if (!text) return fallback || 'Request failed.';
if (/<\s*html\b|<\s*body\b|<\s*head\b|<\s*title\b|<\s*!doctype\b/i.test(text)) return fallback || 'Request failed.';
return text.length > 300 ? `${text.slice(0, 297).trimEnd()}...` : text;
}),
}));