Fix frontend lockfile for CI installs

2026-03-27 10:22:03 +01:00
parent 44ff64896a
commit 5efedbe784
2 changed files with 1371 additions and 1369 deletions
@@ -12,3 +12,4 @@
 - `scripts/s06-preflight.sh` intentionally exits 0 on the auth-limited path where `/api/auth/config` is reachable but `/api/admin/system` returns 401/403. Treat that as a guided partial pass for browser/UAT prep; only unreachable API, malformed JSON, or non-auth admin failures should block the slice.
 - In this M001 worktree, the focused CRA regression command `CI=true npm --prefix /home/pi/development/JobTracker/.gsd/worktrees/M001/job-tracker-ui test -- --runInBand --watch=false src/daily-control-loop.test.tsx src/workflow-trust-signals.test.tsx` can fail with `react-scripts: not found` even when `job-tracker-ui/node_modules` already exists from an older install state; rerun `npm --prefix /home/pi/development/JobTracker/.gsd/worktrees/M001/job-tracker-ui install` first, then retry the exact test command.
 - In the S07 localhost acceptance pass, opening the follow-up draft tab did not emit a fresh captured network request by itself. To verify the R008 manual-send boundary without clicking the send action, use the live UI evidence (`Copy Draft` and `Send And Log Email` both visible), then confirm `GET /api/jobapplications/3/followup-draft` succeeds from the authenticated browser context and that no `POST /api/jobapplications/3/send-followup` request appears during the observed pass.
+- In this GSD worktree alias, running frontend installs from the symlinked path can corrupt `job-tracker-ui/package-lock.json` by writing package keys like `../../../../../../.gsd/projects/.../worktrees/M001/job-tracker-ui/node_modules/...`. That lockfile can still work locally but breaks CI `npm ci` on a different checkout path. Before pushing frontend lockfile changes, verify the lock uses plain `node_modules/...` package keys and test it from a different directory.