docs(redesign): record P6-01 consistency and workflow audit
This commit is contained in:
cesnimda
@@ -0,0 +1,7 @@
|
||||
# Phase 6 checkpoint log
|
||||
|
||||
Every completed logical unit is pushed to `codex/ui-redesign-phase4`, without force. Production main remains `27657f31131cd95d42f0e1290853ec9c9b3959a4`. Hashes are appended by the successor checkpoint to avoid self-referential commit hashes. Work in progress belonging to the next unit is recorded separately from staged checkpoint files.
|
||||
|
||||
| Unit | Commit | Validation / synchronization |
|
||||
|---|---|---|
|
||||
| Approved planning/P6-00 baseline | `3d9341e70f71a3e625f3a2108d366f6644f565d6` | Remote=HEAD, clean at entry |
|
||||
@@ -0,0 +1,21 @@
|
||||
# Phase 6 consistency findings
|
||||
|
||||
Statuses distinguish observed defects from incomplete qualification. Severity is based on workflow impact, not cosmetic preference. Evidence starts with the [Phase5 final native manifest](../../phase-5/p5-15/p5-15-06/evidence/validation.json) and current source/native inspection; later checkpoints append actual results.
|
||||
|
||||
| ID | Category / severity | Demonstrated condition / responsible owner | Required action / checkpoint | Status |
|
||||
|---|---|---|---|---|
|
||||
| P6-F01 | Accessibility P2 | Career Profile avatar initials contrast1.19 light /1.76 dark; default MUI Avatar pair instead of existing semantic pair; ProfilePage has same owner pattern | Use approved foreground/background pair; measured native contrast / P6-03 | Confirmed |
|
||||
| P6-F02 | Accessibility structure P2 | Login has no main/H1; ten uncontained regions share that root. Career/CV/Admin implicit typography skips heading levels | Correct semantic elements retaining style; native heading/tree evidence / P6-03 | Confirmed; exact descendant hierarchy under review |
|
||||
| P6-F03 | Accessibility names, potential P1 | Seven drawer command-name reports in one emulated NB/dark opening state; collection precedes settled entry focus | Reproduce pre/post-entry accessible names and keyboard reachability, correct owner if necessary / P6-03 | Not waived; investigation |
|
||||
| P6-F04 | Accessibility structure P2 | Settings tabs lack id/aria-controls, active panel lacks role/name; CV already uses associations | Link existing tabs/panels, retain draft owner and mobile selector / P6-03 | Confirmed |
|
||||
| P6-F05 | Feedback usability P2 | Company failed save retains draft but only toast outside modal subtree | In-dialog existing Alert, retry through existing Save, no new save model / P6-02 | Confirmed code path and prior native RD16 |
|
||||
| P6-F06 | Reliability feedback P2 | Language preference updates locally, catches remote errors with no user feedback | Bound failed persistence feedback without reversing local language or inventing autosave / P6-02 | Confirmed suppression; historical500 cause remains unproven |
|
||||
| P6-F07 | Localisation P3 | Selected company fallback is literal Company+id; company date labels use host locale while relationship dialog uses UI locale | Reuse existing translation/date convention if bounded; do not change filters / P6-03 | Confirmed code paths |
|
||||
| P6-F08 | Scan context / manual | Five landmark-unique reports involve outer main and named preview frame main; document is a separate browsing context | Retain renderer; verify settled frame names/keyboard, real reader packet / P6-03 | Contextual investigation, human NOT VERIFIED |
|
||||
| P6-F09 | Capacity | Board materialises/renders all rows; finite200/1000 membership passes, no approved device/load budget | Measure requests/bytes/render/long tasks/memory, preserve full result / P6-04 | Open O(N) limitation |
|
||||
| P6-F10 | Rendering environment | Windows fonts and tiny synthetic photos pass; deployed Linux/representative portrait unavailable | Preserve16/8 suites; operator environment packet / P6-04 | Production qualification NOT VERIFIED |
|
||||
| P6-F11 | Intermittent observation | Historical CV Unsaved failure lacks trace; deterministic800ms boundary test passes | Keep observation open; capture exact save timing in current runs / P6-02/P6-06 | Not declared fixed |
|
||||
| P6-F12 | Intentional variation | Landing marketing treatment, CV white physical page, responsive two-dimensional Board/document canvas | Preserve intent; ordinary app chrome must reflow / P6-01/P6-03 | Retained |
|
||||
| P6-F13 | Approved future scope | Remaining Auth/onboarding/Profile/library/Documents/mail/Notifications/Settings/Admin/error/dialog visual migration | Concrete Phase7 reconciliation, no implementation / P6-06 | Deferred migration, original functionality retained |
|
||||
|
||||
Independent mandatory gaps: human screen-reader acceptance (owner postponed), physical touch/drag/software keyboard, broader reflow, operational production evidence. No automated agent certifies them. P5-13 remains deferred with0/366 configured calls and0human reviews; do not activate or qualify during Phase6.
|
||||
@@ -0,0 +1,47 @@
|
||||
# P6-01 — System consistency and workflow review
|
||||
|
||||
Baseline: `3d9341e70f71a3e625f3a2108d366f6644f565d6`, `codex/ui-redesign-phase4`, fetched remote=HEAD and clean checkout. This executes the [approved sequence](../README.md), not a replacement P6-00. Production main remains `27657f31131cd95d42f0e1290853ec9c9b3959a4`, NO-GO.
|
||||
|
||||
## Method and boundary
|
||||
|
||||
Review current loaded native SQLite/API/browser workflows, rendered EN/Bokmål and light/dark states, shared owners and existing regressions. Compare function and semantics before appearance. Native collection is automated inspection, not human usability, reader or device acceptance. The inherited 1,033 backend / 498 frontend / 148 browser baseline is separate from fresh checkpoint runs.
|
||||
|
||||
The thirteen-area responsive audit exercises authentication, shell, commands, Jobs, Board, Dashboard, Analytics, Job workspace, Career Profile, CV, Documents, Settings and administration. It includes breakpoint transitions, long recorded content, keyboard dialogs/navigation, source route, native file selection, physical preview measurement and emulated orientation/input. The existing route audit covers 32 patterns; no route or capability is removed here. [All 57 original contracts](../../phase-2/PRESERVATION_MATRIX.md) remain unchanged; historical P2-D01 expected-failure statements are superseded by its ordinary passing native package case.
|
||||
|
||||
## Surface and component inventory
|
||||
|
||||
| Surface | Current implementation / evidence | Consistency decision |
|
||||
|---|---|---|
|
||||
| Shell, navigation, commands | AppShell / QuickCommandDialog; native drawer, route and command journeys | Retain approved hierarchy and existing focus-return architecture |
|
||||
| Jobs Table / Board | JobsWorkspacePage, JobTable, KanbanBoard; shared query/filter state, saved-search repair, pointer/keyboard movement | Comfortable/Compact affects application density, never CV paper; full-result scaling remains open |
|
||||
| Dashboard / Analytics | DashboardView variants; exact recorded status links, period/filter native journeys | Shared reporting patterns intentional; no invented metrics or Phase8 customization |
|
||||
| Job workspace | ApplicationWorkspacePage sections; native route/package/attachment evidence | Retain deeper section ownership and frozen submission semantics |
|
||||
| CV editor / preview / settings | CvBuilderEditor; PageSection, document settings and verified preview lifecycle | Separate app chrome from physical renderer; keep normal save/undo/revision system |
|
||||
| Career Profile / CV library | Existing canonical forms and variant list | Remaining full visual migration belongs to Phase7; semantic/contrast defects still require bounded correction |
|
||||
| Documents / correspondence | Existing retrieval, association, composition and export paths | Do not mistake pending visual migration for lost capabilities |
|
||||
| Settings / Rules | PageLayout / PageSection; session-owned Rules drafts | Retain save/discard contracts; add missing tab/panel associations separately |
|
||||
| Auth / admin / remaining dialogs | Existing supported routes and permission controls | Phase7 visual migration remains; basic landmarks, heading hierarchy and modal feedback are current obligations |
|
||||
|
||||
Shared authorities are `theme.ts`, PageLayout, ViewStateNotice/useViewResource, existing toast/confirm/prompt providers and pipeline status definitions. No replacement framework, parallel token system, saving model, navigation model or renderer is justified. Public landing gradients are an intentional existing marketing variation, not evidence of systemic app inconsistency.
|
||||
|
||||
## Prioritised findings
|
||||
|
||||
See [findings register](FINDINGS.md). Investigate all 39 inherited all-enabled axe occurrences by their actual root, including the seven drawer name reports. They are not 39 independent bugs and are not waived because ordinary tests pass. Reader/device verification remains missing.
|
||||
|
||||
Concrete review targets: profile/avatar contrast, login and application heading semantics, Settings tab associations, settled drawer names, modal save-error discoverability and swallowed language-save failures. Correct them at existing owners with reproduction and regression evidence; do not broaden into full legacy-page migrations. CV cross-document landmark reports require context, not changing the PDF renderer to appease a best-practice scan.
|
||||
|
||||
## Preservation and remaining acceptance
|
||||
|
||||
Relevant contracts: PRES-E02/E06/E07/E08, J05/J07/J08, W01/W08, C06–C12 and S01/S03/S04. Current whole-group acceptance remains **0PASS / 56PARTIAL / 0FAIL / 1DEFERRED =57**. Finite native evidence cannot close every sub-workflow or mandatory human check. P5-13 remains deferred, unqualified and Production-withheld; no model calls or AI UI.
|
||||
|
||||
Carry forward human reader/device/software keyboard, production font/portrait, preference500 root-cause, Board capacity, historical CV Unsaved, all production ingress/backup/restore/configuration/schema/rollback and other [readiness obligations](../../phase-5/p5-15/READINESS_DEBT.md). No production access or mutation is attempted. Subsequent checkpoints provide bounded corrections and fresh final regression; Phase7 implementation is excluded.
|
||||
|
||||
## Axe root reconciliation
|
||||
|
||||
Inherited39occurrences:2contrast (avatar),13heading-order (contextual implicit Typography),1missing-main+1missing-H1+10region (login),5landmark-unique (outer main/name plus separate preview frame),7drawer child command-name (transition sample). Explicit semantic props preserve visual variants; no global variant mapping or print-document change. Settled drawer evidence is required before classification.
|
||||
|
||||
## Fresh checkpoint evidence and decision
|
||||
|
||||
**CONDITIONAL GO to P6-02.** Fresh native audit10/10, zero skips/retries/flaky/failures; [sanitized exact results](evidence/native-audit.json).45all-enabled scans record36violation-node occurrences: the inherited39 differ only in the transitional drawer sample (4now versus7previously); this variation is not a resolution. Current incompletes331 (294contrast,26prohibited-attribute,7hidden-focus,2attribute-value,2target-size). Historical267retained scans and2367combined incompletes remain evidence, not another fresh run. No human/device acceptance is claimed.
|
||||
|
||||
Code-path review was independently divided among three read-only agents; runtime/visual conclusions remain the native evidence boundary. No production application change belongs to this audit unit. Next: bounded feedback repairs and complete task journeys. Commit/push recorded in the chronological [checkpoint log](../COMMITS.md).
|
||||
File diff suppressed because it is too large
Load Diff
Reference in New Issue
Block a user