Compare commits
3 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| da49c7f2e2 | |||
| 6da2e79a8a | |||
| 48861bca70 |
@@ -149,6 +149,56 @@ public sealed class SavedJobSearchSqliteTests(ITestOutputHelper output)
|
||||
fixture.Discovery.VerifyNoOtherCalls();
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("Soins de proximité", "aide-soignant·e", "Orle\u0301ans / Orléans, Centre-Val de Loire")]
|
||||
[InlineData("Opieka bez lokalizacji", "pielęgniarka", "")]
|
||||
public async Task Temporary_search_keeps_legacy_filters_and_dismissal_history(string name, string query, string location)
|
||||
{
|
||||
await using var fixture = await SqliteFixture.CreateAsync();
|
||||
var firstSeen = new DateTimeOffset(2025, 3, 3, 8, 0, 0, TimeSpan.Zero);
|
||||
var previousRun = firstSeen.AddDays(1);
|
||||
var legacy = new SavedJobSearch
|
||||
{
|
||||
OwnerUserId = "owner-1", Name = name, Query = query, Location = location,
|
||||
CreatedAtUtc = firstSeen, UpdatedAtUtc = previousRun, LastRunAtUtc = previousRun,
|
||||
Results = [new SavedJobSearchResult
|
||||
{
|
||||
ExternalJobId = "historical-nav-id", FirstSeenAtUtc = firstSeen,
|
||||
LastSeenAtUtc = previousRun, IsDismissed = true
|
||||
}]
|
||||
};
|
||||
fixture.Db.SavedJobSearches.Add(legacy);
|
||||
await fixture.Db.SaveChangesAsync();
|
||||
fixture.Db.ChangeTracker.Clear();
|
||||
fixture.Discovery.Setup(x => x.SearchAsync("lærer", "Tønsberg", It.IsAny<CancellationToken>()))
|
||||
.ReturnsAsync(Array.Empty<DiscoveredJob>());
|
||||
fixture.Discovery.Setup(x => x.SearchAsync(query, location, It.IsAny<CancellationToken>()))
|
||||
.ReturnsAsync(new[] { Job("historical-nav-id") });
|
||||
|
||||
Assert.IsType<OkObjectResult>((await fixture.Controller.Search("lærer", "Tønsberg", default)).Result);
|
||||
var original = Assert.Single(await List(fixture.Controller));
|
||||
Assert.Equal(new JobDiscoveryController.SavedSearchDto(legacy.Id, name, query, location, true, previousRun, 1, 1), original);
|
||||
|
||||
var run = Assert.IsType<JobDiscoveryController.SavedSearchRunDto>(Assert.IsType<OkObjectResult>(
|
||||
(await fixture.Controller.RunSavedSearch(legacy.Id, default)).Result).Value);
|
||||
var seen = Assert.Single(run.Jobs);
|
||||
Assert.False(seen.IsNew);
|
||||
Assert.True(seen.IsDismissed);
|
||||
fixture.Db.ChangeTracker.Clear();
|
||||
var retained = Assert.Single(await List(fixture.Controller));
|
||||
Assert.True(retained.LastRunAtUtc > previousRun);
|
||||
Assert.Equal(original with { LastRunAtUtc = retained.LastRunAtUtc }, retained);
|
||||
var history = await fixture.Db.SavedJobSearchResults.AsNoTracking().SingleAsync();
|
||||
Assert.Equal(legacy.Id, history.SavedJobSearchId);
|
||||
Assert.Equal("historical-nav-id", history.ExternalJobId);
|
||||
Assert.Equal(firstSeen, history.FirstSeenAtUtc);
|
||||
Assert.Equal(retained.LastRunAtUtc, history.LastSeenAtUtc);
|
||||
Assert.True(history.IsDismissed);
|
||||
fixture.Discovery.Verify(x => x.SearchAsync("lærer", "Tønsberg", It.IsAny<CancellationToken>()), Times.Once);
|
||||
fixture.Discovery.Verify(x => x.SearchAsync(query, location, It.IsAny<CancellationToken>()), Times.Once);
|
||||
fixture.Discovery.VerifyNoOtherCalls();
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("name-empty")]
|
||||
[InlineData("name-long")]
|
||||
|
||||
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,56 @@
|
||||
# Offline European geography contract QA
|
||||
|
||||
17 November 2026. Bounded documentation/tooling increment authorised by the current direct roadmap continuation. This is executable specification QA, not GJ-01/GJ-02 implementation or acceptance. No application imports, dependencies, settings, migrations, HTTP requests, provider/model calls or qualification statuses change.
|
||||
|
||||
19 November: the [multi-country extension](GEOGRAPHY_MULTI_COUNTRY_QA.md) adds BE/FR and DE/PL fixtures, expansion and locale-change invariants. The outcomes below retain the original `48861bca` checkpoint; use the extension for current validator counts.
|
||||
|
||||
## Inputs and identity
|
||||
|
||||
Application baseline: `eb2538772e1bfabbeb291e4a5efa177c79074de1` (A3). Isolated branch `codex/global-geo-contracts`; worktree `E:/Storage/Projects/Active/temp docs/jobjakt-local-build/global-geo-contracts`.
|
||||
|
||||
The validator reads committed Git blobs directly. It does not copy a country registry, inspect another checkout's uncommitted data or require the I18N worktree to remain present. Required commits must exist locally; missing objects fail execution rather than falling back to stale checkout files. It performs no fetch.
|
||||
|
||||
| Source commit | Repository path | Exact Git blob |
|
||||
| --- | --- | --- |
|
||||
| `39fb9df06904e44916e258da0ed975dd46b9691c` | `docs/i18n/00/EUROPE_COUNTRY_LANGUAGE_MATRIX.md` | `4b88eb52e91d1c1ad0bb9082ed3ce075e0602dbd` |
|
||||
| `39fb9df06904e44916e258da0ed975dd46b9691c` | `docs/i18n/00/EUROPE_RELEASE_COVERAGE.csv` | `395fc09934a516a2445fddb092b5de18c9469080` |
|
||||
| `0ec9f98e6ed4a646fc5e017d8eb6fade07653f37` | `docs/global-jobs/00/GEOGRAPHY_DECISIONS.md` | `48f108ef02648f53490ae505b223ebff321264bb` |
|
||||
|
||||
The I18N source commit was inspected in the existing `i18n-message-census` worktree. Both matrix/CSV blob identities also match A3 exactly. All inputs are available in this local repository object store. The GJ planning documents remain on their separate planning history; they are not merged or replaced here. The geography decision blob is bound for traceability; its prose semantics were reviewed by a human-readable source inspection, not automatically interpreted by the script.
|
||||
|
||||
Authority: Prompt 7 and the GJ pack retain predecessor/initiative gates; GJ-00 geography decisions define branch refinement and typed relationships. The later EUROPE-READY owner addendum §§4/14 requires country/refinement contract tests and §15 preserves shared owners and gates. Existing `docs/i18n/00/IMPLEMENTATION_PLAN.md` permits future fixture design without inventing dependent runtime. Current direct instruction narrows this increment to offline documentation contracts. It does not authorise a runtime scope compiler.
|
||||
|
||||
## What runs
|
||||
|
||||
From the repository root, using installed Node and Git only:
|
||||
|
||||
```text
|
||||
rtk proxy node docs/global-jobs/00/validate-contracts.cjs --self-test
|
||||
rtk proxy node --check docs/global-jobs/00/validate-contracts.cjs
|
||||
rtk git diff --check
|
||||
```
|
||||
|
||||
The first command checks the matrix's exact 59-code roster and 1,062 coverage cells (18 columns per country); validates status vocabulary and the frozen qualification snapshot, including the sole existing Norway NAV fixture result; and checks XK's explicit non-ISO caveat. Updating any status requires a separately reviewed source/evidence change and validator update. This snapshot guard is not a general release approval engine.
|
||||
|
||||
`GEOGRAPHY_CONTRACT_FIXTURES.json` contains 13 deliberately synthetic typed identities, seven typed edges and 12 selection expectation cases. Every ID uses the `s:` namespace, edition `synthetic-1`, and explicit synthetic provenance. Display labels resemble representative locations, but neither the IDs nor edges are authoritative geographic data or a licensed boundary dataset. Administrative reachability is used only to check fixture expectations; settlement intersection and shared footprint cannot substitute for administrative containment. No query plan is emitted and no function is exported for application use.
|
||||
|
||||
Cases cover whole Warwickshire, one/two towns, removing refinements, independent Bergen OR, Vestfold/Tønsberg, distinct Oslo identities, Stockholm municipality versus settlement and parent/country removal. Query/tree/map are declared expected scope lists whose consistency is checked; no UI, query service or map is exercised. Four preference examples cover EN/NO→GB, NB→SE, PL→DE and FR→BE+FR as separate residence/UI/ad/document-language fields. One explicit country-change fixture preserves unrelated preferences and a saved-search sentinel, removes only incompatible branches and requires an explanation. JSON roundtrip checks apply to these fixtures only, not server persistence.
|
||||
|
||||
## Validation outcome
|
||||
|
||||
Executed with Node `v24.19.0`:
|
||||
|
||||
- PASS: 59 country rows / 1,062 coverage cells; 13 nodes, 12 selection cases, four preference examples and one country-change expectation.
|
||||
- PASS: 22 negative mutations rejected. They cover false release claims, missing/duplicate/invented countries, invalid status, crediting the NAV fixture to GB, typed identity/edition/provenance errors, invented geometry, cross-country edges, unresolved scopes, invalid refinements, broad-parent leakage, map divergence, language/saved-search resets, invisible filters, missing explanations, settlement overlap treated as containment, administrative cycles and invalid journey country.
|
||||
- PASS: Node syntax check and staged Git diff whitespace check (exit 0 each).
|
||||
- RED evidence: before implementation, the permissive validator failed the negative suite with `Missing expected exception: must reject false release coverage` (exit 1). First implemented run then caught the real CSV's NO/SE/GB administrative hierarchy `AWAITING REVIEW` nuance; the corrected frozen-snapshot guard preserves that existing status.
|
||||
|
||||
The 22 mutations are checks of the validator, not 22 additional product tests. The counts above describe one successful final contract run; intermediate reruns are not added. Syntax/diff verification is recorded separately from product tests.
|
||||
|
||||
Required `rtk proxy graphify update .` completed exit 0 with 19,842 nodes / 48,008 edges, explicitly AST-only/no LLM. It retained warnings for unavailable PDF/SQL extractors and 146 code files yielding no symbols. Generated `graphify-out/` is local/untracked and excluded from this documentation commit; graph counts are structural orientation, not acceptance tests.
|
||||
|
||||
## Gates and limits
|
||||
|
||||
All 59 entries remain candidate scope with their existing statuses. Real geography licences, exact dataset epochs/IDs/geometry, provider rights, live operation, map attribution/privacy, native-language/device/AT evidence and release approval remain open. Phase 10 D02/frozen-candidate acceptance, Product Review, GJ implementation authority and sequential accepted stages are unchanged. No precise town/radius, accessible tree, map switching, server preference persistence or country-specific provider behavior is qualified by these checks.
|
||||
|
||||
The existing NAV municipality substring limitation remains assigned to GJ geography work; this increment does not establish or repair a separate Norway regression. No main merge, orchestrator action, push or deployment occurs. Application builds/browser/backend/hosted/provider/model suites were intentionally not run for documentation-only tooling.
|
||||
@@ -0,0 +1,62 @@
|
||||
# Multi-country geography specification QA
|
||||
|
||||
19 November 2026. Extends the accepted offline contract checkpoint `48861bca706637fdb217e0e834e67fe052113195` on `codex/global-geo-contracts`. Application baseline remains `eb2538772e1bfabbeb291e4a5efa177c79074de1`; no application source is modified or claimed current by these checks.
|
||||
|
||||
## Eligible gap and gates
|
||||
|
||||
The current central TODO still gates GJ-01 on Phase 10 D02, Product Review and initiative approval. GJ-02 runtime geography, licensed datasets, providers/maps, locale rollout and release approval remain separate. The existing 59-country coverage snapshot retains every status. Current owner scope permits useful offline specification qualification only.
|
||||
|
||||
The earlier corpus had GB/NO cross-border scope but no BE/FR or DE/PL location-selection examples; its DE/FR reference nodes were unused. Its four preference examples checked field shapes, while only one country-change expectation was validated and no locale-change expectation preserved canonical selection. This increment extends that same corpus and small validator; it creates no second country/locale registry or runtime compiler.
|
||||
|
||||
## Added contracts
|
||||
|
||||
- BE/FR independent city branches and DE/PL independent city branches combine as OR using distinct country/type IDs.
|
||||
- Expanding the BE/FR tree has exactly the same declared countries, branches and query/tree/map scopes as the collapsed counterpart.
|
||||
- Two intentionally fictional locations called `Synthetic Riverside` in different countries retain distinct identifiers and both effective scopes. Labels cannot merge them.
|
||||
- Removing FR from a temporary BE/FR query or DE from DE/PL removes only the incompatible branch and explains the change. It preserves residence, UI/ad/document languages and the separate named saved-search definition.
|
||||
- A declared FR→NL UI-locale change preserves countries, canonical branch IDs, residence, ad/document languages and the literal named saved search.
|
||||
|
||||
All added identities/relations remain under synthetic namespace `s:`, edition `synthetic-1`, provenance `synthetic-no-boundary-claim`. Familiar labels do not establish real administrative containment, legal language status, licensed data/geometry or precise settlement coverage. The equal-name locations are deliberately fictional. The locale example does not activate or qualify French/Dutch UI catalogues.
|
||||
|
||||
## Evidence
|
||||
|
||||
Original validator plus the new negative controls **FAILED**: `Missing expected exception: must reject BE FR retains an incompatible filter`. This proved that the additional country-change declarations were not being checked, rather than merely counting more positive fixtures.
|
||||
|
||||
The final `rtk proxy node docs/global-jobs/00/validate-contracts.cjs --self-test` **PASSED**:
|
||||
|
||||
| Check | Final count |
|
||||
| --- | ---: |
|
||||
| Existing candidate rows / frozen status cells | 59 / 1,062 |
|
||||
| Synthetic nodes / typed edges | 21 / 13 |
|
||||
| Selection expectation cases | 16 |
|
||||
| Existing preference examples | 4 |
|
||||
| Country-change / locale-change expectations | 3 / 1 |
|
||||
| Rejected negative mutations | 30 |
|
||||
|
||||
The original 22 mutations are included in 30, not additional product tests. Eight new controls reject hidden removed-country filters, compatible-branch loss, absent explanation, rewritten saved definitions, locale-driven country/document changes, expansion broadening and same-label scope merging. These validate specification consistency; no browser, API, persistence, map or query-engine behavior is exercised.
|
||||
|
||||
Node syntax and Git source whitespace checks passed. Native red/green output and source/artifact hashes are under [evidence/multi-country](evidence/multi-country/SOURCE_RECEIPTS.json). The country matrix/CSV/geography decision Git bindings remain exactly those in the [original report](GEOGRAPHY_CONTRACT_QA.md); no refresh of external licensing/provider evidence is implied.
|
||||
|
||||
AST-only `graphify update . --no-cluster` completed exit 0: 19,848 nodes / 49,194 edges. Missing PDF/SQL extractors and 146 inputs yielding no symbols remain graph limitations. Generated graph files stay local/untracked; no semantic/LLM graph pass was run.
|
||||
|
||||
No application tests/build/browser, real geographic datasets, provider/model/translation service or human/native-language/device qualification was run. No central roadmap edit, runtime feature, qualification-status promotion, main merge or production deployment. Only normal development-branch Git publication is authorised.
|
||||
|
||||
## 20 November 2026 · existing saved-search compatibility
|
||||
|
||||
GJ-00 ADR-07 requires future migration to retain the original keyword, unresolved free-text location, search identity and dismissal/first-seen history. EUROPE-READY §§2 and 11 also require temporary geography changes to preserve named searches. The 19 November specification run above could establish neither database readback nor what the current discovery runner actually receives.
|
||||
|
||||
Two cases in `SavedJobSearchSqliteTests.Temporary_search_keeps_legacy_filters_and_dismissal_history` seed existing rows and historical dismissed results in SQLite, clear EF tracking, run a different ad hoc search and reload the named search. One stored value contains composed and decomposed accents with punctuation. The other has a Polish occupation keyword and an empty location. The strict discovery stub checks the original arguments on manual rerun. The final database read verifies the original search ID, name, filters, active state, bare external ID, original first-seen instant and dismissal. A repeated result updates last-seen and last-run and remains previously seen.
|
||||
|
||||
The test baseline was `6da2e79a8a8d5e77bf5d6d1acf12a762e1ae138a`. The saved-search entity, discovery controller, runner and pre-existing SQLite tests matched integration `245f2feaa8bee2db8f5da0797b3e33f6ef8b056e` byte for byte. The authoritative ADR blob in planning commit `0ec9f98e` was `dcde56f5435da64ca4ac4e4e1b0b69e29d9c6f2e`.
|
||||
|
||||
The locked restore used the local NuGet cache. .NET SDK 9.0.317 built and ran the following selection.
|
||||
|
||||
```powershell
|
||||
dotnet test JobTrackerApi.Tests/JobTrackerApi.Tests.csproj --no-restore --filter 'FullyQualifiedName~SavedJobSearchSqliteTests|FullyQualifiedName~SavedJobSearchAlertTests|FullyQualifiedName~JobDiscoveryControllerTests'
|
||||
```
|
||||
|
||||
**PASSED** 27 cases, including the two new cases. The breakdown was 12 SQLite persistence, 12 existing alert-worker and three existing discovery-controller cases. Failed 0, skipped 0. Local TRX SHA-256 was `933ab479e2d7d7b2b704a8341947673c2c5c5ff90c45cfa80ad8ec4ae128efee`. No provider or model was contacted.
|
||||
|
||||
The AST-only Graphify refresh passed with 19,854 nodes and 49,213 edges. SQL extraction remained unavailable and 146 source inputs yielded no symbols. The generated graph stays local.
|
||||
|
||||
**NOT RUN** MariaDB, HTTP/browser, real providers, authenticated country/language preference updates, a migration and rollback. Current persisted location is a string. Empty means no location text. Existing rows carry no authority to interpret a string as a canonical place, country or radius. At GJ-06 entry, reuse these legacy cases against approved migration and rollback on MariaDB, alongside owner isolation and result history checks. GJ-01 entry requirements remain open.
|
||||
@@ -0,0 +1,72 @@
|
||||
{
|
||||
"base": "48861bca706637fdb217e0e834e67fe052113195",
|
||||
"policy": "LF-normalised UTF8 source, exact raw artifact bytes",
|
||||
"redSource": {
|
||||
"sha256Lf": "e9976a642147c1760dde193a973c0b6be9af8344e1cb98760218bafef65a696c",
|
||||
"derivation": "48861bca validator plus exactly the eight new selfTest cases after invalid journey country; current fixture unchanged"
|
||||
},
|
||||
"sources": [
|
||||
{
|
||||
"file": "docs/global-jobs/00/validate-contracts.cjs",
|
||||
"sha256Lf": "03963222086071855af9c41c8df77fe9ad9a76952f86f813a42512af9b43e782"
|
||||
},
|
||||
{
|
||||
"file": "docs/global-jobs/00/GEOGRAPHY_CONTRACT_FIXTURES.json",
|
||||
"sha256Lf": "c6c9f324369195d05410df57d04e9d9c799bd6f3fda453d156973edee5e5b231"
|
||||
}
|
||||
],
|
||||
"artifacts": [
|
||||
{
|
||||
"file": "red.log",
|
||||
"bytes": 1097,
|
||||
"sha256": "6eaab9962a4f9998d8ae79592529f28f46476e6ea447a46b24439122423d183c"
|
||||
},
|
||||
{
|
||||
"file": "green.json",
|
||||
"bytes": 277,
|
||||
"sha256": "fe313355b73dbfea34d66ed91f57b241ce3e1e976a65f4c3d4a7e1eb9972b643"
|
||||
},
|
||||
{
|
||||
"file": "green.stderr.log",
|
||||
"bytes": 0,
|
||||
"sha256": "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"
|
||||
}
|
||||
],
|
||||
"node": "v24.19.0",
|
||||
"results": {
|
||||
"countries": 59,
|
||||
"coverageCells": 1062,
|
||||
"syntheticNodes": 21,
|
||||
"syntheticScenarios": 16,
|
||||
"preferenceJourneys": 4,
|
||||
"countryChangeInvariants": 3,
|
||||
"localeChangeInvariants": 1,
|
||||
"qualification": "offline specification consistency only",
|
||||
"rejectedMutations": 30
|
||||
},
|
||||
"limits": [
|
||||
"Offline specification only",
|
||||
"No coverage or acceptance promotion",
|
||||
"External source rights not refreshed"
|
||||
],
|
||||
"checks": {
|
||||
"syntax": {
|
||||
"command": "rtk proxy node --check docs/global-jobs/00/validate-contracts.cjs",
|
||||
"exitCode": 0
|
||||
},
|
||||
"diff": {
|
||||
"command": "rtk git diff --check",
|
||||
"exitCode": 0
|
||||
},
|
||||
"sourceArtifactBindings": {
|
||||
"exitCode": 0
|
||||
},
|
||||
"graph": {
|
||||
"command": "rtk proxy graphify update . --no-cluster",
|
||||
"exitCode": 0,
|
||||
"nodes": 19848,
|
||||
"edges": 49194,
|
||||
"scope": "AST only; generated graph untracked"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,11 @@
|
||||
{
|
||||
"countries": 59,
|
||||
"coverageCells": 1062,
|
||||
"syntheticNodes": 21,
|
||||
"syntheticScenarios": 16,
|
||||
"preferenceJourneys": 4,
|
||||
"countryChangeInvariants": 3,
|
||||
"localeChangeInvariants": 1,
|
||||
"qualification": "offline specification consistency only",
|
||||
"rejectedMutations": 30
|
||||
}
|
||||
@@ -0,0 +1,192 @@
|
||||
// Offline specification QA only; never imported by the application.
|
||||
const assert = require('node:assert/strict');
|
||||
const { execFileSync } = require('node:child_process');
|
||||
const { readFileSync } = require('node:fs');
|
||||
const path = require('node:path');
|
||||
const root = path.resolve(__dirname, '../../..');
|
||||
const git = (...args) => execFileSync('git', args, { cwd: root, encoding: 'utf8', maxBuffer: 4 * 1024 * 1024 });
|
||||
const load = () => JSON.parse(readFileSync(path.join(__dirname, 'GEOGRAPHY_CONTRACT_FIXTURES.json'), 'utf8'));
|
||||
function validate(fixture, matrix, coverage) {
|
||||
assert.equal(fixture.schema, 1);
|
||||
assert.equal(fixture.purpose, 'offline-specification-only');
|
||||
assert.equal(fixture.sourceCommit, '39fb9df06904e44916e258da0ed975dd46b9691c');
|
||||
assert.equal(fixture.baseline, 'eb2538772e1bfabbeb291e4a5efa177c79074de1');
|
||||
const unique = (values, label) => assert.equal(new Set(values).size, values.length, `duplicate ${label}`);
|
||||
const sorted = values => [...values].sort();
|
||||
const codes = [...matrix.matchAll(/^\| [^|]+ \| ([A-Z]{2}) \|/gm)].map(match => match[1]);
|
||||
assert.equal(codes.length, 59);
|
||||
unique(codes, 'matrix code');
|
||||
assert(matrix.includes('XK is a CLDR user-assigned territory code, not ISO 3166-1'));
|
||||
// This pinned CSV has no quoted fields; fail rather than silently parse a new format.
|
||||
assert(!coverage.includes('"'), 'CSV format changed; review parser');
|
||||
const [header, ...lines] = coverage.trim().split(/\r?\n/).map(line => line.split(','));
|
||||
const columns = 'territoryCode,scopeReview,countrySelectable,administrativeHierarchy,canonicalResolution,mapCountrySwitching,canonicalLocationFilters,providerCoverage,countryAwareResults,multiCountrySavedSearches,marketLanguageOptions,marketCatalogue,currencyAndTimezone,mobile,accessibility,countryTestEvidence,humanApproval,productionAvailability,existingNavFixture'.split(',');
|
||||
assert.deepEqual(header, columns);
|
||||
unique(lines.map(row => row[0]), 'coverage code');
|
||||
assert.deepEqual(sorted(lines.map(row => row[0])), sorted(codes));
|
||||
const statuses = ['NOT IMPLEMENTED', 'IMPLEMENTED', 'TESTED', 'BLOCKED', 'AWAITING REVIEW', 'ACCEPTED', 'RELEASED'];
|
||||
for (const row of lines) {
|
||||
assert.equal(row.length, columns.length);
|
||||
for (let i = 1; i < row.length; i++) {
|
||||
assert(statuses.includes(row[i]), `invalid status ${row[0]} ${columns[i]}`);
|
||||
let expected = 'NOT IMPLEMENTED';
|
||||
if (['scopeReview', 'humanApproval'].includes(columns[i])) expected = 'AWAITING REVIEW';
|
||||
if (columns[i] === 'administrativeHierarchy' && ['NO', 'SE', 'GB'].includes(row[0])) expected = 'AWAITING REVIEW';
|
||||
if (columns[i] === 'productionAvailability' || (columns[i] === 'providerCoverage' && ['NO', 'SE', 'GB'].includes(row[0]))) expected = 'BLOCKED';
|
||||
if (columns[i] === 'existingNavFixture' && row[0] === 'NO') expected = 'TESTED';
|
||||
assert.equal(row[i], expected, `unqualified coverage change ${row[0]} ${columns[i]}`);
|
||||
}
|
||||
}
|
||||
const nodes = new Map(fixture.nodes.map(node => [node.id, node]));
|
||||
unique(fixture.nodes.map(node => node.id), 'node ID');
|
||||
for (const node of fixture.nodes) {
|
||||
assert(codes.includes(node.country));
|
||||
assert(['county', 'municipality', 'town', 'settlement', 'state', 'region'].includes(node.type));
|
||||
assert(node.id.startsWith(`s:${node.country}:${node.type}:`), 'typed country identity mismatch');
|
||||
assert.equal(node.edition, 'synthetic-1');
|
||||
assert.equal(node.provenance, 'synthetic-no-boundary-claim');
|
||||
assert.equal(typeof node.label, 'string');
|
||||
assert(node.label.trim());
|
||||
assert(!('coordinates' in node || 'geometry' in node || 'providerCode' in node), 'unqualified spatial/provider data');
|
||||
}
|
||||
unique(fixture.edges.map(edge => JSON.stringify(edge)), 'edge');
|
||||
for (const edge of fixture.edges) {
|
||||
assert(nodes.has(edge.child) && nodes.has(edge.parent), 'unresolved edge');
|
||||
assert.notEqual(edge.child, edge.parent);
|
||||
assert.equal(nodes.get(edge.child).country, nodes.get(edge.parent).country, 'cross-country edge');
|
||||
assert(['administrative-parent', 'settlement-intersects', 'same-footprint'].includes(edge.type));
|
||||
if (edge.type === 'settlement-intersects') assert.equal(nodes.get(edge.child).type, 'settlement');
|
||||
}
|
||||
// Reachability checks fixture declarations only; this is not a runtime scope compiler.
|
||||
function ancestor(child, parent, trail = []) {
|
||||
assert(!trail.includes(child), 'administrative cycle');
|
||||
return fixture.edges.filter(edge => edge.type === 'administrative-parent' && edge.child === child)
|
||||
.some(edge => edge.parent === parent || ancestor(edge.parent, parent, [...trail, child]));
|
||||
}
|
||||
for (const node of nodes.keys()) assert(!ancestor(node, node), 'administrative cycle');
|
||||
function checkBranches(branches, countries) {
|
||||
unique(countries, 'search country');
|
||||
assert(countries.every(country => codes.includes(country)));
|
||||
unique(branches.map(branch => branch.root), 'branch');
|
||||
for (const branch of branches) {
|
||||
assert(nodes.has(branch.root), 'unresolved scope');
|
||||
assert(countries.includes(nodes.get(branch.root).country), 'incompatible country scope');
|
||||
unique(branch.refinements, 'refinement');
|
||||
for (const refinement of branch.refinements) {
|
||||
assert(nodes.has(refinement) && ancestor(refinement, branch.root), 'invalid refinement');
|
||||
assert.equal(nodes.get(refinement).country, nodes.get(branch.root).country);
|
||||
}
|
||||
}
|
||||
}
|
||||
unique(fixture.scenarios.map(scenario => scenario.name), 'scenario name');
|
||||
assert(fixture.scenarios.length >= 12);
|
||||
for (const scenario of fixture.scenarios) {
|
||||
checkBranches(scenario.branches, scenario.countries);
|
||||
assert(scenario.expanded.every(id => nodes.has(id)));
|
||||
const leaves = scenario.branches.flatMap(branch => branch.refinements.length
|
||||
? branch.refinements.filter(id => !branch.refinements.some(other => id !== other && ancestor(other, id))) : [branch.root]);
|
||||
unique(leaves, 'effective scope');
|
||||
for (const surface of ['query', 'tree', 'map']) {
|
||||
assert.deepEqual(sorted(scenario.expected[surface]), sorted(leaves), `incorrect ${surface} scope: ${scenario.name}`);
|
||||
}
|
||||
if (scenario.equivalentTo) {
|
||||
const other = fixture.scenarios.find(item => item.name === scenario.equivalentTo);
|
||||
assert(other && other !== scenario, 'missing equivalent selection');
|
||||
assert.deepEqual(scenario.countries, other.countries, 'expansion changes search countries');
|
||||
assert.deepEqual(scenario.branches, other.branches, 'expansion changes selected branches');
|
||||
assert.deepEqual(scenario.expected, other.expected, 'expansion changes effective scope');
|
||||
}
|
||||
assert.deepEqual(JSON.parse(JSON.stringify(scenario)), scenario, 'fixture roundtrip');
|
||||
}
|
||||
const countryChanges = [fixture.countryChange, ...fixture.additionalCountryChanges];
|
||||
for (const change of countryChanges) {
|
||||
checkBranches(change.beforeBranches, change.beforeCountries);
|
||||
checkBranches(change.afterBranches, change.afterCountries);
|
||||
const retained = change.beforeBranches.filter(branch => change.afterCountries.includes(nodes.get(branch.root).country));
|
||||
assert.deepEqual(change.afterBranches, retained, 'only incompatible filters may clear');
|
||||
assert.deepEqual(change.cleared, change.beforeBranches.filter(branch => !retained.includes(branch)).map(branch => branch.root));
|
||||
assert(change.explanation.trim(), 'country change explanation required');
|
||||
assert.deepEqual(change.after, change.before, 'unrelated preferences/saved search changed');
|
||||
assert.deepEqual(Object.keys(change.before).sort(), ['adLanguages', 'documentLanguages', 'residence', 'savedSearch', 'uiLocale']);
|
||||
}
|
||||
const { uiLocale: previousLocale, ...previousSelection } = fixture.localeChange.before;
|
||||
const { uiLocale: nextLocale, ...nextSelection } = fixture.localeChange.after;
|
||||
assert(typeof previousLocale === 'string' && previousLocale.trim());
|
||||
assert(typeof nextLocale === 'string' && nextLocale.trim());
|
||||
assert.notEqual(previousLocale, nextLocale, 'fixture must exercise an actual locale change');
|
||||
checkBranches(previousSelection.branches, previousSelection.countries);
|
||||
checkBranches(nextSelection.branches, nextSelection.countries);
|
||||
assert.deepEqual(nextSelection, previousSelection, 'locale change rewrites search or document preferences');
|
||||
assert.equal(fixture.journeys.length, 4);
|
||||
for (const journey of fixture.journeys) {
|
||||
assert(codes.includes(journey.residence));
|
||||
assert(journey.countries.length && journey.countries.every(country => codes.includes(country)));
|
||||
unique(journey.countries, 'journey country');
|
||||
assert.equal(typeof journey.uiLocale, 'string');
|
||||
assert(journey.adLanguages.length && journey.documentLanguages.length);
|
||||
assert(journey.adLanguages.every(language => typeof language === 'string'));
|
||||
assert(journey.documentLanguages.every(language => typeof language === 'string'));
|
||||
}
|
||||
return { countries: codes.length, coverageCells: lines.length * (columns.length - 1), syntheticNodes: nodes.size,
|
||||
syntheticScenarios: fixture.scenarios.length, preferenceJourneys: fixture.journeys.length, countryChangeInvariants: countryChanges.length,
|
||||
localeChangeInvariants: 1,
|
||||
qualification: 'offline specification consistency only' };
|
||||
}
|
||||
function selfTest(fixture, matrix, coverage) {
|
||||
const cases = [
|
||||
['false release coverage', (f, m, c) => [f, m, c.replace('BLOCKED', 'RELEASED')]],
|
||||
['cross-country edge', f => { f.edges[0].parent = 's:NO:county:vestfold'; }],
|
||||
['invalid refinement', f => { f.scenarios[1].branches[0].refinements = ['s:NO:municipality:tonsberg']; }],
|
||||
['unqualified provenance', f => { f.nodes[0].provenance = 'licensed-real-data'; }],
|
||||
['duplicate country', (f, m, c) => [f, m, c + c.trim().split('\n')[1] + '\n']],
|
||||
['missing country', (f, m, c) => [f, m, c.trim().split('\n').slice(0, -1).join('\n')]],
|
||||
['invented country', (f, m, c) => [f, m, c.replace('AD,', 'ZZ,')]],
|
||||
['invalid status', (f, m, c) => [f, m, c.replace('BLOCKED', 'HEALTHY')]],
|
||||
['NO fixture credited to GB', (f, m, c) => [f, m, c.replace(/^GB,(.*),NOT IMPLEMENTED$/m, 'GB,$1,TESTED')]],
|
||||
['wrong type identity', f => { f.nodes[0].type = 'town'; }],
|
||||
['missing edition', f => { delete f.nodes[0].edition; }],
|
||||
['invented geometry', f => { f.nodes[0].geometry = {}; }],
|
||||
['unresolved scope', f => { f.scenarios[0].branches[0].root = 'missing'; }],
|
||||
['parent incorrectly ORed with town', f => { f.scenarios[1].expected.query.push(f.scenarios[1].branches[0].root); }],
|
||||
['map divergent from query', f => { f.scenarios[1].expected.map = []; }],
|
||||
['unrelated language reset', f => { f.countryChange.after.uiLocale = 'nb-NO'; }],
|
||||
['saved search overwritten', f => { f.countryChange.after.savedSearch = 'rewritten'; }],
|
||||
['invisible country filter', f => { f.countryChange.afterBranches = f.countryChange.beforeBranches; }],
|
||||
['silent country clearing', f => { f.countryChange.explanation = ''; }],
|
||||
['settlement overlap used as containment', f => {
|
||||
f.scenarios[9].branches[0].refinements = ['s:SE:settlement:stockholm'];
|
||||
}],
|
||||
['administrative cycle', f => { f.edges.push({child: f.edges[0].parent, parent: f.edges[0].child, type: 'administrative-parent'}); }],
|
||||
['invalid journey country', f => { f.journeys[0].countries = ['ZZ']; }],
|
||||
['BE FR retains an incompatible filter', f => { f.additionalCountryChanges[0].afterBranches = f.additionalCountryChanges[0].beforeBranches; }],
|
||||
['BE FR drops a compatible branch', f => { f.additionalCountryChanges[0].afterBranches = []; }],
|
||||
['country change lacks an explanation', f => { f.additionalCountryChanges[1].explanation = ''; }],
|
||||
['temporary country change rewrites a saved definition', f => { f.additionalCountryChanges[0].after.savedSearch.countries = ['BE']; }],
|
||||
['locale switch changes country scope', f => { f.localeChange.after.countries = ['BE']; }],
|
||||
['locale switch changes document language', f => { f.localeChange.after.documentLanguages = ['nl']; }],
|
||||
['expansion broadens the selected branch', f => {
|
||||
f.scenarios[13].branches[0].refinements = [];
|
||||
for (const surface of ['query', 'tree', 'map']) f.scenarios[13].expected[surface] = ['s:BE:region:brussels', 's:FR:town:paris'];
|
||||
}],
|
||||
['equal labels merge distinct countries', f => { f.scenarios[15].expected.query.pop(); }],
|
||||
];
|
||||
for (const [name, mutate] of cases) {
|
||||
const candidate = structuredClone(fixture);
|
||||
const inputs = mutate(candidate, matrix, coverage) || [candidate, matrix, coverage];
|
||||
assert.throws(() => validate(...inputs), undefined, `must reject ${name}`);
|
||||
}
|
||||
return cases.length;
|
||||
}
|
||||
const fixture = load();
|
||||
// Read committed inputs directly; never copy a second register or use another worktree's dirty files.
|
||||
const bindings = [
|
||||
[fixture.sourceCommit, 'docs/i18n/00/EUROPE_COUNTRY_LANGUAGE_MATRIX.md', '4b88eb52e91d1c1ad0bb9082ed3ce075e0602dbd'],
|
||||
[fixture.sourceCommit, 'docs/i18n/00/EUROPE_RELEASE_COVERAGE.csv', '395fc09934a516a2445fddb092b5de18c9469080'],
|
||||
['0ec9f98e6ed4a646fc5e017d8eb6fade07653f37', 'docs/global-jobs/00/GEOGRAPHY_DECISIONS.md', '48f108ef02648f53490ae505b223ebff321264bb'],
|
||||
];
|
||||
for (const [commit, file, blob] of bindings) assert.equal(git('rev-parse', `${commit}:${file}`).trim(), blob, `source binding: ${file}`);
|
||||
const matrix = git('show', `${fixture.sourceCommit}:docs/i18n/00/EUROPE_COUNTRY_LANGUAGE_MATRIX.md`);
|
||||
const coverage = git('show', `${fixture.sourceCommit}:docs/i18n/00/EUROPE_RELEASE_COVERAGE.csv`);
|
||||
const result = validate(fixture, matrix, coverage);
|
||||
if (process.argv.includes('--self-test')) result.rejectedMutations = selfTest(fixture, matrix, coverage);
|
||||
console.log(JSON.stringify(result, null, 2));
|
||||
Reference in New Issue
Block a user