Compare commits

..

2 Commits

Author SHA1 Message Date
cesnimda 6da2e79a8a test(global-jobs): extend offline multi-country contracts 2026-11-19 14:12:47 +01:00
cesnimda 48861bca70 test(global-jobs): validate offline geography contracts 2026-11-17 21:05:51 +01:00
10 changed files with 1504 additions and 211 deletions
File diff suppressed because it is too large Load Diff
@@ -0,0 +1,56 @@
# Offline European geography contract QA
17 November 2026. Bounded documentation/tooling increment authorised by the current direct roadmap continuation. This is executable specification QA, not GJ-01/GJ-02 implementation or acceptance. No application imports, dependencies, settings, migrations, HTTP requests, provider/model calls or qualification statuses change.
19 November: the [multi-country extension](GEOGRAPHY_MULTI_COUNTRY_QA.md) adds BE/FR and DE/PL fixtures, expansion and locale-change invariants. The outcomes below retain the original `48861bca` checkpoint; use the extension for current validator counts.
## Inputs and identity
Application baseline: `eb2538772e1bfabbeb291e4a5efa177c79074de1` (A3). Isolated branch `codex/global-geo-contracts`; worktree `E:/Storage/Projects/Active/temp docs/jobjakt-local-build/global-geo-contracts`.
The validator reads committed Git blobs directly. It does not copy a country registry, inspect another checkout's uncommitted data or require the I18N worktree to remain present. Required commits must exist locally; missing objects fail execution rather than falling back to stale checkout files. It performs no fetch.
| Source commit | Repository path | Exact Git blob |
| --- | --- | --- |
| `39fb9df06904e44916e258da0ed975dd46b9691c` | `docs/i18n/00/EUROPE_COUNTRY_LANGUAGE_MATRIX.md` | `4b88eb52e91d1c1ad0bb9082ed3ce075e0602dbd` |
| `39fb9df06904e44916e258da0ed975dd46b9691c` | `docs/i18n/00/EUROPE_RELEASE_COVERAGE.csv` | `395fc09934a516a2445fddb092b5de18c9469080` |
| `0ec9f98e6ed4a646fc5e017d8eb6fade07653f37` | `docs/global-jobs/00/GEOGRAPHY_DECISIONS.md` | `48f108ef02648f53490ae505b223ebff321264bb` |
The I18N source commit was inspected in the existing `i18n-message-census` worktree. Both matrix/CSV blob identities also match A3 exactly. All inputs are available in this local repository object store. The GJ planning documents remain on their separate planning history; they are not merged or replaced here. The geography decision blob is bound for traceability; its prose semantics were reviewed by a human-readable source inspection, not automatically interpreted by the script.
Authority: Prompt 7 and the GJ pack retain predecessor/initiative gates; GJ-00 geography decisions define branch refinement and typed relationships. The later EUROPE-READY owner addendum §§4/14 requires country/refinement contract tests and §15 preserves shared owners and gates. Existing `docs/i18n/00/IMPLEMENTATION_PLAN.md` permits future fixture design without inventing dependent runtime. Current direct instruction narrows this increment to offline documentation contracts. It does not authorise a runtime scope compiler.
## What runs
From the repository root, using installed Node and Git only:
```text
rtk proxy node docs/global-jobs/00/validate-contracts.cjs --self-test
rtk proxy node --check docs/global-jobs/00/validate-contracts.cjs
rtk git diff --check
```
The first command checks the matrix's exact 59-code roster and 1,062 coverage cells (18 columns per country); validates status vocabulary and the frozen qualification snapshot, including the sole existing Norway NAV fixture result; and checks XK's explicit non-ISO caveat. Updating any status requires a separately reviewed source/evidence change and validator update. This snapshot guard is not a general release approval engine.
`GEOGRAPHY_CONTRACT_FIXTURES.json` contains 13 deliberately synthetic typed identities, seven typed edges and 12 selection expectation cases. Every ID uses the `s:` namespace, edition `synthetic-1`, and explicit synthetic provenance. Display labels resemble representative locations, but neither the IDs nor edges are authoritative geographic data or a licensed boundary dataset. Administrative reachability is used only to check fixture expectations; settlement intersection and shared footprint cannot substitute for administrative containment. No query plan is emitted and no function is exported for application use.
Cases cover whole Warwickshire, one/two towns, removing refinements, independent Bergen OR, Vestfold/Tønsberg, distinct Oslo identities, Stockholm municipality versus settlement and parent/country removal. Query/tree/map are declared expected scope lists whose consistency is checked; no UI, query service or map is exercised. Four preference examples cover EN/NO→GB, NB→SE, PL→DE and FR→BE+FR as separate residence/UI/ad/document-language fields. One explicit country-change fixture preserves unrelated preferences and a saved-search sentinel, removes only incompatible branches and requires an explanation. JSON roundtrip checks apply to these fixtures only, not server persistence.
## Validation outcome
Executed with Node `v24.19.0`:
- PASS: 59 country rows / 1,062 coverage cells; 13 nodes, 12 selection cases, four preference examples and one country-change expectation.
- PASS: 22 negative mutations rejected. They cover false release claims, missing/duplicate/invented countries, invalid status, crediting the NAV fixture to GB, typed identity/edition/provenance errors, invented geometry, cross-country edges, unresolved scopes, invalid refinements, broad-parent leakage, map divergence, language/saved-search resets, invisible filters, missing explanations, settlement overlap treated as containment, administrative cycles and invalid journey country.
- PASS: Node syntax check and staged Git diff whitespace check (exit 0 each).
- RED evidence: before implementation, the permissive validator failed the negative suite with `Missing expected exception: must reject false release coverage` (exit 1). First implemented run then caught the real CSV's NO/SE/GB administrative hierarchy `AWAITING REVIEW` nuance; the corrected frozen-snapshot guard preserves that existing status.
The 22 mutations are checks of the validator, not 22 additional product tests. The counts above describe one successful final contract run; intermediate reruns are not added. Syntax/diff verification is recorded separately from product tests.
Required `rtk proxy graphify update .` completed exit 0 with 19,842 nodes / 48,008 edges, explicitly AST-only/no LLM. It retained warnings for unavailable PDF/SQL extractors and 146 code files yielding no symbols. Generated `graphify-out/` is local/untracked and excluded from this documentation commit; graph counts are structural orientation, not acceptance tests.
## Gates and limits
All 59 entries remain candidate scope with their existing statuses. Real geography licences, exact dataset epochs/IDs/geometry, provider rights, live operation, map attribution/privacy, native-language/device/AT evidence and release approval remain open. Phase 10 D02/frozen-candidate acceptance, Product Review, GJ implementation authority and sequential accepted stages are unchanged. No precise town/radius, accessible tree, map switching, server preference persistence or country-specific provider behavior is qualified by these checks.
The existing NAV municipality substring limitation remains assigned to GJ geography work; this increment does not establish or repair a separate Norway regression. No main merge, orchestrator action, push or deployment occurs. Application builds/browser/backend/hosted/provider/model suites were intentionally not run for documentation-only tooling.
@@ -0,0 +1,42 @@
# Multi-country geography specification QA
19 November 2026. Extends the accepted offline contract checkpoint `48861bca706637fdb217e0e834e67fe052113195` on `codex/global-geo-contracts`. Application baseline remains `eb2538772e1bfabbeb291e4a5efa177c79074de1`; no application source is modified or claimed current by these checks.
## Eligible gap and gates
The current central TODO still gates GJ-01 on Phase 10 D02, Product Review and initiative approval. GJ-02 runtime geography, licensed datasets, providers/maps, locale rollout and release approval remain separate. The existing 59-country coverage snapshot retains every status. Current owner scope permits useful offline specification qualification only.
The earlier corpus had GB/NO cross-border scope but no BE/FR or DE/PL location-selection examples; its DE/FR reference nodes were unused. Its four preference examples checked field shapes, while only one country-change expectation was validated and no locale-change expectation preserved canonical selection. This increment extends that same corpus and small validator; it creates no second country/locale registry or runtime compiler.
## Added contracts
- BE/FR independent city branches and DE/PL independent city branches combine as OR using distinct country/type IDs.
- Expanding the BE/FR tree has exactly the same declared countries, branches and query/tree/map scopes as the collapsed counterpart.
- Two intentionally fictional locations called `Synthetic Riverside` in different countries retain distinct identifiers and both effective scopes. Labels cannot merge them.
- Removing FR from a temporary BE/FR query or DE from DE/PL removes only the incompatible branch and explains the change. It preserves residence, UI/ad/document languages and the separate named saved-search definition.
- A declared FR→NL UI-locale change preserves countries, canonical branch IDs, residence, ad/document languages and the literal named saved search.
All added identities/relations remain under synthetic namespace `s:`, edition `synthetic-1`, provenance `synthetic-no-boundary-claim`. Familiar labels do not establish real administrative containment, legal language status, licensed data/geometry or precise settlement coverage. The equal-name locations are deliberately fictional. The locale example does not activate or qualify French/Dutch UI catalogues.
## Evidence
Original validator plus the new negative controls **FAILED**: `Missing expected exception: must reject BE FR retains an incompatible filter`. This proved that the additional country-change declarations were not being checked, rather than merely counting more positive fixtures.
The final `rtk proxy node docs/global-jobs/00/validate-contracts.cjs --self-test` **PASSED**:
| Check | Final count |
| --- | ---: |
| Existing candidate rows / frozen status cells | 59 / 1,062 |
| Synthetic nodes / typed edges | 21 / 13 |
| Selection expectation cases | 16 |
| Existing preference examples | 4 |
| Country-change / locale-change expectations | 3 / 1 |
| Rejected negative mutations | 30 |
The original 22 mutations are included in 30, not additional product tests. Eight new controls reject hidden removed-country filters, compatible-branch loss, absent explanation, rewritten saved definitions, locale-driven country/document changes, expansion broadening and same-label scope merging. These validate specification consistency; no browser, API, persistence, map or query-engine behavior is exercised.
Node syntax and Git source whitespace checks passed. Native red/green output and source/artifact hashes are under [evidence/multi-country](evidence/multi-country/SOURCE_RECEIPTS.json). The country matrix/CSV/geography decision Git bindings remain exactly those in the [original report](GEOGRAPHY_CONTRACT_QA.md); no refresh of external licensing/provider evidence is implied.
AST-only `graphify update . --no-cluster` completed exit 0: 19,848 nodes / 49,194 edges. Missing PDF/SQL extractors and 146 inputs yielding no symbols remain graph limitations. Generated graph files stay local/untracked; no semantic/LLM graph pass was run.
No application tests/build/browser, real geographic datasets, provider/model/translation service or human/native-language/device qualification was run. No central roadmap edit, runtime feature, qualification-status promotion, main merge or production deployment. Only normal development-branch Git publication is authorised.
@@ -0,0 +1,72 @@
{
"base": "48861bca706637fdb217e0e834e67fe052113195",
"policy": "LF-normalised UTF8 source, exact raw artifact bytes",
"redSource": {
"sha256Lf": "e9976a642147c1760dde193a973c0b6be9af8344e1cb98760218bafef65a696c",
"derivation": "48861bca validator plus exactly the eight new selfTest cases after invalid journey country; current fixture unchanged"
},
"sources": [
{
"file": "docs/global-jobs/00/validate-contracts.cjs",
"sha256Lf": "03963222086071855af9c41c8df77fe9ad9a76952f86f813a42512af9b43e782"
},
{
"file": "docs/global-jobs/00/GEOGRAPHY_CONTRACT_FIXTURES.json",
"sha256Lf": "c6c9f324369195d05410df57d04e9d9c799bd6f3fda453d156973edee5e5b231"
}
],
"artifacts": [
{
"file": "red.log",
"bytes": 1097,
"sha256": "6eaab9962a4f9998d8ae79592529f28f46476e6ea447a46b24439122423d183c"
},
{
"file": "green.json",
"bytes": 277,
"sha256": "fe313355b73dbfea34d66ed91f57b241ce3e1e976a65f4c3d4a7e1eb9972b643"
},
{
"file": "green.stderr.log",
"bytes": 0,
"sha256": "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"
}
],
"node": "v24.19.0",
"results": {
"countries": 59,
"coverageCells": 1062,
"syntheticNodes": 21,
"syntheticScenarios": 16,
"preferenceJourneys": 4,
"countryChangeInvariants": 3,
"localeChangeInvariants": 1,
"qualification": "offline specification consistency only",
"rejectedMutations": 30
},
"limits": [
"Offline specification only",
"No coverage or acceptance promotion",
"External source rights not refreshed"
],
"checks": {
"syntax": {
"command": "rtk proxy node --check docs/global-jobs/00/validate-contracts.cjs",
"exitCode": 0
},
"diff": {
"command": "rtk git diff --check",
"exitCode": 0
},
"sourceArtifactBindings": {
"exitCode": 0
},
"graph": {
"command": "rtk proxy graphify update . --no-cluster",
"exitCode": 0,
"nodes": 19848,
"edges": 49194,
"scope": "AST only; generated graph untracked"
}
}
}
@@ -0,0 +1,11 @@
{
"countries": 59,
"coverageCells": 1062,
"syntheticNodes": 21,
"syntheticScenarios": 16,
"preferenceJourneys": 4,
"countryChangeInvariants": 3,
"localeChangeInvariants": 1,
"qualification": "offline specification consistency only",
"rejectedMutations": 30
}
+192
View File
@@ -0,0 +1,192 @@
// Offline specification QA only; never imported by the application.
const assert = require('node:assert/strict');
const { execFileSync } = require('node:child_process');
const { readFileSync } = require('node:fs');
const path = require('node:path');
const root = path.resolve(__dirname, '../../..');
const git = (...args) => execFileSync('git', args, { cwd: root, encoding: 'utf8', maxBuffer: 4 * 1024 * 1024 });
const load = () => JSON.parse(readFileSync(path.join(__dirname, 'GEOGRAPHY_CONTRACT_FIXTURES.json'), 'utf8'));
function validate(fixture, matrix, coverage) {
assert.equal(fixture.schema, 1);
assert.equal(fixture.purpose, 'offline-specification-only');
assert.equal(fixture.sourceCommit, '39fb9df06904e44916e258da0ed975dd46b9691c');
assert.equal(fixture.baseline, 'eb2538772e1bfabbeb291e4a5efa177c79074de1');
const unique = (values, label) => assert.equal(new Set(values).size, values.length, `duplicate ${label}`);
const sorted = values => [...values].sort();
const codes = [...matrix.matchAll(/^\| [^|]+ \| ([A-Z]{2}) \|/gm)].map(match => match[1]);
assert.equal(codes.length, 59);
unique(codes, 'matrix code');
assert(matrix.includes('XK is a CLDR user-assigned territory code, not ISO 3166-1'));
// This pinned CSV has no quoted fields; fail rather than silently parse a new format.
assert(!coverage.includes('"'), 'CSV format changed; review parser');
const [header, ...lines] = coverage.trim().split(/\r?\n/).map(line => line.split(','));
const columns = 'territoryCode,scopeReview,countrySelectable,administrativeHierarchy,canonicalResolution,mapCountrySwitching,canonicalLocationFilters,providerCoverage,countryAwareResults,multiCountrySavedSearches,marketLanguageOptions,marketCatalogue,currencyAndTimezone,mobile,accessibility,countryTestEvidence,humanApproval,productionAvailability,existingNavFixture'.split(',');
assert.deepEqual(header, columns);
unique(lines.map(row => row[0]), 'coverage code');
assert.deepEqual(sorted(lines.map(row => row[0])), sorted(codes));
const statuses = ['NOT IMPLEMENTED', 'IMPLEMENTED', 'TESTED', 'BLOCKED', 'AWAITING REVIEW', 'ACCEPTED', 'RELEASED'];
for (const row of lines) {
assert.equal(row.length, columns.length);
for (let i = 1; i < row.length; i++) {
assert(statuses.includes(row[i]), `invalid status ${row[0]} ${columns[i]}`);
let expected = 'NOT IMPLEMENTED';
if (['scopeReview', 'humanApproval'].includes(columns[i])) expected = 'AWAITING REVIEW';
if (columns[i] === 'administrativeHierarchy' && ['NO', 'SE', 'GB'].includes(row[0])) expected = 'AWAITING REVIEW';
if (columns[i] === 'productionAvailability' || (columns[i] === 'providerCoverage' && ['NO', 'SE', 'GB'].includes(row[0]))) expected = 'BLOCKED';
if (columns[i] === 'existingNavFixture' && row[0] === 'NO') expected = 'TESTED';
assert.equal(row[i], expected, `unqualified coverage change ${row[0]} ${columns[i]}`);
}
}
const nodes = new Map(fixture.nodes.map(node => [node.id, node]));
unique(fixture.nodes.map(node => node.id), 'node ID');
for (const node of fixture.nodes) {
assert(codes.includes(node.country));
assert(['county', 'municipality', 'town', 'settlement', 'state', 'region'].includes(node.type));
assert(node.id.startsWith(`s:${node.country}:${node.type}:`), 'typed country identity mismatch');
assert.equal(node.edition, 'synthetic-1');
assert.equal(node.provenance, 'synthetic-no-boundary-claim');
assert.equal(typeof node.label, 'string');
assert(node.label.trim());
assert(!('coordinates' in node || 'geometry' in node || 'providerCode' in node), 'unqualified spatial/provider data');
}
unique(fixture.edges.map(edge => JSON.stringify(edge)), 'edge');
for (const edge of fixture.edges) {
assert(nodes.has(edge.child) && nodes.has(edge.parent), 'unresolved edge');
assert.notEqual(edge.child, edge.parent);
assert.equal(nodes.get(edge.child).country, nodes.get(edge.parent).country, 'cross-country edge');
assert(['administrative-parent', 'settlement-intersects', 'same-footprint'].includes(edge.type));
if (edge.type === 'settlement-intersects') assert.equal(nodes.get(edge.child).type, 'settlement');
}
// Reachability checks fixture declarations only; this is not a runtime scope compiler.
function ancestor(child, parent, trail = []) {
assert(!trail.includes(child), 'administrative cycle');
return fixture.edges.filter(edge => edge.type === 'administrative-parent' && edge.child === child)
.some(edge => edge.parent === parent || ancestor(edge.parent, parent, [...trail, child]));
}
for (const node of nodes.keys()) assert(!ancestor(node, node), 'administrative cycle');
function checkBranches(branches, countries) {
unique(countries, 'search country');
assert(countries.every(country => codes.includes(country)));
unique(branches.map(branch => branch.root), 'branch');
for (const branch of branches) {
assert(nodes.has(branch.root), 'unresolved scope');
assert(countries.includes(nodes.get(branch.root).country), 'incompatible country scope');
unique(branch.refinements, 'refinement');
for (const refinement of branch.refinements) {
assert(nodes.has(refinement) && ancestor(refinement, branch.root), 'invalid refinement');
assert.equal(nodes.get(refinement).country, nodes.get(branch.root).country);
}
}
}
unique(fixture.scenarios.map(scenario => scenario.name), 'scenario name');
assert(fixture.scenarios.length >= 12);
for (const scenario of fixture.scenarios) {
checkBranches(scenario.branches, scenario.countries);
assert(scenario.expanded.every(id => nodes.has(id)));
const leaves = scenario.branches.flatMap(branch => branch.refinements.length
? branch.refinements.filter(id => !branch.refinements.some(other => id !== other && ancestor(other, id))) : [branch.root]);
unique(leaves, 'effective scope');
for (const surface of ['query', 'tree', 'map']) {
assert.deepEqual(sorted(scenario.expected[surface]), sorted(leaves), `incorrect ${surface} scope: ${scenario.name}`);
}
if (scenario.equivalentTo) {
const other = fixture.scenarios.find(item => item.name === scenario.equivalentTo);
assert(other && other !== scenario, 'missing equivalent selection');
assert.deepEqual(scenario.countries, other.countries, 'expansion changes search countries');
assert.deepEqual(scenario.branches, other.branches, 'expansion changes selected branches');
assert.deepEqual(scenario.expected, other.expected, 'expansion changes effective scope');
}
assert.deepEqual(JSON.parse(JSON.stringify(scenario)), scenario, 'fixture roundtrip');
}
const countryChanges = [fixture.countryChange, ...fixture.additionalCountryChanges];
for (const change of countryChanges) {
checkBranches(change.beforeBranches, change.beforeCountries);
checkBranches(change.afterBranches, change.afterCountries);
const retained = change.beforeBranches.filter(branch => change.afterCountries.includes(nodes.get(branch.root).country));
assert.deepEqual(change.afterBranches, retained, 'only incompatible filters may clear');
assert.deepEqual(change.cleared, change.beforeBranches.filter(branch => !retained.includes(branch)).map(branch => branch.root));
assert(change.explanation.trim(), 'country change explanation required');
assert.deepEqual(change.after, change.before, 'unrelated preferences/saved search changed');
assert.deepEqual(Object.keys(change.before).sort(), ['adLanguages', 'documentLanguages', 'residence', 'savedSearch', 'uiLocale']);
}
const { uiLocale: previousLocale, ...previousSelection } = fixture.localeChange.before;
const { uiLocale: nextLocale, ...nextSelection } = fixture.localeChange.after;
assert(typeof previousLocale === 'string' && previousLocale.trim());
assert(typeof nextLocale === 'string' && nextLocale.trim());
assert.notEqual(previousLocale, nextLocale, 'fixture must exercise an actual locale change');
checkBranches(previousSelection.branches, previousSelection.countries);
checkBranches(nextSelection.branches, nextSelection.countries);
assert.deepEqual(nextSelection, previousSelection, 'locale change rewrites search or document preferences');
assert.equal(fixture.journeys.length, 4);
for (const journey of fixture.journeys) {
assert(codes.includes(journey.residence));
assert(journey.countries.length && journey.countries.every(country => codes.includes(country)));
unique(journey.countries, 'journey country');
assert.equal(typeof journey.uiLocale, 'string');
assert(journey.adLanguages.length && journey.documentLanguages.length);
assert(journey.adLanguages.every(language => typeof language === 'string'));
assert(journey.documentLanguages.every(language => typeof language === 'string'));
}
return { countries: codes.length, coverageCells: lines.length * (columns.length - 1), syntheticNodes: nodes.size,
syntheticScenarios: fixture.scenarios.length, preferenceJourneys: fixture.journeys.length, countryChangeInvariants: countryChanges.length,
localeChangeInvariants: 1,
qualification: 'offline specification consistency only' };
}
function selfTest(fixture, matrix, coverage) {
const cases = [
['false release coverage', (f, m, c) => [f, m, c.replace('BLOCKED', 'RELEASED')]],
['cross-country edge', f => { f.edges[0].parent = 's:NO:county:vestfold'; }],
['invalid refinement', f => { f.scenarios[1].branches[0].refinements = ['s:NO:municipality:tonsberg']; }],
['unqualified provenance', f => { f.nodes[0].provenance = 'licensed-real-data'; }],
['duplicate country', (f, m, c) => [f, m, c + c.trim().split('\n')[1] + '\n']],
['missing country', (f, m, c) => [f, m, c.trim().split('\n').slice(0, -1).join('\n')]],
['invented country', (f, m, c) => [f, m, c.replace('AD,', 'ZZ,')]],
['invalid status', (f, m, c) => [f, m, c.replace('BLOCKED', 'HEALTHY')]],
['NO fixture credited to GB', (f, m, c) => [f, m, c.replace(/^GB,(.*),NOT IMPLEMENTED$/m, 'GB,$1,TESTED')]],
['wrong type identity', f => { f.nodes[0].type = 'town'; }],
['missing edition', f => { delete f.nodes[0].edition; }],
['invented geometry', f => { f.nodes[0].geometry = {}; }],
['unresolved scope', f => { f.scenarios[0].branches[0].root = 'missing'; }],
['parent incorrectly ORed with town', f => { f.scenarios[1].expected.query.push(f.scenarios[1].branches[0].root); }],
['map divergent from query', f => { f.scenarios[1].expected.map = []; }],
['unrelated language reset', f => { f.countryChange.after.uiLocale = 'nb-NO'; }],
['saved search overwritten', f => { f.countryChange.after.savedSearch = 'rewritten'; }],
['invisible country filter', f => { f.countryChange.afterBranches = f.countryChange.beforeBranches; }],
['silent country clearing', f => { f.countryChange.explanation = ''; }],
['settlement overlap used as containment', f => {
f.scenarios[9].branches[0].refinements = ['s:SE:settlement:stockholm'];
}],
['administrative cycle', f => { f.edges.push({child: f.edges[0].parent, parent: f.edges[0].child, type: 'administrative-parent'}); }],
['invalid journey country', f => { f.journeys[0].countries = ['ZZ']; }],
['BE FR retains an incompatible filter', f => { f.additionalCountryChanges[0].afterBranches = f.additionalCountryChanges[0].beforeBranches; }],
['BE FR drops a compatible branch', f => { f.additionalCountryChanges[0].afterBranches = []; }],
['country change lacks an explanation', f => { f.additionalCountryChanges[1].explanation = ''; }],
['temporary country change rewrites a saved definition', f => { f.additionalCountryChanges[0].after.savedSearch.countries = ['BE']; }],
['locale switch changes country scope', f => { f.localeChange.after.countries = ['BE']; }],
['locale switch changes document language', f => { f.localeChange.after.documentLanguages = ['nl']; }],
['expansion broadens the selected branch', f => {
f.scenarios[13].branches[0].refinements = [];
for (const surface of ['query', 'tree', 'map']) f.scenarios[13].expected[surface] = ['s:BE:region:brussels', 's:FR:town:paris'];
}],
['equal labels merge distinct countries', f => { f.scenarios[15].expected.query.pop(); }],
];
for (const [name, mutate] of cases) {
const candidate = structuredClone(fixture);
const inputs = mutate(candidate, matrix, coverage) || [candidate, matrix, coverage];
assert.throws(() => validate(...inputs), undefined, `must reject ${name}`);
}
return cases.length;
}
const fixture = load();
// Read committed inputs directly; never copy a second register or use another worktree's dirty files.
const bindings = [
[fixture.sourceCommit, 'docs/i18n/00/EUROPE_COUNTRY_LANGUAGE_MATRIX.md', '4b88eb52e91d1c1ad0bb9082ed3ce075e0602dbd'],
[fixture.sourceCommit, 'docs/i18n/00/EUROPE_RELEASE_COVERAGE.csv', '395fc09934a516a2445fddb092b5de18c9469080'],
['0ec9f98e6ed4a646fc5e017d8eb6fade07653f37', 'docs/global-jobs/00/GEOGRAPHY_DECISIONS.md', '48f108ef02648f53490ae505b223ebff321264bb'],
];
for (const [commit, file, blob] of bindings) assert.equal(git('rev-parse', `${commit}:${file}`).trim(), blob, `source binding: ${file}`);
const matrix = git('show', `${fixture.sourceCommit}:docs/i18n/00/EUROPE_COUNTRY_LANGUAGE_MATRIX.md`);
const coverage = git('show', `${fixture.sourceCommit}:docs/i18n/00/EUROPE_RELEASE_COVERAGE.csv`);
const result = validate(fixture, matrix, coverage);
if (process.argv.includes('--self-test')) result.rejectedMutations = selfTest(fixture, matrix, coverage);
console.log(JSON.stringify(result, null, 2));
@@ -1,45 +0,0 @@
# Interview parent state lifetime
17 November 2026; final revalidation 18 November 2026. Development checkpoint based on A3 `eb253877`, branch `codex/interview-parent-lifetime`. Scope is the interview-preparation and follow-up parent components and their unit tests. No runtime locale expansion, model/service calls, schema changes, production work or approval changes.
## Reproduced defects and fix
On unchanged baseline, deferred reads for application 7 were completed after rendering application 8. Seven regression cases failed: previous prep content replaced the current board; previous follow-up data overwrote a current draft; stale errors appeared in either current surface; stale finalisers dismissed either current loading state; and parent drafts/data survived the application boundary, causing a failed new follow-up read to expose old editable data instead of a GET-only retry.
A second pre-fix run added three cases: an older same-application refresh replaced a newer board, and a late prep addition cleared the new application's title draft and initiated a previous-application reload (both failed); a late follow-up write already retained its original API target (positive control passed). Thus nine expected failing regressions and one passing control were observed before editing production code; overlapping reruns are not additional unique tests.
The exported prep/follow-up components now render a job-keyed private workspace, following the existing keyed interview-assistant ownership pattern. Changing job unmounts its board, drafts, error and busy state together. A per-workspace active flag and read sequence guard read success/error/finally, and prevent an unmounted workspace from starting a refresh after an existing write completes. Only the newest read can update a mounted owner. Explicit writes retain their original closure/API target; no write is cancelled, migrated to another application or retried automatically. Same-application language changes keep the same workspace and its drafts.
Two additional same-application controls exercise stale errors and stale finalisers while a newer refresh remains pending. Existing rerender tests now await remount reads inside `act`, avoiding React test warnings caused by unawaited new parent workspaces. No test suppresses console output.
## Verification
Commands from `job-tracker-ui`:
```powershell
rtk proxy node node_modules/jest/bin/jest.js --runInBand --runTestsByPath src/interview-prep.test.tsx --cacheDirectory='../.test-cache'
rtk proxy node node_modules/typescript/bin/tsc --noEmit --incremental false
rtk proxy node node_modules/eslint/bin/eslint.js src/components/InterviewPrep.tsx src/interview-prep.test.tsx --max-warnings=0
```
- Final focused jsdom suite: **63/63 passed**, no snapshots, no React warnings. This includes 12 added cases and the existing 51; prior focused runs are not added to that total.
- Native runner receipt: [jest-results.json](jest-results.json), produced with `--json --outputFile='../docs/validation/interview-parent-lifetime/jest-results.json'` added to the command above. Final revalidation passed 63/63 with zero failed/pending tests and 23.206 seconds reported by the runner. This is a repeat of the same source-bound cases, not an additional 63 distinct tests.
- Full UI TypeScript check: passed, exit 0.
- Scoped lint: passed, exit 0, zero warnings. An earlier cleanup-ref lint warning was fixed by checking the active flag on completion instead of mutating the read ref during cleanup.
- `rtk git diff --check`: passed.
- Graph-first query used the existing isolated A3 research graph before source inspection. `rtk proxy graphify update .` performed AST-only extraction in this new worktree, without API/model calls or shared graph mutation. The initial refresh created 19,835 nodes and 48,044 edges; an incremental refresh followed the final source/test edits. Generated graph output is local untracked research material, not a new runtime dependency. Graph reported missing optional PDF/SQL extraction dependencies and unsupported/no-symbol files; this is structural orientation, not full runtime or document analysis.
Existing dependencies were accessed read-only through a directory junction to `E:/Storage/Projects/Active/temp docs/jobjakt-local-build/next-security-patch/job-tracker-ui/node_modules`. No install/build/browser lane ran.
Validated working-file SHA-256:
| File | SHA-256 |
| --- | --- |
| `job-tracker-ui/src/components/InterviewPrep.tsx` | `57d208df5880d8b93c9a3acf13e7b11d2791f4a9d3fdf55da56debe68c3145ee` |
| `job-tracker-ui/src/interview-prep.test.tsx` | `82c36af6225d4fb00fb689bf7243ef2163b6abc237c91a7058f283c173d34471` |
## Limits and integration
Browser/native/device, broader repository suites, hosted CI, backend/database, live AI, provider and production checks were not run. Root owns source-bound browser qualification, integration/publication and central tracking. This checkpoint does not grant release or roadmap-stage approval.
Adjacent existing behaviour remains: ordinary same-application board refresh hides/remounts row editors through `Shell`'s loading condition; preserving row-local unsaved answers during every ordinary refresh needs a separate behavioural decision and test package. This fix prevents superseded reads from replacing the newest board/draft state; it does not redesign refresh presentation or persistence. Pending writes may still finish on the original application after navigation, as explicitly initiated by the user.
File diff suppressed because one or more lines are too long
@@ -43,10 +43,6 @@ function Shell({ title, subtitle, loading, error, children, onRetry, keepContent
}
export function ApplicationInterviewPrep({ jobId }: { jobId: number }) {
return <InterviewPrepWorkspace key={jobId} jobId={jobId} />;
}
function InterviewPrepWorkspace({ jobId }: { jobId: number }) {
const { t } = useI18n();
const [board, setBoard] = useState<InterviewPrepBoard | null>(null);
const [error, setError] = useState<{ cause: unknown; fallback: "interviewPrepLoadFailed" | "interviewPrepUpdateFailed" | "interviewPrepAnswerSaveFailed" } | null>(null);
@@ -54,26 +50,16 @@ function InterviewPrepWorkspace({ jobId }: { jobId: number }) {
const [busy, setBusy] = useState(false);
const [title, setTitle] = useState("");
const [category, setCategory] = useState(INTERVIEW_PREP_CATEGORIES[0].key);
const active = useRef(true);
const readSequence = useRef(0);
useLayoutEffect(() => {
active.current = true;
return () => { active.current = false; };
}, []);
const load = useCallback(async () => {
if (!active.current) return;
const request = ++readSequence.current;
setLoading(true);
try {
const result = await interviewPrepApi.get(jobId);
if (!active.current || request !== readSequence.current) return;
setBoard(result);
setBoard(await interviewPrepApi.get(jobId));
setError(null);
} catch (err) {
if (active.current && request === readSequence.current) setError({ cause: err, fallback: "interviewPrepLoadFailed" });
setError({ cause: err, fallback: "interviewPrepLoadFailed" });
} finally {
if (active.current && request === readSequence.current) setLoading(false);
setLoading(false);
}
}, [jobId]);
@@ -438,10 +424,6 @@ function PrepRow({ jobId, item, busy, onChanged, onError }: {
}
export function ApplicationFollowUp({ jobId }: { jobId: number }) {
return <FollowUpWorkspace key={jobId} jobId={jobId} />;
}
function FollowUpWorkspace({ jobId }: { jobId: number }) {
const { t } = useI18n();
const [data, setData] = useState<FollowUp | null>(null);
const [error, setError] = useState<{ cause: unknown; fallback: "interviewFollowUpLoadFailed" | "interviewFollowUpSaveFailed" } | null>(null);
@@ -449,28 +431,19 @@ function FollowUpWorkspace({ jobId }: { jobId: number }) {
const [busy, setBusy] = useState(false);
const [date, setDate] = useState<string>("");
const [action, setAction] = useState<string>("");
const active = useRef(true);
const readSequence = useRef(0);
useLayoutEffect(() => {
active.current = true;
return () => { active.current = false; };
}, []);
const load = useCallback(async () => {
if (!active.current) return;
const request = ++readSequence.current;
setLoading(true);
try {
const result = await interviewPrepApi.followUp(jobId);
if (!active.current || request !== readSequence.current) return;
setData(result);
setDate(result.followUpAt ? result.followUpAt.slice(0, 10) : "");
setAction(result.nextAction ?? "");
setError(null);
} catch (err) {
if (active.current && request === readSequence.current) setError({ cause: err, fallback: "interviewFollowUpLoadFailed" });
setError({ cause: err, fallback: "interviewFollowUpLoadFailed" });
} finally {
if (active.current && request === readSequence.current) setLoading(false);
setLoading(false);
}
}, [jobId]);
+4 -133
View File
@@ -63,135 +63,6 @@ beforeEach(() => {
window.localStorage.setItem("uiLanguage", "en");
});
function deferredRead() {
let resolve!: (value: any) => void;
let reject!: (reason: unknown) => void;
const promise = new Promise<any>((yes, no) => { resolve = yes; reject = no; });
return { promise, resolve, reject };
}
test.each(['success', 'failure', 'pending-newer'] as const)('a newer preparation refresh wins against an older %s completion', async completion => {
mockedApi.get.mockReset(); routeGet();
const read = mockedApi.get.getMockImplementation()!;
const older = deferredRead(); const newer = deferredRead();
let reads = 0;
mockedApi.get.mockImplementation((url: string) => url.endsWith('/interview-prep') && ++reads > 1 ? (reads === 2 ? older.promise : newer.promise) : read(url));
const firstWrite = deferredRead(); const secondWrite = deferredRead();
mockedApi.patch.mockReset().mockReturnValueOnce(firstWrite.promise).mockReturnValueOnce(secondWrite.promise);
render(<ApplicationInterviewPrep jobId={7} />);
fireEvent.click(await screen.findByRole('checkbox', { name: 'Ready: Funding history' }));
fireEvent.click(screen.getByRole('checkbox', { name: 'Ready: Tell me about a conflict' }));
await act(async () => firstWrite.resolve({ data: {} }));
await act(async () => secondWrite.resolve({ data: {} }));
expect(reads).toBe(3);
if (completion === 'pending-newer') {
await act(async () => older.resolve({ data: board }));
const region = within(screen.getByRole('region', { name: translations.en.interviewPrepTitle }));
expect(region.getByRole('progressbar', { name: translations.en.loading })).toBeVisible();
expect(region.queryByLabelText(translations.en.interviewPrepAddLabel)).not.toBeInTheDocument();
}
const currentBoard = { ...board, groups: [{ ...board.groups[0], items: [{ ...board.groups[0].items[0], title: 'Newest board' }] }] };
await act(async () => newer.resolve({ data: currentBoard }));
expect(await screen.findByText('Newest board')).toBeVisible();
fireEvent.change(screen.getByLabelText(translations.en.interviewPrepAddLabel), { target: { value: 'Current draft' } });
if (completion === 'success') await act(async () => older.resolve({ data: board }));
if (completion === 'failure') await act(async () => older.reject(new Error('Older refresh failure')));
expect(screen.getByText('Newest board')).toBeVisible();
expect(screen.queryByText(translations.en.interviewPrepLoadFailed)).not.toBeInTheDocument();
expect(screen.getByLabelText(translations.en.interviewPrepAddLabel)).toHaveValue('Current draft');
});
test.each(['prep', 'follow-up'] as const)('late %s write keeps its original target and cannot clear a new application draft', async surface => {
mockedApi.get.mockReset(); routeGet();
const write = deferredRead();
mockedApi.post.mockReset().mockReturnValueOnce(write.promise);
mockedApi.put.mockReset().mockReturnValueOnce(write.promise);
const component = (id: number) => surface === 'prep' ? <ApplicationInterviewPrep jobId={id} /> : <ApplicationFollowUp jobId={id} />;
const label = surface === 'prep' ? translations.en.interviewPrepAddLabel : translations.en.workspaceNextAction;
const view = render(component(7));
fireEvent.change(await screen.findByLabelText(label), { target: { value: 'Original application write' } });
fireEvent.click(screen.getByRole('button', { name: translations.en[surface === 'prep' ? 'interviewPrepAdd' : 'save'] }));
await act(async () => view.rerender(<I18nProvider><ConfirmProvider>{component(8)}</ConfirmProvider></I18nProvider>));
fireEvent.change(await screen.findByLabelText(label), { target: { value: 'New application draft' } });
await act(async () => write.resolve({ data: surface === 'prep' ? board.groups[0].items[0] : followUp }));
expect(screen.getByLabelText(label)).toHaveValue('New application draft');
expect(surface === 'prep' ? mockedApi.post : mockedApi.put).toHaveBeenCalledTimes(1);
expect((surface === 'prep' ? mockedApi.post : mockedApi.put).mock.calls[0][0]).toBe(`/jobapplications/7/${surface === 'prep' ? 'interview-prep' : 'follow-up'}`);
expect(mockedApi.get.mock.calls.filter(([url]) => url === '/jobapplications/7/interview-prep')).toHaveLength(surface === 'prep' ? 1 : 0);
});
test.each(['prep', 'follow-up'] as const)('late %s read cannot replace the current application or its draft', async surface => {
mockedApi.get.mockReset(); routeGet();
const read = mockedApi.get.getMockImplementation()!;
const old = deferredRead();
const suffix = surface === 'prep' ? 'interview-prep' : 'follow-up';
mockedApi.get.mockImplementation((url: string) => url === `/jobapplications/7/${suffix}` ? old.promise : read(url));
const component = (id: number) => surface === 'prep' ? <ApplicationInterviewPrep jobId={id} /> : <ApplicationFollowUp jobId={id} />;
const view = render(component(7));
await act(async () => view.rerender(<I18nProvider><ConfirmProvider>{component(8)}</ConfirmProvider></I18nProvider>));
const label = surface === 'prep' ? translations.en.interviewPrepAddLabel : translations.en.workspaceNextAction;
fireEvent.change(await screen.findByLabelText(label), { target: { value: 'Current application draft' } });
const oldData = surface === 'prep'
? { ...board, groups: [{ ...board.groups[0], items: [{ ...board.groups[0].items[0], title: 'Previous application only' }] }] }
: { ...followUp, nextAction: 'Previous application only' };
await act(async () => old.resolve({ data: oldData }));
expect(screen.getByLabelText(label)).toHaveValue('Current application draft');
expect(screen.queryByText('Previous application only')).not.toBeInTheDocument();
expect(screen.queryByDisplayValue('Previous application only')).not.toBeInTheDocument();
expect(mockedApi.post).not.toHaveBeenCalled(); expect(mockedApi.put).not.toHaveBeenCalled();
});
test.each(['prep', 'follow-up'] as const)('late %s read failure cannot hide the current draft', async surface => {
mockedApi.get.mockReset(); routeGet();
const read = mockedApi.get.getMockImplementation()!;
const old = deferredRead();
const suffix = surface === 'prep' ? 'interview-prep' : 'follow-up';
mockedApi.get.mockImplementation((url: string) => url === `/jobapplications/7/${suffix}` ? old.promise : read(url));
const component = (id: number) => surface === 'prep' ? <ApplicationInterviewPrep jobId={id} /> : <ApplicationFollowUp jobId={id} />;
const view = render(component(7));
await act(async () => view.rerender(<I18nProvider><ConfirmProvider>{component(8)}</ConfirmProvider></I18nProvider>));
const label = surface === 'prep' ? translations.en.interviewPrepAddLabel : translations.en.workspaceNextAction;
fireEvent.change(await screen.findByLabelText(label), { target: { value: 'Current application draft' } });
await act(async () => old.reject(new Error('Previous application failure')));
expect(screen.queryByText(translations.en[surface === 'prep' ? 'interviewPrepLoadFailed' : 'interviewFollowUpLoadFailed'])).not.toBeInTheDocument();
expect(screen.getByLabelText(label)).toHaveValue('Current application draft');
});
test.each(['prep', 'follow-up'] as const)('late %s finally cannot dismiss the current application loading state', async surface => {
mockedApi.get.mockReset(); routeGet();
const read = mockedApi.get.getMockImplementation()!;
const old = deferredRead(); const current = deferredRead();
const suffix = surface === 'prep' ? 'interview-prep' : 'follow-up';
mockedApi.get.mockImplementation((url: string) => url.endsWith(`/${suffix}`) ? (url.includes('/7/') ? old.promise : current.promise) : read(url));
const component = (id: number) => surface === 'prep' ? <ApplicationInterviewPrep jobId={id} /> : <ApplicationFollowUp jobId={id} />;
const view = render(component(7));
await act(async () => view.rerender(<I18nProvider><ConfirmProvider>{component(8)}</ConfirmProvider></I18nProvider>));
await act(async () => old.resolve({ data: surface === 'prep' ? board : followUp }));
const region = within(screen.getByRole('region', { name: translations.en[surface === 'prep' ? 'interviewPrepTitle' : 'interviewFollowUpTitle'] }));
expect(region.getByRole('progressbar', { name: translations.en.loading })).toBeVisible();
expect(region.queryByLabelText(translations.en[surface === 'prep' ? 'interviewPrepAddLabel' : 'workspaceNextAction'])).not.toBeInTheDocument();
await act(async () => current.resolve({ data: surface === 'prep' ? board : followUp }));
expect(await region.findByLabelText(translations.en[surface === 'prep' ? 'interviewPrepAddLabel' : 'workspaceNextAction'])).toBeVisible();
});
test('changing application resets parent drafts and a failed follow-up read retains a GET-only retry', async () => {
mockedApi.get.mockReset(); routeGet();
const read = mockedApi.get.getMockImplementation()!;
mockedApi.get.mockImplementation((url: string) => url === '/jobapplications/8/follow-up' ? Promise.reject(new Error('Current read failure')) : read(url));
const view = render(<ApplicationInterviewPrep jobId={7} />);
fireEvent.change(await screen.findByLabelText(translations.en.interviewPrepAddLabel), { target: { value: 'Application seven draft' } });
await screen.findByDisplayValue(followUp.nextAction);
await act(async () => view.rerender(<I18nProvider><ConfirmProvider><ApplicationInterviewPrep jobId={8} /></ConfirmProvider></I18nProvider>));
expect(await screen.findByLabelText(translations.en.interviewPrepAddLabel)).toHaveValue('');
expect(await screen.findByText(translations.en.interviewFollowUpLoadFailed)).toBeVisible();
const region = within(screen.getByRole('region', { name: translations.en.interviewFollowUpTitle }));
expect(region.queryByLabelText(translations.en.workspaceNextAction)).not.toBeInTheDocument();
mockedApi.get.mockImplementation(read);
fireEvent.click(region.getByRole('button', { name: translations.en.retry }));
expect(await region.findByLabelText(translations.en.workspaceNextAction)).toHaveValue(followUp.nextAction);
expect(mockedApi.put).not.toHaveBeenCalled();
});
test.each(['en', 'nb'] as const)('pending preparation deletion follows %s without a preparation reload or answer loss', async from => {
localStorage.setItem('uiLanguage', from);
const to = from === 'en' ? 'nb' : 'en';
@@ -481,7 +352,7 @@ test('late generation cannot offer another application the previous application
fireEvent.change(screen.getByLabelText(translations.en.coverAiAdditionalInstructions), { target: { value: 'Private instructions for application seven' } });
fireEvent.click(screen.getByRole('button', { name: translations.en.interviewAiGenerate }));
await waitFor(() => expect(mockedApi.post).toHaveBeenCalledTimes(1));
await act(async () => view.rerender(<I18nProvider><ConfirmProvider><ApplicationInterviewPrep jobId={8} /></ConfirmProvider></I18nProvider>));
view.rerender(<I18nProvider><ConfirmProvider><ApplicationInterviewPrep jobId={8} /></ConfirmProvider></I18nProvider>);
await act(async () => finish({ data: { result: { text: 'Only for application seven' } } }));
const assistant = within(screen.getByRole('region', { name: translations.en.interviewAiTitle }));
expect(assistant.queryByText('Only for application seven')).not.toBeInTheDocument();
@@ -497,7 +368,7 @@ test('completed AI suggestion is scoped to its application instead of becoming a
await screen.findByText('Backend CV');
fireEvent.click(screen.getByRole('button', { name: translations.en.interviewAiGenerate }));
expect(await screen.findByText('Prepared for application seven only')).toBeVisible();
await act(async () => view.rerender(<I18nProvider><ConfirmProvider><ApplicationInterviewPrep jobId={8} /></ConfirmProvider></I18nProvider>));
view.rerender(<I18nProvider><ConfirmProvider><ApplicationInterviewPrep jobId={8} /></ConfirmProvider></I18nProvider>);
const assistant = within(screen.getByRole('region', { name: translations.en.interviewAiTitle }));
expect(assistant.queryByText('Prepared for application seven only')).not.toBeInTheDocument();
expect(assistant.queryByRole('button', { name: translations.en.interviewAiAddToPrep })).not.toBeInTheDocument();
@@ -514,7 +385,7 @@ test('late accepted suggestion does not reload the previous application board in
await screen.findByText('Application seven suggestion');
fireEvent.click(screen.getByRole('button', { name: translations.en.interviewAiAddToPrep }));
await waitFor(() => expect(mockedApi.post).toHaveBeenCalledTimes(2));
await act(async () => view.rerender(<I18nProvider><ConfirmProvider><ApplicationInterviewPrep jobId={8} /></ConfirmProvider></I18nProvider>));
view.rerender(<I18nProvider><ConfirmProvider><ApplicationInterviewPrep jobId={8} /></ConfirmProvider></I18nProvider>);
await waitFor(() => expect(mockedApi.get).toHaveBeenCalledWith('/jobapplications/8/interview-prep'));
await act(async () => finish({ data: board.groups[0].items[0] }));
expect(mockedApi.get.mock.calls.filter(([url]) => url === '/jobapplications/7/interview-prep')).toHaveLength(1);
@@ -573,7 +444,7 @@ test.each(['en', 'nb'] as const)('changing application hides the previous linked
mockedApi.get.mockImplementation((url: string) => url === '/jobapplications/8/cv' ? pending as any : read(url));
const view = render(<ApplicationInterviewPrep jobId={7} />);
await screen.findByText('Backend CV');
await act(async () => view.rerender(<I18nProvider><ConfirmProvider><ApplicationInterviewPrep jobId={8} /></ConfirmProvider></I18nProvider>));
view.rerender(<I18nProvider><ConfirmProvider><ApplicationInterviewPrep jobId={8} /></ConfirmProvider></I18nProvider>);
const assistant = within(screen.getByRole('region', { name: translations[language].interviewAiTitle }));
expect(assistant.queryByText('Backend CV')).not.toBeInTheDocument();
expect(assistant.getByRole('progressbar', { name: translations[language].loading })).toBeVisible();