Compare commits
4 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| f6143b9c7d | |||
| a6a95e81d0 | |||
| 910573f836 | |||
| 7a2b8a95c1 |
@@ -5,6 +5,7 @@
|
||||
<Nullable>enable</Nullable>
|
||||
<IsPackable>false</IsPackable>
|
||||
<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
|
||||
<DefaultItemExcludes>$(DefaultItemExcludes);PdfBrowserStub/**</DefaultItemExcludes>
|
||||
</PropertyGroup>
|
||||
|
||||
<ItemGroup>
|
||||
@@ -24,14 +25,19 @@
|
||||
<ProjectReference Include="..\JobTrackerApi\JobTrackerApi.csproj" />
|
||||
<!-- Build the fixture, but only our explicit subdirectory copy owns its output.
|
||||
The Linux apphost has no .exe suffix and collides with that directory if copied to root. -->
|
||||
<ProjectReference Include="PdfBrowserStub/PdfBrowserStub.csproj" ReferenceOutputAssembly="false" Private="false" />
|
||||
<Compile Remove="PdfBrowserStub/**/*.cs" />
|
||||
<ProjectReference Include="PdfBrowserStub/PdfBrowserStub.csproj" ReferenceOutputAssembly="false" Private="false" OutputItemType="PdfBrowserStubAssembly" />
|
||||
</ItemGroup>
|
||||
|
||||
<Target Name="CopyPdfBrowserStub" AfterTargets="Build">
|
||||
<Error Condition="'@(PdfBrowserStubAssembly)' == ''" Text="The PDF browser stub project returned no output assembly." />
|
||||
<PropertyGroup>
|
||||
<PdfBrowserStubOutput>@(PdfBrowserStubAssembly->'%(RootDir)%(Directory)%(Filename)')</PdfBrowserStubOutput>
|
||||
</PropertyGroup>
|
||||
<ItemGroup>
|
||||
<PdfBrowserFiles Include="PdfBrowserStub/bin/$(Configuration)/net9.0/*" />
|
||||
<PdfBrowserFiles Include="$(PdfBrowserStubOutput).*" />
|
||||
<!-- The Unix apphost is the only fixture file without an extension. -->
|
||||
<PdfBrowserFiles Include="$(PdfBrowserStubOutput)" Condition="$([System.IO.File]::Exists('$(PdfBrowserStubOutput)'))" />
|
||||
</ItemGroup>
|
||||
<Copy SourceFiles="@(PdfBrowserFiles)" DestinationFolder="$(TargetDir)PdfBrowserStub" />
|
||||
<Copy SourceFiles="@(PdfBrowserFiles)" DestinationFolder="$(TargetDir)PdfBrowserStub" SkipUnchangedFiles="true" />
|
||||
</Target>
|
||||
</Project>
|
||||
|
||||
@@ -934,6 +934,32 @@ public sealed class ProfileCvControllerTests
|
||||
Assert.Contains("42", json, StringComparison.OrdinalIgnoreCase);
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("Expérience", "Expe\u0301rience", "## Éducation")]
|
||||
[InlineData("Γλώσσες", "Γλώσσες", "## Εκπαίδευση")]
|
||||
[InlineData("Språk", "Languages", "## Utdanning")]
|
||||
[InlineData("Portfolio – 2026", "Portfolio – 2026", "## Certificates")]
|
||||
[InlineData("Expérience", "Expérience", "Projets supplémentaires")]
|
||||
[InlineData("Språk", "Languages", "Utdanning:")]
|
||||
public async Task Rewrite_preview_replaces_only_the_selected_document_section(string heading, string selected, string nextHeading)
|
||||
{
|
||||
var source = $"## {heading}\r\n\r\nTravail en équipe\r\nOriginal work.\r\n{nextHeading}\r\nKeep this content.";
|
||||
var user = new ApplicationUser { Id = "user-1", ProfileCvText = source };
|
||||
var users = CreateUserManager();
|
||||
users.Setup(x => x.GetUserAsync(It.IsAny<ClaimsPrincipal>())).ReturnsAsync(user);
|
||||
var ai = new Mock<ISummarizerService>();
|
||||
ai.Setup(x => x.SummarizeSectionAsync(It.IsAny<string>(), It.IsAny<string>(), 900, 180))
|
||||
.ReturnsAsync("Updated work.");
|
||||
await using var db = CreateDb();
|
||||
var controller = CreateController(users.Object, ai.Object, db, CreatePaths());
|
||||
var action = await controller.BuildRewritePreview(new ProfileCvController.RewriteSectionRequest { SectionName = selected });
|
||||
var preview = Assert.IsType<ProfileCvPreviewDto>(Assert.IsType<OkObjectResult>(action.Result).Value);
|
||||
|
||||
Assert.Equal($"## {heading}\nUpdated work.\n\n{nextHeading}\nKeep this content.", preview.FullText.ReplaceLineEndings("\n"));
|
||||
ai.Verify(x => x.SummarizeSectionAsync(It.IsAny<string>(), It.Is<string>(text => text.Contains("Original work.") && !text.Contains("Keep this content.")), 900, 180), Times.Once);
|
||||
Assert.Equal(source, user.ProfileCvText);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Parse_returns_structured_cv_and_persists_it()
|
||||
{
|
||||
|
||||
@@ -581,6 +581,9 @@ public sealed partial class ProfileCvController : ControllerBase
|
||||
: string.Join("\n\n", structuredCv.Sections.Select(section => $"## {section.Name}\n{section.Content}"));
|
||||
}
|
||||
|
||||
if (sourceText is not null && FindRewriteSection(sourceText, sectionName) is { } range)
|
||||
return sourceText[range.Start..range.End].Trim();
|
||||
|
||||
var matchingSection = structuredCv.Sections.FirstOrDefault(section => string.Equals(section.Name, sectionName, StringComparison.OrdinalIgnoreCase));
|
||||
if (matchingSection is not null && !string.IsNullOrWhiteSpace(matchingSection.Content))
|
||||
{
|
||||
@@ -618,6 +621,33 @@ public sealed partial class ProfileCvController : ControllerBase
|
||||
return null;
|
||||
}
|
||||
|
||||
private static readonly Regex RewriteHeading = new(
|
||||
@"^(?:(?<marker>#{1,2})[ \t]+(?<name>[^\r\n]+?)|(?<name>[\p{Lu}\p{Lt}][\p{L}\p{M} &/]+?))(?<colon>:)?[ \t]*\r?$",
|
||||
RegexOptions.Multiline | RegexOptions.CultureInvariant);
|
||||
|
||||
private static (int Start, int End, string Name)? FindRewriteSection(string text, string sectionName)
|
||||
{
|
||||
var target = NormalizeRewriteSectionName(sectionName.Normalize());
|
||||
foreach (Match heading in RewriteHeading.Matches(text))
|
||||
{
|
||||
var name = heading.Groups["name"].Value.Trim();
|
||||
if (!string.Equals(NormalizeRewriteSectionName(name.Normalize()), target, StringComparison.OrdinalIgnoreCase))
|
||||
continue;
|
||||
var next = heading.NextMatch();
|
||||
if (heading.Groups["marker"].Success && next.Success &&
|
||||
!next.Groups["marker"].Success && !next.Groups["colon"].Success &&
|
||||
!SectionAliases.ContainsKey(next.Groups["name"].Value.Trim()))
|
||||
{
|
||||
// The first unmarked line may be prose. Preserve later legacy headings even without a blank separator.
|
||||
var bodyStart = heading.Index + heading.Length;
|
||||
if (text.AsSpan(bodyStart, next.Index - bodyStart).Trim().IsEmpty)
|
||||
next = next.NextMatch();
|
||||
}
|
||||
return (heading.Index, next.Success ? next.Index : text.Length, name);
|
||||
}
|
||||
return null;
|
||||
}
|
||||
|
||||
private static string ReplaceOrAppendCvSection(string source, string sectionName, string sectionDraft)
|
||||
{
|
||||
var trimmedSource = (source ?? string.Empty).Trim();
|
||||
@@ -625,20 +655,14 @@ public sealed partial class ProfileCvController : ControllerBase
|
||||
if (string.IsNullOrWhiteSpace(trimmedDraft)) return trimmedSource;
|
||||
if (string.IsNullOrWhiteSpace(trimmedSource)) return $"## {sectionName}\n{trimmedDraft}";
|
||||
|
||||
var normalizedHeading = sectionName.Trim().ToLowerInvariant();
|
||||
var headingPattern = new Regex(@"^(##\s+|#\s+)?(?<name>[A-Z][A-Za-z &/]+):?\s*$", RegexOptions.Multiline);
|
||||
var matches = headingPattern.Matches(trimmedSource).ToList();
|
||||
var targetIndex = matches.FindIndex(match => string.Equals(match.Groups["name"].Value.Trim(), normalizedHeading, StringComparison.OrdinalIgnoreCase));
|
||||
if (targetIndex < 0)
|
||||
if (FindRewriteSection(trimmedSource, sectionName) is not { } range)
|
||||
{
|
||||
return $"{trimmedSource}\n\n## {sectionName}\n{trimmedDraft}".Trim();
|
||||
}
|
||||
|
||||
var start = matches[targetIndex].Index;
|
||||
var end = targetIndex + 1 < matches.Count ? matches[targetIndex + 1].Index : trimmedSource.Length;
|
||||
var before = trimmedSource[..start].TrimEnd();
|
||||
var after = trimmedSource[end..].TrimStart();
|
||||
return string.Join("\n\n", new[] { before, $"## {sectionName}\n{trimmedDraft}", after }.Where(part => !string.IsNullOrWhiteSpace(part))).Trim();
|
||||
var before = trimmedSource[..range.Start].TrimEnd();
|
||||
var after = trimmedSource[range.End..].TrimStart();
|
||||
return string.Join("\n\n", new[] { before, $"## {range.Name}\n{trimmedDraft}", after }.Where(part => !string.IsNullOrWhiteSpace(part))).Trim();
|
||||
}
|
||||
|
||||
private static IReadOnlyList<CvTemplateDescriptor> GetCvTemplateDescriptors()
|
||||
|
||||
@@ -0,0 +1,28 @@
|
||||
# Public landing preview measurements
|
||||
|
||||
The landing page now reserves the space occupied by its three 1440 × 900 SVG previews while the files are in flight. The dashboard preview begins within the first viewport on desktop and tablet and keeps its default eager load. The two subsequent previews use the browser’s native lazy loading. All three retain their original files, order and translated alternative text.
|
||||
|
||||
## Local browser results
|
||||
|
||||
Each row covers two cold Chromium 151.0.7922.34 contexts, English/light and Norwegian Bokmål/dark. The probe served the real static exports on loopback with synthetic signed-out authentication responses. It held the SVG response bodies until it could measure their pending layout. The displacement column measures the change in the last preview’s bottom edge in CSS pixels between pending and decoded states. The request and byte columns cover the three previews and the favicon only. The server served these assets uncompressed.
|
||||
|
||||
| Viewport | Preview displacement before → after | Initial asset requests before → after | Initial body bytes before → after |
|
||||
| --- | ---: | ---: | ---: |
|
||||
| 1440 × 900 | 1,132 → 0 | 4 → 4 | 28,397 → 28,397 |
|
||||
| 768 × 1024 | 1,346 → 0 | 4 → 4 | 28,397 → 28,397 |
|
||||
| 390 × 844 | 668 → 0 | 4 → 4 | 28,397 → 28,397 |
|
||||
| 320 × 568 | 537 → 0 | 4 → 4 | 28,397 → 28,397 |
|
||||
| 844 × 390 | 1,488 → 0 | 4 → 3 | 28,397 → 18,036 |
|
||||
|
||||
All ten comparisons retained the exact settled top, width, height and alternative text of each image. Chromium loaded the 10,361-byte workspace preview on scroll in both landscape-phone samples. Scrolling through the page decoded every image once per sample. In the other eight samples Chromium prefetched the secondary images before scrolling.
|
||||
|
||||
Every cold context requested the 1,017-byte SVG favicon. Requests for the ICO, manifest and PWA PNGs totaled zero in this navigation sample. Those assets remain available for other browser and install flows. Browser prefetch distances can vary. Production latency, field Core Web Vitals, other browser engines, physical devices and the future launch design remain open.
|
||||
|
||||
## Reproduction and verification
|
||||
|
||||
From an installed `job-tracker-ui` checkout, run `node ../docs/performance/landing-previews/measure.mjs <static-export-directory>` for each build. The JSON output includes pending and settled image rectangles, local request paths, response-body sizes and the browser version. The probe checks the document language, successful image decoding, accessible labels and absence of unexpected application requests or errors. The paired receipts are [before](before.json.gz) and [after](after.json.gz).
|
||||
|
||||
- Application source baseline `245f2feaa8bee2db8f5da0797b3e33f6ef8b056e`. The baseline export resided at checkout `171e616b`. Git reported an empty `job-tracker-ui` diff between those commits. Baseline index SHA-256 `31dfd9b2d2e7ea7d9e696b5485d24d7b8daf0b1e078e6539e94a04955b8ff1f8`.
|
||||
- Candidate landing component blob `a73053174690588c5764f09683d5cabb0fe270e8`. Candidate index SHA-256 `8a8c1121f8a54fad47b91348346ca483bc0e4c06bd1211c85de525931a9d46d8`. Both checkouts used lockfile SHA-256 `1f718d8faa55f5e540d3d7886a51dd19b02b916b6cb23a462ae229e388d7ab98`.
|
||||
- The new regression check caught missing native width and height attributes on the first implementation with MUI Box. The final native images passed. Three suites passed 41 tests covering landing content, language, auth redirect and public auth presentation. Scoped ESLint passed. The ordinary Next 16.4.6 production build passed TypeScript checking and static export.
|
||||
- PERF-04 and PERF-15 remain partial. Launch image selection and rights, install-specific devices, other app routes and deployed delivery require their own evidence. A revert of this application change restores the previous eager previews and loading geometry.
|
||||
Binary file not shown.
Binary file not shown.
@@ -0,0 +1,95 @@
|
||||
// Run from an installed job-tracker-ui checkout. The argument is a built static export.
|
||||
import assert from 'node:assert/strict';
|
||||
import { readFile } from 'node:fs/promises';
|
||||
import { createServer } from 'node:http';
|
||||
import { createRequire } from 'node:module';
|
||||
import path from 'node:path';
|
||||
|
||||
const { chromium } = createRequire(path.resolve('package.json'))('playwright');
|
||||
const root = path.resolve(process.argv[2] || 'out');
|
||||
const previews = ['/mockups/dashboard.svg', '/mockups/pipeline.svg', '/mockups/workspace.svg'];
|
||||
const tracked = new Set([...previews, '/favicon.svg', '/favicon.ico', '/logo192.png', '/logo512.png', '/manifest.json']);
|
||||
const mime = { '.html': 'text/html', '.css': 'text/css', '.js': 'application/javascript', '.svg': 'image/svg+xml', '.ico': 'image/x-icon', '.png': 'image/png', '.json': 'application/json' };
|
||||
const requests = [];
|
||||
let imageGate;
|
||||
const server = createServer(async (req, res) => {
|
||||
try {
|
||||
const pathname = new URL(req.url, 'http://localhost').pathname;
|
||||
const file = path.resolve(root, '.' + (pathname === '/' ? '/index.html' : pathname));
|
||||
if (req.method !== 'GET' || !file.startsWith(root + path.sep)) {
|
||||
res.writeHead(400).end();
|
||||
return;
|
||||
}
|
||||
const body = await readFile(file);
|
||||
if (tracked.has(pathname)) requests.push({ path: pathname, bytes: body.length });
|
||||
if (previews.includes(pathname)) await imageGate;
|
||||
res.writeHead(200, { 'Content-Type': mime[path.extname(file)] || 'application/octet-stream', 'Cache-Control': 'no-store' });
|
||||
res.end(body);
|
||||
} catch {
|
||||
res.writeHead(404).end();
|
||||
}
|
||||
});
|
||||
|
||||
await new Promise(resolve => server.listen(0, '127.0.0.1', resolve));
|
||||
const origin = 'http://127.0.0.1:' + server.address().port;
|
||||
const browser = await chromium.launch({ channel: 'chromium', args: ['--disable-background-networking'] });
|
||||
try {
|
||||
const states = [];
|
||||
for (const [width, height] of [[1440, 900], [768, 1024], [390, 844], [320, 568], [844, 390]]) {
|
||||
for (const [lang, theme] of [['en', 'light'], ['nb', 'dark']]) {
|
||||
const begin = requests.length;
|
||||
let release;
|
||||
imageGate = new Promise(resolve => { release = resolve; });
|
||||
const context = await browser.newContext({ viewport: { width, height }, deviceScaleFactor: 1, colorScheme: theme, serviceWorkers: 'block' });
|
||||
const page = await context.newPage();
|
||||
const unexpected = [];
|
||||
page.on('pageerror', error => unexpected.push(error.message));
|
||||
await page.addInitScript(({ lang, theme }) => {
|
||||
localStorage.setItem('uiLanguage', lang);
|
||||
localStorage.setItem('jobtracker.themeMode', theme);
|
||||
}, { lang, theme });
|
||||
await context.route('**/*', route => {
|
||||
const url = new URL(route.request().url());
|
||||
const local = ['127.0.0.1', 'localhost'].includes(url.hostname);
|
||||
if (local && route.request().method() === 'GET' && url.pathname === '/api/auth/me') return route.fulfill({ status: 401, json: {} });
|
||||
if (local && route.request().method() === 'GET' && url.pathname === '/api/auth/config') {
|
||||
return route.fulfill({ json: { requireAuth: true, localEnabled: true, allowRegistration: true } });
|
||||
}
|
||||
if (origin === url.origin && !url.pathname.startsWith('/api/')) return route.continue();
|
||||
unexpected.push(url.pathname);
|
||||
return route.abort();
|
||||
});
|
||||
|
||||
const images = page.locator('main img[src^="/mockups/"]');
|
||||
const boxes = () => images.evaluateAll(nodes => nodes.map(image => {
|
||||
const rect = image.getBoundingClientRect();
|
||||
return { src: image.getAttribute('src'), top: Math.round(rect.top + scrollY), width: Math.round(rect.width), height: Math.round(rect.height), alt: image.alt, naturalWidth: image.naturalWidth, naturalHeight: image.naturalHeight };
|
||||
}));
|
||||
await page.goto(origin, { waitUntil: 'domcontentloaded' });
|
||||
await page.getByRole('heading', { level: 1 }).waitFor();
|
||||
await images.nth(2).waitFor({ state: 'attached' });
|
||||
await page.evaluate(() => new Promise(resolve => requestAnimationFrame(() => requestAnimationFrame(resolve))));
|
||||
const pending = await boxes();
|
||||
release();
|
||||
await page.waitForLoadState('networkidle');
|
||||
const before = await boxes();
|
||||
const initial = requests.slice(begin);
|
||||
assert.equal(await page.locator('html').getAttribute('lang'), lang === 'nb' ? 'nb-NO' : 'en');
|
||||
for (const image of await images.all()) {
|
||||
await image.scrollIntoViewIfNeeded();
|
||||
await image.evaluate(element => element.decode());
|
||||
}
|
||||
const after = await boxes();
|
||||
assert.deepEqual(after.map(image => image.src), previews);
|
||||
assert.ok(after.every(image => image.alt && image.naturalWidth === 1440 && image.naturalHeight === 900));
|
||||
assert.deepEqual(unexpected, []);
|
||||
states.push({ width, height, lang, theme, pending, before, after, initial, settled: requests.slice(begin) });
|
||||
await context.close();
|
||||
}
|
||||
}
|
||||
console.log(JSON.stringify({ browser: browser.version(), states }, null, 2));
|
||||
} finally {
|
||||
await browser.close();
|
||||
server.closeAllConnections();
|
||||
await new Promise(resolve => server.close(resolve));
|
||||
}
|
||||
@@ -0,0 +1,15 @@
|
||||
# PDF admission test fixture
|
||||
|
||||
Verified on Windows x64 with SDK 9.0.317, VSTest 17.14.1 and a locked restore from the local NuGet package cache. The source baseline was `245f2feaa8bee2db8f5da0797b3e33f6ef8b056e`.
|
||||
|
||||
| Build | Test selection | Result |
|
||||
| --- | --- | --- |
|
||||
| Before fix, Release with a fresh `--artifacts-path` | `Default_limit_refuses_second_actual_browser_until_first_exits` | FAILED. The SDK built the stub in the requested location. The test output lacked the stub and the exporter reported that no browser was available. |
|
||||
| After fix, Release with a fresh `--artifacts-path` | `PdfRenderAdmissionTests` | PASSED, 22 of 22. |
|
||||
| After fix, Debug with the conventional output directory | `PdfRenderAdmissionTests` | PASSED, the same 22 of 22. |
|
||||
|
||||
Both successful runs built and launched the fixture through `dotnet test`. In each output layout the fixture directory contained exactly the apphost, assembly, symbols, dependency manifest and runtime configuration. All five SHA-256 hashes matched the corresponding stub project output. The conventional stub project's `bin` and `obj` directories already existed during the final relocated run and were excluded from the test content.
|
||||
|
||||
To repeat with restored dependencies, use `dotnet test JobTrackerApi.Tests/JobTrackerApi.Tests.csproj -c Debug --filter FullyQualifiedName~PdfRenderAdmissionTests`. For the relocated case, use `-c Release` and add `--artifacts-path <fresh-directory>`.
|
||||
|
||||
These tests exercise local process admission, cancellation and cleanup with the synthetic browser. Linux execution, visual PDF acceptance and production rendering remain separate qualifications.
|
||||
@@ -20,3 +20,15 @@ No fresh export build/native browser journey, real API/session/cookie-switch int
|
||||
Evidence is under [cv-library-lifetime](evidence/cv-library-lifetime/SOURCE_RECEIPTS.json). Normalised source hashes and raw receipt hashes bind this bounded result.
|
||||
|
||||
AST graph refresh PASSED on an exact 1,003-file tracked-code snapshot on E: (E:/Storage/Projects/Active/temp docs/jobjakt-local-build/a3-cv-library-source). SOURCE_MANIFEST.json binds files to source commit de2fb452; 10,345 nodes and 36,111 edges. 51 no-symbol warnings retained. Code-only snapshot excludes documentation. Stale generated integration graph: all 2,721 files (97,063,540 bytes) preserved and SHA256-verified on E before replacing its C directory with a junction; no tracked source or evidence removed.
|
||||
|
||||
## Concurrent rename in the library · 20 November 2026
|
||||
|
||||
On application source `7a2b8a95c146d67bc4584740e4a72740cfc25cbf`, the rename dialog opened with the listed name. After confirmation the library fetched the current CV and used its latest revision and settings to write the requested name. A second editor could rename the same CV while that dialog was open. The subsequent write adopted the second editor’s revision and silently replaced their name. If both editors chose the same name the redundant write also created a revision.
|
||||
|
||||
The library now compares the name shown in the dialog with the name returned by the existing detail read. When they differ it shows the latest persisted name and skips the write. If the requested name differs as well, the existing localised conflict message appears. A user can reopen Rename on the current name and explicitly retry. A concurrent change confined to settings still allows a rename, using the latest settings and expected revision. A change after the detail read remains subject to server revision checks.
|
||||
|
||||
**Reproduction and verification.** Both added component cases failed on the original source because a PUT was issued. The corrected combined run passed **77 distinct cases in three suites** (47 CV library, 15 CV helpers, 15 session boundary), zero failed or skipped. The conflict case verifies an explicit retry sends exactly one PUT with the current revision and settings. The equal-name case verifies zero PUTs and no conflict alert. TypeScript, scoped ESLint and Git whitespace checks passed. Raw Jest results are in the local `cv-library-rename-verification` evidence directory. SHA-256 values are `1841f3d9e7199d6f8e6deb886d2581a93f36b66273e3083075e5fd2dd2a46ba5` (red) and `8db570ffa120e80dc047db98ad2f3368a586cd35791a164343ee150742312495` (final). An intermediate invocation included a misspelled suite path and exited 1. Its two successful suites and the separate corrected session-suite run overlap the final 77.
|
||||
|
||||
**Evidence scope.** The tests render the real library and prompt with mocked transport. A native two-tab/browser run, real database writes, PDF rendering and full integrated acceptance were outside this execution. The earlier 85-case verification above is historical. The changed library source blob is `4b5018c6e549a4c5711dcc84a00082629af0ef80` and test blob is `448f46e977f4c733b3d99265e500fed8ee7779bf`.
|
||||
|
||||
The AST-only Graphify refresh completed with 20,198 nodes and 50,033 edges. SQL extraction was unavailable and 146 source files yielded no symbols.
|
||||
|
||||
@@ -509,6 +509,41 @@ test('a rename conflict keeps the original library entry and never retries the w
|
||||
expect(mockedApi.delete).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
test.each(['My proposed name', 'Name from another editor'])(
|
||||
'a concurrent rename preserves the saved title before applying "%s"', async proposedName => {
|
||||
const latest = { ...existingCv, name: 'Name from another editor', version: 7, settings: emptyCvVariantSettings('clean') };
|
||||
mockedApi.get.mockImplementation(async url => ({ data: url === '/cv/variants' ? [existingCv]
|
||||
: url === '/cv/variants/1' ? latest : themes }) as any);
|
||||
mockedApi.put.mockResolvedValue({ data: { ...latest, name: proposedName, version: 8 } } as any);
|
||||
renderPage();
|
||||
await screen.findByText(existingCv.name);
|
||||
await selectAction('Rename');
|
||||
fireEvent.change(await screen.findByRole('textbox'), { target: { value: proposedName } });
|
||||
fireEvent.click(screen.getByRole('button', { name: 'Rename' }));
|
||||
|
||||
await waitFor(() => expect(mockedApi.get).toHaveBeenCalledWith('/cv/variants/1'));
|
||||
await waitFor(() => expect(screen.getByRole('link')).toHaveAttribute('aria-disabled', 'false'));
|
||||
expect(mockedApi.put).not.toHaveBeenCalled();
|
||||
expect(screen.getByRole('link', { name: 'Open Name from another editor' })).toBeInTheDocument();
|
||||
if (proposedName === latest.name) {
|
||||
expect(screen.queryByText('CV changed elsewhere')).not.toBeInTheDocument();
|
||||
return;
|
||||
}
|
||||
expect(screen.getByText('CV changed elsewhere')).toBeInTheDocument();
|
||||
fireEvent.click(screen.getByRole('button', { name: 'Actions for Name from another editor' }));
|
||||
fireEvent.click(await screen.findByRole('menuitem', { name: 'Rename' }));
|
||||
const retry = await screen.findByRole('textbox');
|
||||
expect(retry).toHaveValue(latest.name);
|
||||
fireEvent.change(retry, { target: { value: proposedName } });
|
||||
fireEvent.click(screen.getByRole('button', { name: 'Rename' }));
|
||||
expect(await screen.findByRole('link', { name: 'Open My proposed name' })).toBeInTheDocument();
|
||||
expect(mockedApi.put).toHaveBeenCalledTimes(1);
|
||||
expect(mockedApi.put).toHaveBeenCalledWith('/cv/variants/1', {
|
||||
name: proposedName, settings: latest.settings, source: 'manual', expectedVersion: latest.version,
|
||||
});
|
||||
},
|
||||
);
|
||||
|
||||
test('cancelling deletion returns focus to the surviving CV action control without removing the CV', async () => {
|
||||
mockedApi.get.mockImplementation(async (url) => ({ data: url === '/cv/variants' ? [existingCv] : themes }) as any);
|
||||
renderPage();
|
||||
|
||||
@@ -50,6 +50,22 @@ test("shows exactly Free and Pro without invented commercial terms", async () =>
|
||||
expect(mockNavigate).toHaveBeenCalledWith("/login", { state: { from: "/settings" } });
|
||||
});
|
||||
|
||||
test("reserves preview dimensions and keeps the first preview eager", async () => {
|
||||
render(<MemoryRouter><I18nProvider><LandingPage /></I18nProvider></MemoryRouter>);
|
||||
const previews = await screen.findAllByRole("img");
|
||||
expect(previews.map(image => image.getAttribute("src"))).toEqual([
|
||||
"/mockups/dashboard.svg", "/mockups/pipeline.svg", "/mockups/workspace.svg",
|
||||
]);
|
||||
for (const image of previews) {
|
||||
expect(image).toHaveAttribute("width", "1440");
|
||||
expect(image).toHaveAttribute("height", "900");
|
||||
expect(image).toHaveAccessibleName();
|
||||
}
|
||||
expect(previews[0]).not.toHaveAttribute("loading", "lazy");
|
||||
expect(previews[1]).toHaveAttribute("loading", "lazy");
|
||||
expect(previews[2]).toHaveAttribute("loading", "lazy");
|
||||
});
|
||||
|
||||
test.each([
|
||||
["en", "Norsk bokmål", "nb", "nb-NO", "To tydelige alternativer"],
|
||||
["nb", "English", "en", "en", "Two clear plans"],
|
||||
|
||||
@@ -173,15 +173,23 @@ export default function CvBuilderPage() {
|
||||
if (!active) return;
|
||||
const current = variants.find((item) => item.id === id);
|
||||
try {
|
||||
const nextName = await promptForValue({ key: "cvDashboardRenameMessage" }, current?.name ?? "", { title: { key: "cvDashboardRenameCv" }, confirmLabel: { key: "cvDashboardRename" } });
|
||||
if (!active() || !nextName?.trim() || nextName.trim() === current?.name) return;
|
||||
const input = await promptForValue({ key: "cvDashboardRenameMessage" }, current?.name ?? "", { title: { key: "cvDashboardRenameCv" }, confirmLabel: { key: "cvDashboardRename" } });
|
||||
const nextName = input?.trim();
|
||||
if (!active() || !nextName || nextName === current?.name) return;
|
||||
setPending(true);
|
||||
const variant = await cvBuilderApi.get(id);
|
||||
if (!active()) return;
|
||||
const updated = await cvBuilderApi.save(id, { name: nextName.trim(), settings: variant.settings, source: "manual", expectedVersion: variant.version });
|
||||
const renamedElsewhere = variant.name !== current?.name;
|
||||
const updated = renamedElsewhere ? variant : await cvBuilderApi.save(id, {
|
||||
name: nextName, settings: variant.settings, source: "manual", expectedVersion: variant.version,
|
||||
});
|
||||
if (!active()) return;
|
||||
setVariants((items) => items.map((item) => item.id === id ? { ...item, name: updated.name, updatedAtUtc: updated.updatedAtUtc, version: updated.version } : item));
|
||||
toast(localeRef.current("cvDashboardRenamed"), "success");
|
||||
if (renamedElsewhere && updated.name !== nextName) {
|
||||
setActionError({ key: "cvEditorConflict" });
|
||||
} else {
|
||||
toast(localeRef.current("cvDashboardRenamed"), "success");
|
||||
}
|
||||
} catch (err) { if (active()) setActionError({ error: err, key: "cvDashboardRenameFailed" }); }
|
||||
finally { finishAction(active); }
|
||||
};
|
||||
|
||||
@@ -138,20 +138,20 @@ export default function LandingPage() {
|
||||
</Box>
|
||||
|
||||
{/* Product preview */}
|
||||
<Container maxWidth="lg" sx={{ py: { xs: 6, md: 9 } }}>
|
||||
<Container maxWidth="lg" sx={{ py: { xs: 6, md: 9 }, "& img": { width: "100%", height: "auto", display: "block" } }}>
|
||||
<Box sx={{ textAlign: "center", mb: 5 }}>
|
||||
<Typography sx={{ color: "primary.main", fontWeight: 700, letterSpacing: 1, fontSize: 13 }}>{t("landingPreviewEyebrow")}</Typography>
|
||||
<Typography component="h2" sx={{ fontWeight: 800, fontSize: { xs: 26, md: 34 }, lineHeight: 1.4, mt: 1 }}>{t("landingPreviewTitle")}</Typography>
|
||||
</Box>
|
||||
<Box sx={{ borderRadius: 3, overflow: "hidden", border: "1px solid", borderColor: "divider", boxShadow: 10, mb: 3, bgcolor: "background.paper" }}>
|
||||
<Box component="img" src="/mockups/dashboard.svg" alt={t("landingDashboardAlt")} sx={{ width: "100%", display: "block" }} />
|
||||
<img src="/mockups/dashboard.svg" alt={t("landingDashboardAlt")} width={1440} height={900} />
|
||||
</Box>
|
||||
<Box sx={{ display: "grid", gridTemplateColumns: { xs: "1fr", md: "1fr 1fr" }, gap: 3 }}>
|
||||
<Box sx={{ borderRadius: 3, overflow: "hidden", border: "1px solid", borderColor: "divider", boxShadow: 6, bgcolor: "background.paper" }}>
|
||||
<Box component="img" src="/mockups/pipeline.svg" alt={t("landingPipelineAlt")} sx={{ width: "100%", display: "block" }} />
|
||||
<img src="/mockups/pipeline.svg" alt={t("landingPipelineAlt")} width={1440} height={900} loading="lazy" />
|
||||
</Box>
|
||||
<Box sx={{ borderRadius: 3, overflow: "hidden", border: "1px solid", borderColor: "divider", boxShadow: 6, bgcolor: "background.paper" }}>
|
||||
<Box component="img" src="/mockups/workspace.svg" alt={t("landingWorkspaceAlt")} sx={{ width: "100%", display: "block" }} />
|
||||
<img src="/mockups/workspace.svg" alt={t("landingWorkspaceAlt")} width={1440} height={900} loading="lazy" />
|
||||
</Box>
|
||||
</Box>
|
||||
<Typography sx={{ textAlign: "center", color: "text.secondary", fontSize: 13, mt: 2 }}>{t("landingPreviewCaption")}</Typography>
|
||||
|
||||
Reference in New Issue
Block a user