Compare commits

..

1 Commits

Author SHA1 Message Date
cesnimda 2aaf7a2426 fix(test): resolve PDF fixture from SDK build output 2026-11-20 08:57:19 +01:00
8 changed files with 29 additions and 147 deletions
+10 -4
View File
@@ -5,6 +5,7 @@
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
<DefaultItemExcludes>$(DefaultItemExcludes);PdfBrowserStub/**</DefaultItemExcludes>
</PropertyGroup>
<ItemGroup>
@@ -24,14 +25,19 @@
<ProjectReference Include="..\JobTrackerApi\JobTrackerApi.csproj" />
<!-- Build the fixture, but only our explicit subdirectory copy owns its output.
The Linux apphost has no .exe suffix and collides with that directory if copied to root. -->
<ProjectReference Include="PdfBrowserStub/PdfBrowserStub.csproj" ReferenceOutputAssembly="false" Private="false" />
<Compile Remove="PdfBrowserStub/**/*.cs" />
<ProjectReference Include="PdfBrowserStub/PdfBrowserStub.csproj" ReferenceOutputAssembly="false" Private="false" OutputItemType="PdfBrowserStubAssembly" />
</ItemGroup>
<Target Name="CopyPdfBrowserStub" AfterTargets="Build">
<Error Condition="'@(PdfBrowserStubAssembly)' == ''" Text="The PDF browser stub project returned no output assembly." />
<PropertyGroup>
<PdfBrowserStubOutput>@(PdfBrowserStubAssembly->'%(RootDir)%(Directory)%(Filename)')</PdfBrowserStubOutput>
</PropertyGroup>
<ItemGroup>
<PdfBrowserFiles Include="PdfBrowserStub/bin/$(Configuration)/net9.0/*" />
<PdfBrowserFiles Include="$(PdfBrowserStubOutput).*" />
<!-- The Unix apphost is the only fixture file without an extension. -->
<PdfBrowserFiles Include="$(PdfBrowserStubOutput)" Condition="$([System.IO.File]::Exists('$(PdfBrowserStubOutput)'))" />
</ItemGroup>
<Copy SourceFiles="@(PdfBrowserFiles)" DestinationFolder="$(TargetDir)PdfBrowserStub" />
<Copy SourceFiles="@(PdfBrowserFiles)" DestinationFolder="$(TargetDir)PdfBrowserStub" SkipUnchangedFiles="true" />
</Target>
</Project>
@@ -1,28 +0,0 @@
# Public landing preview measurements
The landing page now reserves the space occupied by its three 1440 × 900 SVG previews while the files are in flight. The dashboard preview begins within the first viewport on desktop and tablet and keeps its default eager load. The two subsequent previews use the browser’s native lazy loading. All three retain their original files, order and translated alternative text.
## Local browser results
Each row covers two cold Chromium 151.0.7922.34 contexts, English/light and Norwegian Bokmål/dark. The probe served the real static exports on loopback with synthetic signed-out authentication responses. It held the SVG response bodies until it could measure their pending layout. The displacement column measures the change in the last preview’s bottom edge in CSS pixels between pending and decoded states. The request and byte columns cover the three previews and the favicon only. The server served these assets uncompressed.
| Viewport | Preview displacement before → after | Initial asset requests before → after | Initial body bytes before → after |
| --- | ---: | ---: | ---: |
| 1440 × 900 | 1,132 → 0 | 4 → 4 | 28,397 → 28,397 |
| 768 × 1024 | 1,346 → 0 | 4 → 4 | 28,397 → 28,397 |
| 390 × 844 | 668 → 0 | 4 → 4 | 28,397 → 28,397 |
| 320 × 568 | 537 → 0 | 4 → 4 | 28,397 → 28,397 |
| 844 × 390 | 1,488 → 0 | 4 → 3 | 28,397 → 18,036 |
All ten comparisons retained the exact settled top, width, height and alternative text of each image. Chromium loaded the 10,361-byte workspace preview on scroll in both landscape-phone samples. Scrolling through the page decoded every image once per sample. In the other eight samples Chromium prefetched the secondary images before scrolling.
Every cold context requested the 1,017-byte SVG favicon. Requests for the ICO, manifest and PWA PNGs totaled zero in this navigation sample. Those assets remain available for other browser and install flows. Browser prefetch distances can vary. Production latency, field Core Web Vitals, other browser engines, physical devices and the future launch design remain open.
## Reproduction and verification
From an installed `job-tracker-ui` checkout, run `node ../docs/performance/landing-previews/measure.mjs <static-export-directory>` for each build. The JSON output includes pending and settled image rectangles, local request paths, response-body sizes and the browser version. The probe checks the document language, successful image decoding, accessible labels and absence of unexpected application requests or errors. The paired receipts are [before](before.json.gz) and [after](after.json.gz).
- Application source baseline `245f2feaa8bee2db8f5da0797b3e33f6ef8b056e`. The baseline export resided at checkout `171e616b`. Git reported an empty `job-tracker-ui` diff between those commits. Baseline index SHA-256 `31dfd9b2d2e7ea7d9e696b5485d24d7b8daf0b1e078e6539e94a04955b8ff1f8`.
- Candidate landing component blob `a73053174690588c5764f09683d5cabb0fe270e8`. Candidate index SHA-256 `8a8c1121f8a54fad47b91348346ca483bc0e4c06bd1211c85de525931a9d46d8`. Both checkouts used lockfile SHA-256 `1f718d8faa55f5e540d3d7886a51dd19b02b916b6cb23a462ae229e388d7ab98`.
- The new regression check caught missing native width and height attributes on the first implementation with MUI Box. The final native images passed. Three suites passed 41 tests covering landing content, language, auth redirect and public auth presentation. Scoped ESLint passed. The ordinary Next 16.4.6 production build passed TypeScript checking and static export.
- PERF-04 and PERF-15 remain partial. Launch image selection and rights, install-specific devices, other app routes and deployed delivery require their own evidence. A revert of this application change restores the previous eager previews and loading geometry.
Binary file not shown.
Binary file not shown.
@@ -1,95 +0,0 @@
// Run from an installed job-tracker-ui checkout. The argument is a built static export.
import assert from 'node:assert/strict';
import { readFile } from 'node:fs/promises';
import { createServer } from 'node:http';
import { createRequire } from 'node:module';
import path from 'node:path';
const { chromium } = createRequire(path.resolve('package.json'))('playwright');
const root = path.resolve(process.argv[2] || 'out');
const previews = ['/mockups/dashboard.svg', '/mockups/pipeline.svg', '/mockups/workspace.svg'];
const tracked = new Set([...previews, '/favicon.svg', '/favicon.ico', '/logo192.png', '/logo512.png', '/manifest.json']);
const mime = { '.html': 'text/html', '.css': 'text/css', '.js': 'application/javascript', '.svg': 'image/svg+xml', '.ico': 'image/x-icon', '.png': 'image/png', '.json': 'application/json' };
const requests = [];
let imageGate;
const server = createServer(async (req, res) => {
try {
const pathname = new URL(req.url, 'http://localhost').pathname;
const file = path.resolve(root, '.' + (pathname === '/' ? '/index.html' : pathname));
if (req.method !== 'GET' || !file.startsWith(root + path.sep)) {
res.writeHead(400).end();
return;
}
const body = await readFile(file);
if (tracked.has(pathname)) requests.push({ path: pathname, bytes: body.length });
if (previews.includes(pathname)) await imageGate;
res.writeHead(200, { 'Content-Type': mime[path.extname(file)] || 'application/octet-stream', 'Cache-Control': 'no-store' });
res.end(body);
} catch {
res.writeHead(404).end();
}
});
await new Promise(resolve => server.listen(0, '127.0.0.1', resolve));
const origin = 'http://127.0.0.1:' + server.address().port;
const browser = await chromium.launch({ channel: 'chromium', args: ['--disable-background-networking'] });
try {
const states = [];
for (const [width, height] of [[1440, 900], [768, 1024], [390, 844], [320, 568], [844, 390]]) {
for (const [lang, theme] of [['en', 'light'], ['nb', 'dark']]) {
const begin = requests.length;
let release;
imageGate = new Promise(resolve => { release = resolve; });
const context = await browser.newContext({ viewport: { width, height }, deviceScaleFactor: 1, colorScheme: theme, serviceWorkers: 'block' });
const page = await context.newPage();
const unexpected = [];
page.on('pageerror', error => unexpected.push(error.message));
await page.addInitScript(({ lang, theme }) => {
localStorage.setItem('uiLanguage', lang);
localStorage.setItem('jobtracker.themeMode', theme);
}, { lang, theme });
await context.route('**/*', route => {
const url = new URL(route.request().url());
const local = ['127.0.0.1', 'localhost'].includes(url.hostname);
if (local && route.request().method() === 'GET' && url.pathname === '/api/auth/me') return route.fulfill({ status: 401, json: {} });
if (local && route.request().method() === 'GET' && url.pathname === '/api/auth/config') {
return route.fulfill({ json: { requireAuth: true, localEnabled: true, allowRegistration: true } });
}
if (origin === url.origin && !url.pathname.startsWith('/api/')) return route.continue();
unexpected.push(url.pathname);
return route.abort();
});
const images = page.locator('main img[src^="/mockups/"]');
const boxes = () => images.evaluateAll(nodes => nodes.map(image => {
const rect = image.getBoundingClientRect();
return { src: image.getAttribute('src'), top: Math.round(rect.top + scrollY), width: Math.round(rect.width), height: Math.round(rect.height), alt: image.alt, naturalWidth: image.naturalWidth, naturalHeight: image.naturalHeight };
}));
await page.goto(origin, { waitUntil: 'domcontentloaded' });
await page.getByRole('heading', { level: 1 }).waitFor();
await images.nth(2).waitFor({ state: 'attached' });
await page.evaluate(() => new Promise(resolve => requestAnimationFrame(() => requestAnimationFrame(resolve))));
const pending = await boxes();
release();
await page.waitForLoadState('networkidle');
const before = await boxes();
const initial = requests.slice(begin);
assert.equal(await page.locator('html').getAttribute('lang'), lang === 'nb' ? 'nb-NO' : 'en');
for (const image of await images.all()) {
await image.scrollIntoViewIfNeeded();
await image.evaluate(element => element.decode());
}
const after = await boxes();
assert.deepEqual(after.map(image => image.src), previews);
assert.ok(after.every(image => image.alt && image.naturalWidth === 1440 && image.naturalHeight === 900));
assert.deepEqual(unexpected, []);
states.push({ width, height, lang, theme, pending, before, after, initial, settled: requests.slice(begin) });
await context.close();
}
}
console.log(JSON.stringify({ browser: browser.version(), states }, null, 2));
} finally {
await browser.close();
server.closeAllConnections();
await new Promise(resolve => server.close(resolve));
}
@@ -0,0 +1,15 @@
# PDF admission test fixture
Verified on Windows x64 with SDK 9.0.317, VSTest 17.14.1 and a locked restore from the local NuGet package cache. The source baseline was `245f2feaa8bee2db8f5da0797b3e33f6ef8b056e`.
| Build | Test selection | Result |
| --- | --- | --- |
| Before fix, Release with a fresh `--artifacts-path` | `Default_limit_refuses_second_actual_browser_until_first_exits` | FAILED. The SDK built the stub in the requested location. The test output lacked the stub and the exporter reported that no browser was available. |
| After fix, Release with a fresh `--artifacts-path` | `PdfRenderAdmissionTests` | PASSED, 22 of 22. |
| After fix, Debug with the conventional output directory | `PdfRenderAdmissionTests` | PASSED, the same 22 of 22. |
Both successful runs built and launched the fixture through `dotnet test`. In each output layout the fixture directory contained exactly the apphost, assembly, symbols, dependency manifest and runtime configuration. All five SHA-256 hashes matched the corresponding stub project output. The conventional stub project's `bin` and `obj` directories already existed during the final relocated run and were excluded from the test content.
To repeat with restored dependencies, use `dotnet test JobTrackerApi.Tests/JobTrackerApi.Tests.csproj -c Debug --filter FullyQualifiedName~PdfRenderAdmissionTests`. For the relocated case, use `-c Release` and add `--artifacts-path <fresh-directory>`.
These tests exercise local process admission, cancellation and cleanup with the synthetic browser. Linux execution, visual PDF acceptance and production rendering remain separate qualifications.
-16
View File
@@ -50,22 +50,6 @@ test("shows exactly Free and Pro without invented commercial terms", async () =>
expect(mockNavigate).toHaveBeenCalledWith("/login", { state: { from: "/settings" } });
});
test("reserves preview dimensions and keeps the first preview eager", async () => {
render(<MemoryRouter><I18nProvider><LandingPage /></I18nProvider></MemoryRouter>);
const previews = await screen.findAllByRole("img");
expect(previews.map(image => image.getAttribute("src"))).toEqual([
"/mockups/dashboard.svg", "/mockups/pipeline.svg", "/mockups/workspace.svg",
]);
for (const image of previews) {
expect(image).toHaveAttribute("width", "1440");
expect(image).toHaveAttribute("height", "900");
expect(image).toHaveAccessibleName();
}
expect(previews[0]).not.toHaveAttribute("loading", "lazy");
expect(previews[1]).toHaveAttribute("loading", "lazy");
expect(previews[2]).toHaveAttribute("loading", "lazy");
});
test.each([
["en", "Norsk bokmål", "nb", "nb-NO", "To tydelige alternativer"],
["nb", "English", "en", "en", "Two clear plans"],
+4 -4
View File
@@ -138,20 +138,20 @@ export default function LandingPage() {
</Box>
{/* Product preview */}
<Container maxWidth="lg" sx={{ py: { xs: 6, md: 9 }, "& img": { width: "100%", height: "auto", display: "block" } }}>
<Container maxWidth="lg" sx={{ py: { xs: 6, md: 9 } }}>
<Box sx={{ textAlign: "center", mb: 5 }}>
<Typography sx={{ color: "primary.main", fontWeight: 700, letterSpacing: 1, fontSize: 13 }}>{t("landingPreviewEyebrow")}</Typography>
<Typography component="h2" sx={{ fontWeight: 800, fontSize: { xs: 26, md: 34 }, lineHeight: 1.4, mt: 1 }}>{t("landingPreviewTitle")}</Typography>
</Box>
<Box sx={{ borderRadius: 3, overflow: "hidden", border: "1px solid", borderColor: "divider", boxShadow: 10, mb: 3, bgcolor: "background.paper" }}>
<img src="/mockups/dashboard.svg" alt={t("landingDashboardAlt")} width={1440} height={900} />
<Box component="img" src="/mockups/dashboard.svg" alt={t("landingDashboardAlt")} sx={{ width: "100%", display: "block" }} />
</Box>
<Box sx={{ display: "grid", gridTemplateColumns: { xs: "1fr", md: "1fr 1fr" }, gap: 3 }}>
<Box sx={{ borderRadius: 3, overflow: "hidden", border: "1px solid", borderColor: "divider", boxShadow: 6, bgcolor: "background.paper" }}>
<img src="/mockups/pipeline.svg" alt={t("landingPipelineAlt")} width={1440} height={900} loading="lazy" />
<Box component="img" src="/mockups/pipeline.svg" alt={t("landingPipelineAlt")} sx={{ width: "100%", display: "block" }} />
</Box>
<Box sx={{ borderRadius: 3, overflow: "hidden", border: "1px solid", borderColor: "divider", boxShadow: 6, bgcolor: "background.paper" }}>
<img src="/mockups/workspace.svg" alt={t("landingWorkspaceAlt")} width={1440} height={900} loading="lazy" />
<Box component="img" src="/mockups/workspace.svg" alt={t("landingWorkspaceAlt")} sx={{ width: "100%", display: "block" }} />
</Box>
</Box>
<Typography sx={{ textAlign: "center", color: "text.secondary", fontSize: 13, mt: 2 }}>{t("landingPreviewCaption")}</Typography>