cesnimda
40 lines
5.8 KiB
Markdown
40 lines
5.8 KiB
Markdown
# A3 visual correction: shared shell, CV studio and Settings
|
||
|
||
4 November 2026. Approved IM10 continuation from published `7aa54bff1fe376b798922b9da75feafa202dbb76`, incorporating the owner's global simplification and final definition of done. This is a bounded implementation checkpoint, not final IM10 or whole-application acceptance.
|
||
|
||
## Implemented
|
||
|
||
- Compact one-row phone app bar, quiet 44px icon targets and responsive desktop controls. Settings and language remain accessible in the account menu; the full drawer/hybrid navigation remains. Version metadata remains available to its existing authorised caller through the account menu when the wide badge is hidden. Search and Add Job retain their handlers and accessible names.
|
||
- Open CV document header and editor/preview panes, flat content sections and AI action rows. Real document paper, form fields and meaningful review content retain their boundaries. Editor-left/preview-right, phone Edit/Preview, autosave, undo/redo, history, sharing and export remain.
|
||
- Width-aware CV section navigation uses a labelled selector when tabs would not fit. All five section choices remain available. Panels keep accessible names; Content stays mounted across section changes. Regression covers mobile draft retention across History and Preview.
|
||
- Continuous Settings sections use existing flat PageSection treatment rather than decorative surrounding cards. No settings, confirmation or persistence contracts were removed.
|
||
- AI preference Save refreshes server-authoritative availability for the same owner without remounting Settings or discarding unrelated notification drafts. Session/lifetime/sequence checks reject stale completion and malformed grants. Different identity still triggers the existing session reset. A refresh failure is reported separately from a successfully saved preference.
|
||
- ProFeatureNotice message/actions wrap in a grid, fixing a reproduced Norwegian 320px scrollable-message accessibility defect.
|
||
|
||
## Evidence and limitations
|
||
|
||
PASSED: CV visual matrix, 36 configurations (nine widths × EN/NB × light/dark), three states each: **108 accessibility scans and screenshots**, 36 controlled review/content/preview journeys, zero document/profile writes, zero browser errors. Recorded app-bar heights are **58px phone / 66px larger layouts**. Content/preview contain no outlined Paper containers; AI review retains one meaningful proposal comparison object. See `evidence/cv/REVIEW.json`.
|
||
|
||
PASSED: mounted availability refresh, **16 controlled journeys / 64 accessibility scans and screenshots**. Four intercepted preference PUTs per configuration; unrelated form node/draft retained, malformed grant rejected, valid same-owner availability refreshed without reload, wrong-owner response clears private session. No model requests or document writes. See `../evidence/entitlement-refresh/browser/BROWSER.json`.
|
||
|
||
PASSED: TypeScript, full lint, production export build and 57-group / 34-route TypeScript census. Census is source presence and unchanged preservation requirements, not route acceptance. Physical document renderer and data/API schemas were not changed. Source review found no actionable regression; it did not independently execute browser checks.
|
||
|
||
Selected component tests initially exposed a Paper-class-dependent test selector, updated to the named review region. A new mobile test also caught incorrect test-library option typing, corrected before the passing build. A tablet rendered run exposed the desktop collapse target overlapping language controls at 768px; corrected at the responsible header layout. The failed tablet report and original Norwegian notice report remain alongside successor evidence. Failed attempts are not included in passing totals.
|
||
|
||
PASSED: final combined selected regression, **147 tests / 13 suites**, recorded in `COMBINED_TESTS.json`. Do not add overlapping focused/header reruns to it. `FOCUSED_TESTS.json`, `SHARED_TESTS.json` and `HEADER_TESTS.json` overlap.
|
||
|
||
Visual inspection compared approved mobile reference and actual current phone/desktop content, observing substantial border/padding reduction and preserved document controls. The prototype includes workshop chrome and different synthetic fixtures; raw full-image pixel equality would be misleading. [Comparison](comparison.html) retains unedited reference/before/after images. Automated matrix success is not owner visual acceptance.
|
||
|
||
## Open work and definition of done
|
||
|
||
- [ ] Current visual review and implementation/disposition of every route in `ROUTE_COVERAGE.json`, preserving all 57 groups. Shared changes alone do not qualify remaining screens.
|
||
- [ ] Resolve material discrepancies in `DISCREPANCIES.md`, including remaining nested surfaces, repeated headings/actions and inefficient layouts outside this bounded package.
|
||
- [ ] Complete connected discovery→review→track, create/import CV→edit→preview→export, application→status→follow-up and Career Profile→document reuse journeys on desktop/mobile; existing unrelated accepted evidence may be reused only when applicable.
|
||
- [ ] Review actual desktop/tablet/mobile screenshots against A3 for typography, spacing, density, alignment, navigation, responsive behaviour, themes and text expansion.
|
||
- [ ] Finish Settings section/state visual coverage and extended European-layout qualification.
|
||
- [ ] Record remaining human/device/native-language/screen-reader qualifications accurately; obtain final owner visual review when ready.
|
||
|
||
No orchestrator work, main merge, production deployment, live model/provider activation or deferred CV-import overhaul. Full Phase 10 acceptance, Global Jobs entry/provider rights, European translation completeness, integrated security/recovery and release decisions remain open.
|
||
|
||
Rollback: revert this bounded implementation commit on the feature branch; no migration/data conversion is involved. Retain failed/successor evidence for traceability. Do not undo subsequent unrelated work.
|